From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1116 invoked by alias); 31 Jan 2014 14:05:45 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 1044 invoked by uid 89); 31 Jan 2014 14:05:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oa0-f48.google.com Received: from mail-oa0-f48.google.com (HELO mail-oa0-f48.google.com) (209.85.219.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 31 Jan 2014 14:05:44 +0000 Received: by mail-oa0-f48.google.com with SMTP id l6so5185672oag.21 for ; Fri, 31 Jan 2014 06:05:42 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.60.67.105 with SMTP id m9mr1515536oet.58.1391177142164; Fri, 31 Jan 2014 06:05:42 -0800 (PST) Received: by 10.76.105.174 with HTTP; Fri, 31 Jan 2014 06:05:42 -0800 (PST) In-Reply-To: <20140131100941.GA24910@msticlxl57.ims.intel.com> References: <20140131100941.GA24910@msticlxl57.ims.intel.com> Date: Fri, 31 Jan 2014 14:05:00 -0000 Message-ID: Subject: Re: [PATCH] PR gas/16488: Add test for incorrect memory operand for gather/scatter instructions. From: "H.J. Lu" To: "Michael V. Zolotukhin" Cc: Jan Beulich , Binutils Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg00368.txt.bz2 On Fri, Jan 31, 2014 at 2:09 AM, Michael V. Zolotukhin wrote: > Hi, > > This patch adds test for incorrect memory operand for gather/scatter > instructions, thusly fixing PR16488. Ok for trunk? > > gas/testsuite/ChangeLog: > 2014-01-31 Michael Zolotukhin > > PR gas/16488 > * gas/i386/inval-avx512f.s: Add test for incorrect memory operand for > gather/scatter instructions. > * gas/i386/x86-64-inval-avx512f.s: Likewise. > * gas/i386/inval-avx512f.l: Adjust correspondingly. > * gas/i386/x86-64-inval-avx512f.l: Likewise. > > Thanks, > Michael > > diff --git a/gas/testsuite/gas/i386/inval-avx512f.s b/gas/testsuite/gas/i386/inval-avx512f.s > index b1ddba4..7c9b1d6 100644 > --- a/gas/testsuite/gas/i386/inval-avx512f.s > +++ b/gas/testsuite/gas/i386/inval-avx512f.s > @@ -15,6 +15,8 @@ _start: > vcvtps2pd (%eax){z}, %zmm1 > > vgatherqpd (%rdi,%zmm2,8),%zmm6 > + vgatherqpd (%edi),%zmm6{%k1} > + vgatherqpd (%zmm2),%zmm6{%k1} > > .intel_syntax noprefix > mov eax{k1}, {sae} > @@ -31,6 +33,7 @@ _start: > vcvtps2pd zmm1, [eax]{z} > > vgatherqpd zmm6, ZMMWORD PTR [rdi+zmm2*8] > + vgatherqpd zmm6{k1}, ZMMWORD PTR [edi] > > vaddps zmm2, zmm1, QWORD PTR [eax]{1to8} > vaddps zmm2, zmm1, QWORD PTR [eax]{1to16} > diff --git a/gas/testsuite/gas/i386/x86-64-inval-avx512f.s b/gas/testsuite/gas/i386/x86-64-inval-avx512f.s > index 5ac7349..9e8823e 100644 > --- a/gas/testsuite/gas/i386/x86-64-inval-avx512f.s > +++ b/gas/testsuite/gas/i386/x86-64-inval-avx512f.s > @@ -14,6 +14,9 @@ _start: > vcvtps2pd (%rax){%k1}, %zmm1 > vcvtps2pd (%rax){z}, %zmm1 > > + vgatherqpd (%rdi),%zmm6{%k1} > + vgatherqpd (%zmm2),%zmm6{%k1} > + > .intel_syntax noprefix > mov rax{k1}, {sae} > mov rax, {sae} > @@ -28,6 +31,8 @@ _start: > vcvtps2pd zmm1, [rax]{k1} > vcvtps2pd zmm1, [rax]{z} > > + vgatherqpd zmm6{k1}, ZMMWORD PTR [rdi] > + > vaddps zmm2, zmm1, QWORD PTR [rax]{1to8} > vaddps zmm2, zmm1, QWORD PTR [rax]{1to16} > vaddpd zmm2, zmm1, DWORD PTR [rax]{1to8} You added 2 tests for AT&T syntax, but only 1 for Intel syntax. Any particular reason for this? -- H.J.