From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hjl.tools@gmail.com>
Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com
 [IPv6:2607:f8b0:4864:20::102f])
 by sourceware.org (Postfix) with ESMTPS id C76E3385840C
 for <binutils@sourceware.org>; Mon, 14 Feb 2022 03:14:03 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C76E3385840C
Received: by mail-pj1-x102f.google.com with SMTP id
 t4-20020a17090a510400b001b8c4a6cd5dso14424864pjh.5
 for <binutils@sourceware.org>; Sun, 13 Feb 2022 19:14:03 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=FhXp/m+U0/OzzhnEITv/q8KqN/6uBLUZ8/sYyt5NyqE=;
 b=FwnzajxecqYHzJanH7eyxEeWaEmRyJ39HO7PgWarocHLciQk59lWp/ENobgaE/IDkc
 U94A//rxBWZjwL4N0jHhpzd95zqbxu7OekA/sJY/NHL2jWQgUKcZ3EcGGsfzF1B95d2C
 CE7Dd+s6Bjbc+tQoRCFOn3IJ3DdYSeWjTPOiXApwV7MAfFUPFlOawwQsLuVuuB0ydXnn
 q5MzC3zAnzOZoosyzdVEeBnnjX3VJvE8oJRa3p7s0JVIFjKkL4JRFeLaqPwZfCaRoR5e
 UOjqaJqTGp1GzuXs+fIxGXFHofJ7TV8IlBH6STcy5qtR6SxzGZ+87HYYQuHhLT/etI30
 a76w==
X-Gm-Message-State: AOAM530f98OoeZyfS0thmHVI4qCh+NHhGsg52M7fFFASXAyc+9pABEmT
 0xP6jwCxYoaNqNFvHuIGaXzPnh148fugI8TiD6s=
X-Google-Smtp-Source: ABdhPJwBKRCdFCFfeSOXUoQtz5u9mHsuONuJB3mSZ8SwIItDk3rK2ysDKZMxckHT/ICpYDJsRvd8RM4vBuQou7Ai3IM=
X-Received: by 2002:a17:90b:3eca:: with SMTP id
 rm10mr4647243pjb.120.1644808442985; 
 Sun, 13 Feb 2022 19:14:02 -0800 (PST)
MIME-Version: 1.0
References: <20220208010833.2103874-1-amodra@gmail.com>
 <20220208010833.2103874-3-amodra@gmail.com>
 <Ygm75J+479WIuEiB@squeak.grove.modra.org>
In-Reply-To: <Ygm75J+479WIuEiB@squeak.grove.modra.org>
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Sun, 13 Feb 2022 19:13:27 -0800
Message-ID: <CAMe9rOrQi_MZ4BWzkwECuQLCk4-X0FgRG-G9Yo8t14k3bPCsvQ@mail.gmail.com>
Subject: Re: [PATCH 2/4] PR28824, relro security issues, x86 keep
 COMMONPAGESIZE relro
To: Alan Modra <amodra@gmail.com>
Cc: Binutils <binutils@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-3020.8 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: binutils@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Binutils mailing list <binutils.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/binutils>,
 <mailto:binutils-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/binutils>,
 <mailto:binutils-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Feb 2022 03:14:05 -0000

On Sun, Feb 13, 2022 at 6:18 PM Alan Modra <amodra@gmail.com> wrote:
>
> On Tue, Feb 08, 2022 at 11:38:31AM +1030, Alan Modra wrote:
> > x86 treats MAXPAGESIZE as a memory optimisation parameter, actual
> > hardware paging is always COMMPAGESIZE of 4k.  Use COMMONPAGESIZE for
> > the end of the relro segment alignment.
>
> HJ, you may like to revert this patch and make x86 also align the end
> of the relro segment to MAXPAGESIZE.  That's why I extracted this part
> into a separate patch.  I'm not anywhere near 100% sure about my claim
> that x86 always uses (or can use) 4k hardware memory pages.

I will take a look tomorrow.

Thanks.

-- 
H.J.