public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Alan Modra <amodra@gmail.com>
Cc: binutils@sourceware.org, Kaylee Blake <klkblake@gmail.com>
Subject: Re: [PATCH v3 6/7] ld: Add tests for -z nosectionheader and --strip-section-headers
Date: Tue, 6 Jun 2023 10:26:26 -0700	[thread overview]
Message-ID: <CAMe9rOrS3Jj6veHngZzqq0E7tfsU+5xVsYqjrM2j0SWDTZAz9A@mail.gmail.com> (raw)
In-Reply-To: <ZH7WQ6w/Z4CC0Lrh@squeak.grove.modra.org>

On Mon, Jun 5, 2023 at 11:51 PM Alan Modra <amodra@gmail.com> wrote:
>
> On Mon, Jun 05, 2023 at 08:32:21AM -0700, H.J. Lu wrote:
> > +     if ![string match "*pr25617-1a-now-no-sec-hdr.so*file in wrong format*" $got] then {
> > +         send_log "$got\n"
> > +         fail "Update pr25617-1a-now-no-sec-hdr.so ($prog_name)"
>
> Needs a return here, otherwise you might get both a fail and a pass.

WIll fix it.

>
> > +     }
> > +
> > +     pass "Update pr25617-1a-now-no-sec-hdr.so ($prog_name)"
> > +     }
> > +}
> > +
> > +binutils_run_test ""
> > +binutils_run_test objcopy
> > +binutils_run_test strip
>
> --
> Alan Modra
> Australia Development Lab, IBM



-- 
H.J.

  reply	other threads:[~2023-06-06 17:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-05 15:32 [PATCH v3 0/7] ELF: Strip section header in ELF objects H.J. Lu
2023-06-05 15:32 ` [PATCH v3 1/7] " H.J. Lu
2023-06-05 15:32 ` [PATCH v3 2/7] ELF: Discard non-alloc sections without section header H.J. Lu
2023-06-05 15:32 ` [PATCH v3 3/7] bfd: Improve nm and objdump " H.J. Lu
2023-06-06  6:44   ` Alan Modra
2023-06-05 15:32 ` [PATCH v3 4/7] ld: Add a simple test for -z nosectionheader H.J. Lu
2023-06-05 15:32 ` [PATCH v3 5/7] binutils: Add a --strip-section-headers test H.J. Lu
2023-06-05 15:32 ` [PATCH v3 6/7] ld: Add tests for -z nosectionheader and --strip-section-headers H.J. Lu
2023-06-06  6:46   ` Alan Modra
2023-06-06 17:26     ` H.J. Lu [this message]
2023-06-06  9:57   ` Florian Weimer
2023-06-06 17:26     ` H.J. Lu
2023-06-05 15:32 ` [PATCH v3 7/7] ld: Add -z nosectionheader test to bootstrap.exp H.J. Lu
2023-06-06  6:48 ` [PATCH v3 0/7] ELF: Strip section header in ELF objects Alan Modra
2023-06-29 17:21   ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMe9rOrS3Jj6veHngZzqq0E7tfsU+5xVsYqjrM2j0SWDTZAz9A@mail.gmail.com \
    --to=hjl.tools@gmail.com \
    --cc=amodra@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=klkblake@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).