From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-87124-listarch-binutils=sources.redhat.com@sourceware.org>
Received: (qmail 127238 invoked by alias); 30 Mar 2015 13:00:24 -0000
Mailing-List: contact binutils-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <binutils.sourceware.org>
List-Subscribe: <mailto:binutils-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: binutils-owner@sourceware.org
Received: (qmail 127223 invoked by uid 89); 30 Mar 2015 13:00:23 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=4.1 required=5.0 tests=AWL,BAYES_50,FREEMAIL_FROM,KAM_FROM_URIBL_PCCC,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2
X-HELO: mail-ob0-f180.google.com
Received: from mail-ob0-f180.google.com (HELO mail-ob0-f180.google.com) (209.85.214.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 30 Mar 2015 13:00:22 +0000
Received: by obvd1 with SMTP id d1so56223831obv.0        for <binutils@sourceware.org>; Mon, 30 Mar 2015 06:00:20 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.60.133.144 with SMTP id pc16mr15684946oeb.0.1427720420216; Mon, 30 Mar 2015 06:00:20 -0700 (PDT)
Received: by 10.76.134.102 with HTTP; Mon, 30 Mar 2015 06:00:20 -0700 (PDT)
In-Reply-To: <20150330123934.GJ26234@bubble.grove.modra.org>
References: <20150319130244.GA22592@intel.com>	<20150326022246.GU26234@bubble.grove.modra.org>	<CAMe9rOrVpthhMfZEXcMkKzmHcxymfQHKuTuZPi_y36=s6KJ9iA@mail.gmail.com>	<20150328041540.GE26234@bubble.grove.modra.org>	<CAMe9rOoVzbOvdE1_apgUbHtm0gG89d3_9qbnA8=Y3Qu9MznUPA@mail.gmail.com>	<CAMe9rOp8sdCbOp0eVzRmwMhe_3c2K0EJ6fmnMMWyA01KYamzLw@mail.gmail.com>	<20150329034858.GH26234@bubble.grove.modra.org>	<CAMe9rOrJB7xNLn4FEq5+N8VbnfZuYxkM4tPNMQzOKapVheGOpQ@mail.gmail.com>	<20150330123934.GJ26234@bubble.grove.modra.org>
Date: Mon, 30 Mar 2015 13:00:00 -0000
Message-ID: <CAMe9rOrXQJmjNR4ynGD9BQJz5T8OygQekoLVsmubpFva1ff45w@mail.gmail.com>
Subject: Re: [PATCH] Reduce file size for PT_GNU_RELRO segment
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Binutils <binutils@sourceware.org>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2015-03/txt/msg00442.txt.bz2

On Mon, Mar 30, 2015 at 5:39 AM, Alan Modra <amodra@gmail.com> wrote:
> On Sun, Mar 29, 2015 at 06:58:45AM -0700, H.J. Lu wrote:
>> On Sat, Mar 28, 2015 at 8:48 PM, Alan Modra <amodra@gmail.com> wrote:
>> > lang_size_sections).  I think it important that we keep the relro base
>> > alignment code all in one place.
>>
>> It is not about the base alignment.  It is about setting the address of
>> the first section in PT_GNU_RELRO segment, given the addresses
>> of PT_GNU_RELRO segment.  It is impossible to set address of the first
>> section in PT_GNU_RELRO segment from lang_size_sections.
>
> Look again at the code for exp_dataseg_relro_adjust.  If you change
> expld.dataseg.base there you will change addresses of sections in the
> relro segment.

But I don't want to change expld.dataseg.base.  I just want to
bump the address of the first section a bit.  Currently I have

                    bfd_vma pad
                      = ((newdot - expld.dataseg.min_base)
                         % expld.dataseg.maxpagesize);
                    if (pad)
                      {
                        bfd_vma nextdot
                          = expld.dataseg.maxpagesize - pad;
                        nextdot = align_power (newdot + nextdot,
                                               section_alignment);
                        if (((nextdot - newdot)
                             < expld.dataseg.pagesize)
                            && pad > (expld.dataseg.maxpagesize
                                      - expld.dataseg.pagesize))
                          newdot = nextdot;
                      }

I can keep the address increase, nextdot - newdot, even lower
than the page size.

-- 
H.J.