From: "H.J. Lu" <hjl.tools@gmail.com>
To: Nick Clifton <nickc@redhat.com>
Cc: Binutils <binutils@sourceware.org>
Subject: [PATCH] bfd: Add a bfd_boolean argument to bfd_get_symbol_version_string
Date: Tue, 24 Mar 2020 10:47:58 -0700 [thread overview]
Message-ID: <CAMe9rOraM36mjup896hQdhC_dMY-6=3zYE58yuUzkrmTJPTgLQ@mail.gmail.com> (raw)
In-Reply-To: <55e72288-5cdd-1c6d-4ac9-d8f0042ea318@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1199 bytes --]
On Tue, Mar 24, 2020 at 3:38 AM Nick Clifton <nickc@redhat.com> wrote:
>
> Hi H.J.
>
> > bfd/
> >
> > PR binutils/25708
> > * elf-bfd.h (_bfd_elf_get_symbol_version_name): New.
> > * elf.c (_bfd_elf_get_symbol_version_name): New function. Based
> > on the previous _bfd_elf_get_symbol_version_string.
> > (_bfd_elf_get_symbol_version_string): Use it.
> >
> > binutils/
> >
> > PR binutils/25708
> > * nm.c (SYM_NAME): Removed.
> > (print_symname): Add a pointer to struct extended_symbol_info
> > argument. Call _bfd_elf_get_symbol_version_name to get symbol
> > version.
> > (print_symdef_entry): Pass NULL to print_symname.
> > (print_symbol_info_bsd): Update call to print_symname.
> > (print_symbol_info_sysv): Likewise.
> > (print_symbol_info_posix): Likewise.
> >
> > ld/
> >
> > PR binutils/25708
> > * testsuite/ld-elf/pr25707.d: New file.
>
> Approved - please apply.
>
We can't call _bfd_elf_get_symbol_version_name from nm.c since it isn't
available for all target configurations. This patch add a bfd_boolean
argument to bfd_get_symbol_version_string instead.
OK for master?
--
H.J.
[-- Attachment #2: 0001-bfd-Add-a-bfd_boolean-argument-to-bfd_get_symbol_ver.patch --]
[-- Type: application/x-patch, Size: 8246 bytes --]
next prev parent reply other threads:[~2020-03-24 17:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-22 12:29 [PATCH] bfd: Display symbol version for nm -D H.J. Lu
2020-03-24 10:38 ` Nick Clifton
2020-03-24 17:47 ` H.J. Lu [this message]
2020-03-24 21:51 ` [PATCH] bfd: Add a bfd_boolean argument to bfd_get_symbol_version_string Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOraM36mjup896hQdhC_dMY-6=3zYE58yuUzkrmTJPTgLQ@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).