From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x32b.google.com (mail-ot1-x32b.google.com [IPv6:2607:f8b0:4864:20::32b]) by sourceware.org (Postfix) with ESMTPS id DF9063858425 for ; Wed, 21 Dec 2022 17:52:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DF9063858425 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ot1-x32b.google.com with SMTP id y18-20020a0568301d9200b0067082cd4679so9495525oti.4 for ; Wed, 21 Dec 2022 09:52:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=zOUdGEdhelXNigLQiH8qFRK9YJjdM/qJ2kTYUKmwmog=; b=o7gHx2UmtbGiN60MQEFAAoi2i8iizsvd+fDIGYgAtepYOCtKm6NwmT7Dmwp3RCmgbF lK7SIb635VV/c8HTaBQghZkd2AXKO7P0uBqGC5FAh95Cxphnlim/XobAgHM5lSkNSDqG /v/TunRS14hD7+zoszNiAZX3xVM1V/+S7jkdRRKyM3jaYjtzLlreV+u77x09S2wTXUjJ ABnQsveIvArTcPUApb5LOzJMuyv8vVeTc1hoi3ygbxVWpQrb/u+xWcw7ZMTo1mdiS9ZB E24+eBUg+74uwWOqf7HlmkWtjZNryMdEYxPkkJG9DmcSeONtuNVhI312sC+H0g+wCRqX pANQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zOUdGEdhelXNigLQiH8qFRK9YJjdM/qJ2kTYUKmwmog=; b=4NnAzZjtGLawCGQYHbzC08YPMLgF8FlPHxlwGjx4IbqkzTfxlopo5K+neHS2xwkY/Q ZV+nEXlHb3DcKuLURkDIzdO3EpA5IrgzQvqocqSHj9XrulyJP7SmiSaNwG8k+SNc1QEC qnj0xvHhVDigO0txfNFEosbzFExoHJyF9ymUiHu+O3NXcVcfP1bjajQDWtymj4/g0oEj X/ZUSaKiHVzTeD3cuMWYgbUmi0dPWMoqyq7YSB5JC7aqKbjB06wnTxOAzknB+olOfPXq Lz61/5fdcewVh8dpPbGbVKsujlor4w0gBEXKFXyzvHItkP8Sxn6H0WWtym2qansfcuIW PeAQ== X-Gm-Message-State: AFqh2konOKkzYupOQ2U0vUgC9YlofyL0vsdBqJngISm4ILNcndfuKXwc d2gMWN4dag50bMTAVjtJd95CDsu9ei1EVla58qE= X-Google-Smtp-Source: AMrXdXvjVnOplUKUBxTh1Skw/6luPL2W9YW57XAjR7k3WicK+H6ppdY6c2JLsQ23qoe61JuLURo6jpiE9O0+SnN/VU4= X-Received: by 2002:a9d:6182:0:b0:678:266b:9e55 with SMTP id g2-20020a9d6182000000b00678266b9e55mr151180otk.371.1671645149114; Wed, 21 Dec 2022 09:52:29 -0800 (PST) MIME-Version: 1.0 References: <29b9b1a9-c3f8-eea1-2953-02164ee56f9f@suse.com> In-Reply-To: <29b9b1a9-c3f8-eea1-2953-02164ee56f9f@suse.com> From: "H.J. Lu" Date: Wed, 21 Dec 2022 09:51:53 -0800 Message-ID: Subject: Re: x86: remove i386-opc.c To: Jan Beulich Cc: Alan Modra , binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3023.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Dec 20, 2022 at 3:44 AM Jan Beulich wrote: > > On 20.12.2022 12:39, Alan Modra wrote: > > On Tue, Dec 20, 2022 at 09:40:14AM +0100, Jan Beulich wrote: > >> On 20.12.2022 09:33, Alan Modra via Binutils wrote: > >>> Regen opcodes/po/POTFILES.in > >>> > >>> diff --git a/opcodes/po/POTFILES.in b/opcodes/po/POTFILES.in > >>> index 9906bf14848..effd73f8f78 100644 > >>> --- a/opcodes/po/POTFILES.in > >>> +++ b/opcodes/po/POTFILES.in > >>> @@ -73,7 +73,6 @@ h8300-dis.c > >>> hppa-dis.c > >>> i386-dis.c > >>> i386-gen.c > >>> -i386-opc.c > >>> i386-opc.h > >>> ia64-asmtab.c > >>> ia64-asmtab.h > >> > >> Which makes me wonder: If this is the list of files where string literals > >> may/will need translation, are files like i386-gen.c (i.e. build time > >> helper tool sources) really supposed to be enumerated here? > > > > Probably not, but the build time tools don't tend to use gettext and > > thus all it does is slow down generation of .pot files a little. > > Which then perhaps means we want to remove > > #include > #define _(String) gettext (String) > > from i386-gen.c. H.J. - any idea why it was put there in the first place? > > Jan It is because _() is used in i386-gen.c. We can remove its usage. -- H.J.