From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x141.google.com (mail-il1-x141.google.com [IPv6:2607:f8b0:4864:20::141]) by sourceware.org (Postfix) with ESMTPS id 25A0A385703C for ; Fri, 11 Sep 2020 13:52:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 25A0A385703C Received: by mail-il1-x141.google.com with SMTP id f82so4363984ilh.8 for ; Fri, 11 Sep 2020 06:52:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ziJM1YLxvtCX+h5FILbT7gggsOA1irs8UXwqQythgXE=; b=czdNohF33tv1nbdHOGT3us1A+oxAevcbfi9+NG+bcG7/SsN0AAQkEBo7C3c8fSBz6Z CiVYuE0qTJmtN1xBC4285RI80hh4Me5egN93Y5eEk/wrhNaCqlqGokkgxIli3t43xB8r gsvVhJUaiAlOQXEOg/xjiWae8P4ptqKMzbG5EACB0IoBOKdY0S1RDECqrjkeN8Llk0kH /oHtgyVRl0pCzjpMvjgAR7IyxQELW07JlzNKV3z7nCrGJMfgGngZ8s5bxC1KSpEaUfIH 6hwe0TiwGUetJHGqWtANF+/umKjhuDTxHv+XvYmwfOUZF63mKrhN/BjKpzkW/0VbKZe3 l/+w== X-Gm-Message-State: AOAM530gyHN4wmMNiMfGYrSqCvWpoV/uCiKcoZNwoVcpnb3rRlN73za6 867Y8OrvX3fz6oe7tQR/Qc3umiYQpjjEH+QsSzU= X-Google-Smtp-Source: ABdhPJwk1HhbjALNm4U8NHcY5vDh3DZbRkEeNwiMLPpW54qZiLgvjnyUkXxHiFTtmgfqLN2P3hMcOVpVv5ES7eDIvc8= X-Received: by 2002:a92:6a0c:: with SMTP id f12mr1722779ilc.213.1599832329641; Fri, 11 Sep 2020 06:52:09 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "H.J. Lu" Date: Fri, 11 Sep 2020 06:51:33 -0700 Message-ID: Subject: Re: [PATCH] gas: Don't error when .debug_line already exists, unless .loc was used To: Nick Clifton Cc: Mark Wielaard , "binutils@sourceware.org" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Sep 2020 13:52:11 -0000 On Fri, Sep 11, 2020 at 5:48 AM Nick Clifton via Binutils wrote: > > Hi Mark, > > > The tests are unfortunately arch specific because the line table is only > > generated when actual instructions have been emitted. > > Are you sure about that ? How about using the NOP instruction ? > > I admit that some architectures do need special syntax for their > nop instructions, but there is already a test in gas testsuite > that handles this (see gas/testsuite/gas/all/gas.exp:org-1). The > nop-selecting code there could probably be extracted into a library > function then used in lots of places... > 7.66 '.nops SIZE[, CONTROL]' ============================ This directive emits SIZE bytes filled with no-op instructions. SIZE is absolute expression, which must be a positve value. CONTROL controls how no-op instructions should be generated. If the comma and CONTROL are omitted, CONTROL is assumed to be zero. -- H.J.