From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by sourceware.org (Postfix) with ESMTPS id A0261383FBB8 for ; Fri, 28 Oct 2022 15:46:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A0261383FBB8 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-x129.google.com with SMTP id p8so8909915lfu.11 for ; Fri, 28 Oct 2022 08:46:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=9omXiwnkfLSG9Ku6S8aVMYlheW0etz71WTwZJ8KEHQw=; b=H8kRNlwPzH4kAKhXI4CIZik82zGFvVedmnoqariZN0qS2qBgrifNg0SqV+GigiO48S GvsipwvcVXKUTViRkkoIH1jYA+GrH3dyie8YXLwLZfoJw0yhlcxvs1+GBsY/m4OZ3XN0 EbVEytGU9pB8rAB4VkwJd0N/WK7SfJoOzwGLELaU8QQuY5xtR0HYz7G182ql7ap3N3wG EziXWKnu0+RzZZBa5inv6JXSV/rWYH548l5SizjE2tW9H+kEd4A1c+EuHyakSgacylLO Ndczu/+I4Ylpy0/zJVKsYFPbxzMo+lx9fbVr+PL72R/F+RoEOoIRNrJvIeU+5dQ+Sd3s Axtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9omXiwnkfLSG9Ku6S8aVMYlheW0etz71WTwZJ8KEHQw=; b=eeFJgrhd+hXgICwG3NVBuD3o2QcqRkdH+2N7T5NZA36acIIqmlSxUHFjMDSjCJS42J mtXBU2gvUeyZjAVUsbsUyG0V1AKtMC4ZmNC07FTBqKkqYtvmJvJQPWV2/C47yb3huua5 5fdMCylzwj3L0T9JEY6sjKpYnqB+YdW32kk2PIK8SBCVTkfjatWrf0H1HpVa3sTH7OEL x5DXia1Ofuzs0e/RuKZtHk6gJDwoPV6gIi4Xml/1+OFM3F34+yJ+nS7J5bhdv4RCMPIo LIWmUfpgYGGCJ5OeRBbQ8TrRNQRd5jDTrpWyuPNe9JgkQH0Gf3SgcMN2xaGlqdxoVosW S0BA== X-Gm-Message-State: ACrzQf0r96OuCz32Q3by7fszkLP1loSIbwWTcuYncZjrolt5K2zEoYL5 BD/cpjGyjj1JuUbjKyq/oCShJFVZIKLV2eQS9Ho= X-Google-Smtp-Source: AMsMyM5z1mDsr0GTJY4zlWvatUypYT/ALUdhkMNandWrmr4thTLubrqdSOjtNeY0bb5aBcd0jovBgDCqtCsHi8EdCRU= X-Received: by 2002:a05:6512:4002:b0:4a2:6243:8384 with SMTP id br2-20020a056512400200b004a262438384mr19819156lfb.29.1666971987841; Fri, 28 Oct 2022 08:46:27 -0700 (PDT) MIME-Version: 1.0 References: <28044500-4513-3d31-db60-946f873524ae@suse.com> In-Reply-To: <28044500-4513-3d31-db60-946f873524ae@suse.com> From: "H.J. Lu" Date: Fri, 28 Oct 2022 08:45:51 -0700 Message-ID: Subject: Re: [PATCH] To: Jan Beulich Cc: "Joshi, Tejas Sanjay" , "Gopalasubramanian, Ganesh" , "binutils@sourceware.org" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3016.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Oct 28, 2022 at 1:15 AM Jan Beulich wrote: > > On 28.10.2022 09:20, Joshi, Tejas Sanjay wrote: > > opcodes/ > > > > * i386-dis.c (x86_64_table): Add rmpquery. > > * i386-gen.c (cpu_flag_init): Add CPU_ZNVER4_FLAGS and CpuRMPQUERY. > > You also (afaict needlessly) add CPU_RMPQUERY_FLAGS, whereas CpuRMPQUERY > isn't applicable here; you already ... > > > (cpu_flags): Add CpuRMPQUERY. > > ... mention it here, where it is applicable. > > > * i386-opc.h (enum): Add CpuRMPQUERY. > > (i386_cpu_flags): Add cpurmpquery. > > * i386-opc.tbl: Add rmpquery insn. > > The three relevant SNP insn have a comment: "The single-operand forms > exist only for compatibility with older gas." Therefore I'd like to ask > that new insns (like the one you add here) don't have that strange form > also added. Do we really need 3 forms for one insn? Also please don't put RMPQUERY insns in the middle of SNP insns. > Other than these looks largely okay to me. > > Note that commenting on patches would be easier if they were (also) > sent inline, not (just) as attachment(s). > > Jan -- H.J.