From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x1136.google.com (mail-yw1-x1136.google.com [IPv6:2607:f8b0:4864:20::1136]) by sourceware.org (Postfix) with ESMTPS id 35F9B38582A3 for ; Thu, 28 Dec 2023 15:52:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 35F9B38582A3 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 35F9B38582A3 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1136 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703778779; cv=none; b=IZcrxvqQyap/G06J0YcLCx6SkzN1OFOQHRo3jAaxGS84wFrbLcpfjd35BKYlOvdlPxpdG1RAa8GRfhk6vVnI2ycg/3YNRufbYrTQuouux0W3m3E5ZE5bONudxZuGBg2UbFGRDtEwsbFjvivvjAk9hm65deaObnt4QZv6MT1R+LE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703778779; c=relaxed/simple; bh=DJtjpqU93iPKyRe6CfGKb0IenIj/aWfJi9i6IimgRMY=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=OziTGcVC9yiDK6DlHFhom75gDO6QSWv+zV8h8T/1cqbiIToCzkaOcKvygOzmAjGpOis9fHE9VY8z4RGcoQDBS296RkMNlHlYFqrFr8h6ySxkhaNmCtGpPbYK6VDSbeXJsj/Cc1PQ5e/HpAxkodt60cme+ZxsRwkhaZtOXHAkt34= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yw1-x1136.google.com with SMTP id 00721157ae682-5ec7a5a4b34so27059777b3.0 for ; Thu, 28 Dec 2023 07:52:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703778776; x=1704383576; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gz4yPWYiZlLeT7gHZgIQ9mnHoklglbli5Y99zumcvF8=; b=g6ZopukWgFbMmjC+GIcNXWfh5t71TSQJvCsrnOXQNqy4PuVHI+BgpJA2pcHZojGJHU rv0TNl2flQnNxy4Phxm3VSi4LurLlwGFUrdZHBNBPmhG6AoQKkrs9XbI7U0AwRt/P66c EGgBj4sBrQpUgVfjrZryYEcJmCYDkVj+ddjTu62a2mp2EiPBRlZQ/jX5fK1D4FnFMv7z paaxZW6mesHKC5P8It8+IsPB0mzyiurxfTRdkjNtLC06/be9mpawHNTc/xZGiTx1sDkE CuoU31DHmX1HdMtMrvPYyGDYh7e7e7F49fo8b5t+hoTlvVrHC8EqMhedRmt3ftbVktPR dfWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703778776; x=1704383576; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gz4yPWYiZlLeT7gHZgIQ9mnHoklglbli5Y99zumcvF8=; b=TlDxmS/GjitaWeUhG3sgnHDpChDSJ+z4VrDjsY/KX74X9uIW7K/im4DUU9l3VhrfC9 n8QkbnzRMlfT76P/Li/DQb4Fw5A8kRHFFbGK2C0g3//EUeh3YSuWwhKBbuRgvTFrUe5u qTT57s5J836osSqpsYPmm20qBd5ZGD1nKZWpdqMjgjl+G2+LQ1G9UdRfvzAj18bWmU+9 6ILuJOIYx6R6ebKI41nxobZznXTE4fjsevgjE1ot7plwqKFVwNGT3WBXffmlVANSoS0w 4UneE9+OCzvaOmU7hSG5Osm1b+DIY5DslfJeXkaVPv5uD4BSPxqph/BKVKhoYg1b+m6D ixoA== X-Gm-Message-State: AOJu0YwaNviImTtKlxagygzd6nyiCJJPB3MUtZJ0gBIlOv4YuLfI/0mq yhaPuJyKmx1/KQHG75RXTvbQce3eZEn4A7nIUvU9tOBe X-Google-Smtp-Source: AGHT+IEAILBoqMq3LKzJiNkSFLGpaq5KzifsYaMnCY4+c5is+U9PKKn1H8JyZDWX+Ac/bg+M+LDXZt+upIke7vS35+0= X-Received: by 2002:a05:690c:2e04:b0:5ef:a183:a8a4 with SMTP id et4-20020a05690c2e0400b005efa183a8a4mr363341ywb.90.1703778776547; Thu, 28 Dec 2023 07:52:56 -0800 (PST) MIME-Version: 1.0 References: <20231227141921.4159400-1-christina.schimpe@intel.com> In-Reply-To: From: "H.J. Lu" Date: Thu, 28 Dec 2023 07:52:20 -0800 Message-ID: Subject: Re: [PATCH 1/1] x86: Add NT_X86_SHSTK note To: "Schimpe, Christina" Cc: "binutils@sourceware.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3021.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Dec 28, 2023 at 7:47=E2=80=AFAM Schimpe, Christina wrote: > > Hi H.J., > > Thank you for the review. > As this my first time contributing: Could you commit on my behalf? Done. > BR, > Christina > > > -----Original Message----- > > From: H.J. Lu > > Sent: Wednesday, December 27, 2023 4:59 PM > > To: Schimpe, Christina > > Cc: binutils@sourceware.org > > Subject: Re: [PATCH 1/1] x86: Add NT_X86_SHSTK note > > > > On Wed, Dec 27, 2023 at 6:20=E2=80=AFAM Schimpe, Christina > > wrote: > > > > > > Define NT_X86_SHSTK which is the note for x86 Shadow Stack (SHSTK) to > > > support Intel SHSTK in Linux kernel. > > > For now only userspace shadow stack and kernel IBT are supported by > > > the linux kernel. This note should be used instead of NT_X86_CET > > > introduced in the commit "x86: Add NT_X86_CET note", as it is outdate= d > > > and only used by old binutils versions. > > > --- > > > binutils/readelf.c | 2 ++ > > > include/elf/common.h | 3 +++ > > > 2 files changed, 5 insertions(+) > > > > > > diff --git a/binutils/readelf.c b/binutils/readelf.c index > > > 775106fb99c..a464692e1b7 100644 > > > --- a/binutils/readelf.c > > > +++ b/binutils/readelf.c > > > @@ -20079,6 +20079,8 @@ get_note_type (Filedata * filedata, unsigned > > e_type) > > > return _("NT_X86_XSTATE (x86 XSAVE extended state)"); > > > case NT_X86_CET: > > > return _("NT_X86_CET (x86 CET state)"); > > > + case NT_X86_SHSTK: > > > + return _("NT_X86_SHSTK (x86 SHSTK state)"); > > > case NT_S390_HIGH_GPRS: > > > return _("NT_S390_HIGH_GPRS (s390 upper register halves)"); > > > case NT_S390_TIMER: > > > diff --git a/include/elf/common.h b/include/elf/common.h index > > > 244b13361e5..690d78010c4 100644 > > > --- a/include/elf/common.h > > > +++ b/include/elf/common.h > > > @@ -645,6 +645,9 @@ > > > /* note name must be "LINUX= ". */ > > > #define NT_X86_CET 0x203 /* x86 CET state. */ > > > /* note name must be "LINUX= ". */ > > > +#define NT_X86_SHSTK 0x204 /* x86 SHSTK state. */ > > > + /* This replaces NT_X86_CET (= 0x203). */ > > > + /* note name must be "LINUX= ". */ > > > #define NT_S390_HIGH_GPRS 0x300 /* S/390 upper halves= of > > GPRs */ > > > /* note name must be "LINUX= ". */ > > > #define NT_S390_TIMER 0x301 /* S390 timer */ > > > -- > > > 2.34.1 > > > > > > > > > > OK. > > > > Thanks. > > > > -- > > H.J. > Intel Deutschland GmbH > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928 --=20 H.J.