From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb2f.google.com (mail-yb1-xb2f.google.com [IPv6:2607:f8b0:4864:20::b2f]) by sourceware.org (Postfix) with ESMTPS id 414063858D33 for ; Tue, 6 Feb 2024 18:06:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 414063858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 414063858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::b2f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707242817; cv=none; b=EEa2IzV58tQInGarj5qgIYLmtN2zK1r2v/BTJLU8dr5/Xtnipg5BJksVEcb77BfONOTpVbVtYEVIrsqny7iTm6F4JFVVmeY1vieh6Mp83fL8vRBooGIkTikYtic+CKo3DasZ6dr2l4xcjnZ6z9qOx80pzTBDXvBQ0asStnaRPrs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707242817; c=relaxed/simple; bh=hie8YBK7LAeIxE0kvGmNxdmt1zKvsryVFqGppHXfdoU=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=S7AO4s63x523rxvBGQAf+sxk0UVevjvC3vD+0iJahnYKh5c7ED6pM0GiZOAZgL9IIMYIdxwqltTuwL5ePz/bIViCaXa8L2VRJ20CflmcpbzKBUCjvr8Wh3pZoYK4tY5vNr8AH2L/JxXg4d11bx2192CQ4B0P+7jzKFHWcIjEaP0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yb1-xb2f.google.com with SMTP id 3f1490d57ef6-dc6d5206e96so5443351276.0 for ; Tue, 06 Feb 2024 10:06:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707242815; x=1707847615; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xtqvHNVRK+0UhsBeootn38aixP1CFgo3ULCnsdxOjJs=; b=fYj+y+LilLinNf+cpVTmXHZrBRfoezYySJvL9gye8bWgY6rnxIA2+e1oMK+3vc1n9t 5Ls6LfRxR0a3D6cAMLwZmlijbDag0cxIDKoc0RPRVCebVTCOqZy+NsvXyFtccceubs3B r0+tU4IXEs6sJVMCf0D3NakOq+l3qPPtjR9lJ8rpg7/5+qgi1LwfmFGSIlbPmkbpcMYo 7vo8TyUg/XQg28tm0gpqMPZ7CezcX5mHXg4wFWnYsUBrqdrnZ4pfY8Vw6ZJOfG+azP2Z ktsC+QZsuf6kNh12B+cUn52IxU+juL7peCjxtM1fPtdLQu9EranZMmDPPT/AkCd9ffBG 1x2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707242815; x=1707847615; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xtqvHNVRK+0UhsBeootn38aixP1CFgo3ULCnsdxOjJs=; b=U56IFx4kZgNlTj+BLWgcwwuW8OL0xtP34JMgG5fNlWz+yWHzOWJiTyyiLdXt2GQtNm 1paiJdhtPrIgmO2Xjs0BaT75zaqsy8tocGITDuasbYZzw9dDCwkJDx2O6Om7YKdxtKgN 5dFVzTq4Do1P+OBklTaU6JAP8HoArFq2BP0Z375q6+MAlMyS0nSog73GJwPsDz7eq2+E 5dALmWUeOoKt2HkG5RIxotG37wehakOL5WHWQIzmfuI6i7JX7tLxaiLzwKqgMuufMDxg MsjQSr2WgLE+fjM3y/SGRWWhdJdrGsnZ3RC49uGRlYXXXT2cXLif2DRLS8vt3o9gd/CV NISA== X-Gm-Message-State: AOJu0YzwdgER0spNlzjSJoLQFbCK8fxccD3SAzWblIRyE2WcsY+I7nUH rtWTelunpWJhPXKbryf0FKVzQ4hk1G/4S28HRLLGfkfcgOwSV+58yrbwCdKckN31tGN2nVFIccV RPpVZHfJtvAgoVySptrj8MuEW1tg= X-Google-Smtp-Source: AGHT+IGN0reHHhVqyeVG5yFRba+DrkITmYtjxgsOGIf0JXzReRr8+afW3RGZlaskqM8cDV4K4Frw5LFwqiBXqYSQ2Y0= X-Received: by 2002:a05:6902:1b03:b0:dc2:3b5f:b80 with SMTP id eh3-20020a0569021b0300b00dc23b5f0b80mr2814404ybb.44.1707242814956; Tue, 06 Feb 2024 10:06:54 -0800 (PST) MIME-Version: 1.0 References: <20240205200028.219844-1-hjl.tools@gmail.com> <4b1c3da8-d218-460b-89e6-6844096ed393@suse.com> <533a896f-8eec-b73b-cb18-26240ad822fc@suse.de> <8059bdee-392a-b9cd-41d5-8dea538c957c@suse.de> In-Reply-To: From: "H.J. Lu" Date: Tue, 6 Feb 2024 10:06:18 -0800 Message-ID: Subject: Re: [PATCH] x86: Warn .insn instruction with length > 15 bytes To: Jan Beulich Cc: binutils@sourceware.org, Michael Matz Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3014.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Feb 6, 2024 at 9:05=E2=80=AFAM Jan Beulich wrot= e: > > On 06.02.2024 17:28, H.J. Lu wrote: > > With as_bad, assembler will continue to assemble, just not generate > > an object file. We ran into this with APX. Not everyone checks > > assembler warnings closely. It led to mysterious crashes. I am > > not against it if someone else implements an assembler option to > > turn this error into a warning. > > But it should be the other way around: The compiler could pass an > option to promote the (default) warning to an error. And if you > don#t pay attention to warning for assembly files, you could pass > the same option as well. Without harming anyone else with anything People who use/need instructions > 15 bytes belong to a very small minority. If they want to do it, they can use .insn or use binutlls 2.41 or older. The default assembler isn't for them. > that has worked before. > The reason that we didn't run into the size limit before is that normal instruction usages never exceed the 15 byte limit before APX. --=20 H.J.