From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb2a.google.com (mail-yb1-xb2a.google.com [IPv6:2607:f8b0:4864:20::b2a]) by sourceware.org (Postfix) with ESMTPS id 7523D385842C for ; Wed, 7 Feb 2024 17:04:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7523D385842C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7523D385842C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::b2a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707325451; cv=none; b=Yru9NnYTl0jvuYkGDmEYwrLU0Eq6pfyWkdspV/OzHulPZv0UBlzPPLm05tXU74MEJyjvTAYZz9i8P6em4LW55RmEDqYxtRZa4I3XMYzUJIFLtbD8idqmjs1YbBJ5msJRXWWgk4vpVPoqZst9aW11H+DfU2Jp2B4Nh0OlbosgBj8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707325451; c=relaxed/simple; bh=dcqhaQ5Tk1qcl4srzsjpH+MsuqxPYsLTuti1dl7+CFM=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=pqtyMmR2o8o9ZwYpByG0zU1fWcU5lkzFrASUkK4j85P3Q38RCsKGzPNJzt/lE9nUrtRsC2kVGZ1FdsDvYCVWEvJ96fYW3SBWSqdV62ztpN+xzfxM8C+3H3/7t4NlzzcUYzPmOKjzcHvnmt786oxf8t13lAWm9cIPNAARCHY+a3M= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yb1-xb2a.google.com with SMTP id 3f1490d57ef6-dc6d8bd612dso939490276.1 for ; Wed, 07 Feb 2024 09:04:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707325449; x=1707930249; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1nbP3JOyVbGq+PJKRgYwAqRD8ZyG65LiKKnScggHbDw=; b=IQSvHmgLkcOOfQuw1NV9ZJjqKC6ecEKTknmmAS/j/OTsh0erpGNrTOohZZ5P11vA2s UqY9FoSB0mEXacAaTt1qGgWWPFAq2PHUJ2ryARYqa/npxQhdEyM47cY95D/NBH2+AQ6+ 6HK6YQPvQhG3Lmol0CQdw2tAoSTmhRtNBWMkLlObOyJeNxS80HMjzpQL+adfbVB5H8aE uRlGAmiFa8X7NQbwD/n7pTApbifb8UD/JncWAApHmd10UvDof0RMqndsEk+/fTh+l03y IC1Vt6cn7qZRDujnzmjClK1QiwTKiBHOhUWftWdvN5F4vhdZ56Gp/oFapq+o1az49ImH k/Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707325449; x=1707930249; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1nbP3JOyVbGq+PJKRgYwAqRD8ZyG65LiKKnScggHbDw=; b=uGO9AcGOBXppZiFEGze4MclqZyuE/qk0gKFDeC5vSkhmwcgM/aer3E8puk0VOOHutE HSZXonO3AzWzhiwghQbjwlaC1C/kIVpPbRK9ZUffLifXdGH+FFjPAHh6XLrPk3cExeHJ X9mm+1/N8f9xUgww1ebUzKHzEvhV06KWxklOjdUQeMgbXxyi40KnOpwxnt8BVULSsN3D QomgkVDdamq+UIOISaCxNF7XB9yuBKjxasJwPYl9c0MrdDSsZ1AM6jUS7oAaIUeVmm/Z nFlqGJLTDzF/o/bk8Y95P/j0O+tSBiq2QkrE32M4rWG+itdoSuXUeLef55RFKKw8iHy/ SMhA== X-Gm-Message-State: AOJu0Yyfu8z/FXZHIeyQispxJPV32uMMKU0XJkPZmNZ6rjBqCf/rAzly IQpY7RMdU5qATXhixT5X3lyo/czChGPVke33eQPrQG5GZhSSunvjCaIfVDhAIizoS0MQhaSzTdx OcPQIKwm7ucIE0QIZBakycgfsGyg= X-Google-Smtp-Source: AGHT+IFKlHfN3htr1OIV3ffc6KOYBoWbHOGXAs08QZ/NuxoXY8riiLgQXSVtThBz9v9MtfYwyoqyOkbZeiz9mMhpEfQ= X-Received: by 2002:a25:868f:0:b0:dc2:19ec:77ad with SMTP id z15-20020a25868f000000b00dc219ec77admr5406165ybk.21.1707325448620; Wed, 07 Feb 2024 09:04:08 -0800 (PST) MIME-Version: 1.0 References: <20240205200028.219844-1-hjl.tools@gmail.com> <4b1c3da8-d218-460b-89e6-6844096ed393@suse.com> <533a896f-8eec-b73b-cb18-26240ad822fc@suse.de> <8059bdee-392a-b9cd-41d5-8dea538c957c@suse.de> <2721d4bc-e29f-4ed1-8fac-064fe0711029@suse.com> <93ef6fde-42aa-485a-8b22-f2c1f1d52efa@suse.com> In-Reply-To: From: "H.J. Lu" Date: Wed, 7 Feb 2024 09:03:32 -0800 Message-ID: Subject: Re: [PATCH] x86: Warn .insn instruction with length > 15 bytes To: Jan Beulich Cc: binutils@sourceware.org, Michael Matz Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3014.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Feb 7, 2024 at 8:59=E2=80=AFAM Jan Beulich wrot= e: > > On 07.02.2024 17:53, H.J. Lu wrote: > > On Wed, Feb 7, 2024 at 7:32=E2=80=AFAM Jan Beulich = wrote: > >> > >> On 07.02.2024 16:24, H.J. Lu wrote: > >>> On Tue, Feb 6, 2024 at 11:51=E2=80=AFPM Jan Beulich wrote: > >>>> > >>>> On 06.02.2024 19:06, H.J. Lu wrote: > >>>>> On Tue, Feb 6, 2024 at 9:05=E2=80=AFAM Jan Beulich wrote: > >>>>>> > >>>>>> On 06.02.2024 17:28, H.J. Lu wrote: > >>>>>>> With as_bad, assembler will continue to assemble, just not genera= te > >>>>>>> an object file. We ran into this with APX. Not everyone checks > >>>>>>> assembler warnings closely. It led to mysterious crashes. I am > >>>>>>> not against it if someone else implements an assembler option to > >>>>>>> turn this error into a warning. > >>>>>> > >>>>>> But it should be the other way around: The compiler could pass an > >>>>>> option to promote the (default) warning to an error. And if you > >>>>>> don#t pay attention to warning for assembly files, you could pass > >>>>>> the same option as well. Without harming anyone else with anything > >>>>> > >>>>> People who use/need instructions > 15 bytes belong to a very small > >>>>> minority. If they want to do it, they can use .insn or use binutll= s 2.41 > >>>>> or older. The default assembler isn't for them. > >>>> > >>>> No, staying on an old assembler isn't viable. And minority or not, y= ou > >>>> have to face it: In the present discussion it is you who represents = a > >>>> minority. As such I'm even inclined to suggest that your earlier pat= ch > >>>> wants reverting, on the basis that it was put in despite there being > >>>> disagreement. Unless you soon come forward with an incremental chang= e > >>>> undoing at least the worst of its effects ... > >>> > >>> Please tell me exactly which projects are negatively impacted by > >>> disallowing > 15 byte instructions. > >> > >> I already told you: I'm using such in testing of my personal disassemb= ler > >> library. > > > > So, it is only you. You can either use .insn or add a switch to turn > > this error to warning. > > I has been a warning until 2.42, which you've regressed for my use case. > This is why I expect you to at least soften the regression, in allowing > people like me to simply add a command line option to the gas invocations= . So this is for your personal use case. If you asked nicely, I might have considered spending my time on this. > Plus, as you have learnt from Michael's responses, I'm not the only one > to think that this diagnostic ought to continue to be a warning by > default. > I can also tell you that there are other binutils developers who want to treat this as an error. Should I ask them for their opinions? --=20 H.J.