From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hjl.tools@gmail.com>
Received: from mail-oo1-xc2b.google.com (mail-oo1-xc2b.google.com
 [IPv6:2607:f8b0:4864:20::c2b])
 by sourceware.org (Postfix) with ESMTPS id D92023858023
 for <binutils@sourceware.org>; Mon, 18 Jan 2021 04:04:33 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D92023858023
Received: by mail-oo1-xc2b.google.com with SMTP id v19so3804623ooj.7
 for <binutils@sourceware.org>; Sun, 17 Jan 2021 20:04:33 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=XU80nJ0J7zYO0L7RcNOJApKvlPJQaZUIZQLQQ93G4Y4=;
 b=GS7iJChfdUC3wlQOQMSBI09lUoeRhoSg5pPh4TsM6B8CSSc16c5nZynVAoS1NOySCn
 xnEO7R4XjtP+m8U1R8bAo+XdeY2667/CxJJKjHq2m4nTmwrhksA7oaF7g0xv5kjcUjn6
 zOD+138NuuhjFu4vyb4uxalg2XVTAUz+IZCMjxdlqeALYSj1ikYzoIMm0WP4mhW3oVSj
 hIv/i9WGCaxBwkox7i/iRJHYz+UcFxGyJD26K+o6VGtZnxkMGeQYDTChL2MaLah9Tp1p
 mLEpL4wrU7L6JaU4HN/SUa43oaTaiBWFmeqPfZfrOBG1T9jNcKAHHhjq3wEJEVdvpOP7
 iBgA==
X-Gm-Message-State: AOAM533HpNXQYmtRxqPrA8BESqfx/Sf9h2arxKw9a0HaZxnfmV84Frr9
 M90XaD8UX9MO/P1ObGOjZmzhVeL2m9z4oPfp0FA=
X-Google-Smtp-Source: ABdhPJzbr5gaFR092EGi6CfIk8FX5FMsWspHXCiCMDYa+EC8Vv34TT0EyuKkZfDId+6C11/o8YUr5Hbx5+6zm9gPb3w=
X-Received: by 2002:a4a:1e42:: with SMTP id 63mr15988736ooq.57.1610942673300; 
 Sun, 17 Jan 2021 20:04:33 -0800 (PST)
MIME-Version: 1.0
References: <20210116235124.1870265-1-hjl.tools@gmail.com>
 <20210118035351.GT26219@bubble.grove.modra.org>
In-Reply-To: <20210118035351.GT26219@bubble.grove.modra.org>
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Sun, 17 Jan 2021 20:03:56 -0800
Message-ID: <CAMe9rOrsjJxZZVPxX9iZq2PvV_2WgiyR=6qX4zupfETF8+4OHQ@mail.gmail.com>
Subject: Re: [PATCH] ld/elf: Ignore section symbols when matching linkonce
 with comdat
To: Alan Modra <amodra@gmail.com>
Cc: Binutils <binutils@sourceware.org>, Nick Clifton <nickc@redhat.com>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-3031.1 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: binutils@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Binutils mailing list <binutils.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/binutils>,
 <mailto:binutils-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/binutils>,
 <mailto:binutils-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Jan 2021 04:04:35 -0000

On Sun, Jan 17, 2021 at 7:53 PM Alan Modra <amodra@gmail.com> wrote:
>
> On Sat, Jan 16, 2021 at 03:51:24PM -0800, H.J. Lu wrote:
> > bfd/
> >
> >       PR ld/27193
> >       * elflink.c (elf_create_symbuf): Also ignore section symbols.
> >
> > ld/
> >
> >       PR ld/27193
> >       * testsuite/ld-i386/i386.exp: Run PR ld/27193 test.
> >       * testsuite/ld-i386/pr27193.dd: New file.
> >       * testsuite/ld-i386/pr27193a.o.bz2: Likewise.
> >       * testsuite/ld-i386/pr27193b.s: Likewise.
>
> OK.  I do think it would have been better to wait until 2.35 branched
> before "ELF: Don't generate unused section symbols" was committed.
>

True.  Timing isn't great.  Here is another patch for master and 2.36 branch:

https://sourceware.org/pipermail/binutils/2021-January/114980.html

-- 
H.J.