From: "H.J. Lu" <hjl.tools@gmail.com>
To: Nick Clifton <nickc@redhat.com>
Cc: Binutils <binutils@sourceware.org>, Alan Modra <amodra@gmail.com>
Subject: Re: [PATCH] bfin: Don't call bfd_elf_link_record_dynamic_symbol
Date: Sat, 9 Jan 2021 06:22:23 -0800 [thread overview]
Message-ID: <CAMe9rOruci-QJ2o5WJkVQtb3ncTrRNAHnHciR_yWSpSR-Hj+yw@mail.gmail.com> (raw)
In-Reply-To: <9f9b9a5f-1f72-1156-fdf9-51676c0225f4@redhat.com>
On Fri, Jan 8, 2021 at 3:27 AM Nick Clifton <nickc@redhat.com> wrote:
>
> Hi H.J.
>
> >> FAIL: ld-elf/pr26979a
> >> FAIL: ld-elf/pr26979b
> >> FAIL: Symbol export class test (final shared object)
> >>
> >> * elf32-bfin.c (bfinfdpic_check_relocs): Don't call
> >> bfd_elf_link_record_dynamic_symbol.
>
> I am no bfin expert, but the patch looks simple enough to me,
> and since no one else has objected, please considered it approved.
>
The patch is incorrect. I checked in a different one:
commit d4e57b87a3d5879917c30e33b14760fd76ff7b38
Author: H.J. Lu <hjl.tools@gmail.com>
Date: Tue Dec 29 10:41:51 2020 -0800
bfin: Check bfd_link_hash_indirect
Add bfd_link_hash_indirect check to check_relocs. This fixed:
FAIL: ld-elf/pr26979a
FAIL: ld-elf/pr26979b
FAIL: Symbol export class test (final shared object)
* elf32-bfin.c (bfin_check_relocs): Check bfd_link_hash_indirect.
(bfinfdpic_check_relocs): Likewise.
--
H.J.
next prev parent reply other threads:[~2021-01-09 14:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-29 18:45 H.J. Lu
2021-01-06 0:15 ` H.J. Lu
2021-01-06 5:44 ` Alan Modra
2021-01-08 11:27 ` Nick Clifton
2021-01-09 14:22 ` H.J. Lu [this message]
2021-01-06 10:04 ` Mike Frysinger
2021-01-06 12:16 ` H.J. Lu
2021-01-06 13:24 ` [PATCH] bfin: Check bfd_link_hash_indirect H.J. Lu
2021-01-06 23:21 ` Mike Frysinger
2021-01-12 6:49 ` Mike Frysinger
2021-01-06 23:36 ` Alan Modra
2021-01-06 23:57 ` Mike Frysinger
2021-01-07 0:37 ` H.J. Lu
2021-01-07 0:55 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOruci-QJ2o5WJkVQtb3ncTrRNAHnHciR_yWSpSR-Hj+yw@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).