From: "H.J. Lu" <hjl.tools@gmail.com>
To: binutils@sourceware.org
Subject: Re: [PATCH] ld: Xfail PR ld/31289 tests for some targets
Date: Thu, 25 Jan 2024 10:09:53 -0800 [thread overview]
Message-ID: <CAMe9rOrxd+8pgB2PiGq8ygdqiZWoQCX6XsFgstKuZDW2a5J35Q@mail.gmail.com> (raw)
In-Reply-To: <20240125161127.893781-1-hjl.tools@gmail.com>
On Thu, Jan 25, 2024 at 8:11 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> Xfail PR ld/31289 tests for targets which don't use standard ELF
> emulation since the -z option is unrecognized.
>
> PR ld/31289
> * testsuite/ld-elf/fatal-warnings-2a.d: Xfail targets which
> don't use standard ELF emulation.
> * testsuite/ld-elf/fatal-warnings-2b.d: Likewise.
> * testsuite/ld-elf/fatal-warnings-3a.d: Likewise.
> * testsuite/ld-elf/fatal-warnings-3b.d: Likewise.
> * testsuite/ld-elf/fatal-warnings-4a.d: Likewise.
> * testsuite/ld-elf/fatal-warnings-4b.d: Likewise.
> ---
> ld/testsuite/ld-elf/fatal-warnings-2a.d | 3 ++-
> ld/testsuite/ld-elf/fatal-warnings-2b.d | 3 ++-
> ld/testsuite/ld-elf/fatal-warnings-3a.d | 3 ++-
> ld/testsuite/ld-elf/fatal-warnings-3b.d | 3 ++-
> ld/testsuite/ld-elf/fatal-warnings-4a.d | 3 ++-
> ld/testsuite/ld-elf/fatal-warnings-4b.d | 3 ++-
> 6 files changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/ld/testsuite/ld-elf/fatal-warnings-2a.d b/ld/testsuite/ld-elf/fatal-warnings-2a.d
> index 5c46f4300c6..ac01943fd34 100644
> --- a/ld/testsuite/ld-elf/fatal-warnings-2a.d
> +++ b/ld/testsuite/ld-elf/fatal-warnings-2a.d
> @@ -3,4 +3,5 @@
> #ld: -z bad-option1 -z bad-option2
> #warning: -z bad-option1 ignored
> #xfail: [is_generic]
> -# generic linker targets don't support -z options.
> +#xfail: fr30-*-* frv-*-elf ft32-*-* iq2000-*-* ms1-*-* msp*-*
> +# They don't support -z options.
> diff --git a/ld/testsuite/ld-elf/fatal-warnings-2b.d b/ld/testsuite/ld-elf/fatal-warnings-2b.d
> index 5fa94e467af..a15a89a92f2 100644
> --- a/ld/testsuite/ld-elf/fatal-warnings-2b.d
> +++ b/ld/testsuite/ld-elf/fatal-warnings-2b.d
> @@ -3,4 +3,5 @@
> #ld: -z bad-option1 -z bad-option2
> #warning: -z bad-option2 ignored
> #xfail: [is_generic]
> -# generic linker targets don't support -z options.
> +#xfail: fr30-*-* frv-*-elf ft32-*-* iq2000-*-* ms1-*-* msp*-*
> +# They don't support -z options.
> diff --git a/ld/testsuite/ld-elf/fatal-warnings-3a.d b/ld/testsuite/ld-elf/fatal-warnings-3a.d
> index a377b738b1d..c2817b2678c 100644
> --- a/ld/testsuite/ld-elf/fatal-warnings-3a.d
> +++ b/ld/testsuite/ld-elf/fatal-warnings-3a.d
> @@ -3,4 +3,5 @@
> #ld: --fatal-warnings -z bad-option1 -z bad-option2
> #error: unsupported option: -z bad-option1
> #xfail: [is_generic]
> -# generic linker targets don't support -z options.
> +#xfail: fr30-*-* frv-*-elf ft32-*-* iq2000-*-* ms1-*-* msp*-*
> +# They don't support -z options.
> diff --git a/ld/testsuite/ld-elf/fatal-warnings-3b.d b/ld/testsuite/ld-elf/fatal-warnings-3b.d
> index 87ea286d748..c3be0ab8906 100644
> --- a/ld/testsuite/ld-elf/fatal-warnings-3b.d
> +++ b/ld/testsuite/ld-elf/fatal-warnings-3b.d
> @@ -3,4 +3,5 @@
> #ld: --fatal-warnings -z bad-option1 -z bad-option2
> #error: unsupported option: -z bad-option2
> #xfail: [is_generic]
> -# generic linker targets don't support -z options.
> +#xfail: fr30-*-* frv-*-elf ft32-*-* iq2000-*-* ms1-*-* msp*-*
> +# They don't support -z options.
> diff --git a/ld/testsuite/ld-elf/fatal-warnings-4a.d b/ld/testsuite/ld-elf/fatal-warnings-4a.d
> index 4685e3877d6..a635b53c157 100644
> --- a/ld/testsuite/ld-elf/fatal-warnings-4a.d
> +++ b/ld/testsuite/ld-elf/fatal-warnings-4a.d
> @@ -3,4 +3,5 @@
> #ld: -z bad-option1 -z bad-option2 --fatal-warnings
> #error: unsupported option: -z bad-option1
> #xfail: [is_generic]
> -# generic linker targets don't support -z options.
> +#xfail: fr30-*-* frv-*-elf ft32-*-* iq2000-*-* ms1-*-* msp*-*
> +# They don't support -z options.
> diff --git a/ld/testsuite/ld-elf/fatal-warnings-4b.d b/ld/testsuite/ld-elf/fatal-warnings-4b.d
> index 6fc2185f126..512a518dd64 100644
> --- a/ld/testsuite/ld-elf/fatal-warnings-4b.d
> +++ b/ld/testsuite/ld-elf/fatal-warnings-4b.d
> @@ -3,4 +3,5 @@
> #ld: -z bad-option1 -z bad-option2 --fatal-warnings
> #error: unsupported option: -z bad-option2
> #xfail: [is_generic]
> -# generic linker targets don't support -z options.
> +#xfail: fr30-*-* frv-*-elf ft32-*-* iq2000-*-* ms1-*-* msp*-*
> +# They don't support -z options.
> --
> 2.43.0
>
This patch is superseded by
https://sourceware.org/pipermail/binutils/2024-January/132134.html
which I will check it in shortly.
--
H.J.
prev parent reply other threads:[~2024-01-25 18:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-25 16:11 H.J. Lu
2024-01-25 18:09 ` H.J. Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOrxd+8pgB2PiGq8ygdqiZWoQCX6XsFgstKuZDW2a5J35Q@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).