From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hjl.tools@gmail.com>
Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com
 [IPv6:2607:f8b0:4864:20::629])
 by sourceware.org (Postfix) with ESMTPS id 822F83858D39
 for <binutils@sourceware.org>; Thu, 30 Jun 2022 22:55:16 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 822F83858D39
Received: by mail-pl1-x629.google.com with SMTP id l6so662624plg.11
 for <binutils@sourceware.org>; Thu, 30 Jun 2022 15:55:16 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=Q71IN+L0DB0BkeJ++5c5fpwLdtq6W/conp0cHKm8DBQ=;
 b=cBnFYmXN+32kskGcGgqK0MY1nkEhg9Lkf1AdktLovmJYotoMUzVzA6qSXKm5ckabRZ
 m/c0IxbSTXSDaCmvO8Lp8wNqj0AeOxSDLFJiHdaX/K/jZ9Nf2MCGCGaq4KN4/W23+UP+
 cT7rw2+M0qqhE5K1URYJ236mNVlVj7KhDgGYBzNP6WsKlU5U/Gx2tTl8BpDhyxMB7ZP3
 dn1bcHfAha0VypUUuoi/wy6sjvboPHlBtPkMKQ5KSiHY64+EGWsvS7loeX3G0yI77IZY
 guwaaXTtUG7r975Cyjhu9saOHI/S2l4QbJgB7A+gpSrapGH3+rt/cilNXJV38H1WSJ5M
 XS4w==
X-Gm-Message-State: AJIora+hRI0lcdIAArU7LmZoQvmqztSxcjn3FCA07OkZ5id0mwJ03T3V
 Sj6f1Mh5g5qEIOUveOCafSPPnbqWHpLgDyIhCTcx+Ggq
X-Google-Smtp-Source: AGRyM1us5WvTZcWkeUrYEHulnVeZSWK+TqPZLQPU0Y7RK89vZwAKRDzJ/nltcLYNw2BAe6gK0GMUeum69XqUIeOhvRI=
X-Received: by 2002:a17:90a:e413:b0:1ec:8952:cc5d with SMTP id
 hv19-20020a17090ae41300b001ec8952cc5dmr14385785pjb.101.1656629715523; Thu, 30
 Jun 2022 15:55:15 -0700 (PDT)
MIME-Version: 1.0
References: <01f502ff-5b51-86d3-ed54-646df7d22037@suse.com>
 <a22edd84-5655-e1dc-5cb3-f1c6b8f9d901@suse.com>
In-Reply-To: <a22edd84-5655-e1dc-5cb3-f1c6b8f9d901@suse.com>
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Thu, 30 Jun 2022 15:54:39 -0700
Message-ID: <CAMe9rOryv0ZLM_r8dgX=+zqAiwj7Xge8xn8bDLPRne6w01zrWQ@mail.gmail.com>
Subject: Re: [PATCH 1/7] x86: don't leak sub-architecture accumulated strings
To: Jan Beulich <jbeulich@suse.com>
Cc: Binutils <binutils@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-3019.3 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: binutils@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Binutils mailing list <binutils.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/binutils>,
 <mailto:binutils-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/binutils>,
 <mailto:binutils-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Jun 2022 22:55:18 -0000

On Thu, Jun 30, 2022 at 5:53 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> While it may not be necessary in i386_target_format() (but then setting
> the variable to NULL also wouldn't be necessary), at least in the other
> cases strings may already have accumulated.
>
> --- a/gas/config/tc-i386.c
> +++ b/gas/config/tc-i386.c
> @@ -2871,6 +2871,7 @@ set_cpu_arch (int dummy ATTRIBUTE_UNUSED
>                   check_cpu_arch_compatible (string, cpu_arch[j].flags);
>
>                   cpu_arch_name = cpu_arch[j].name;
> +                 xfree (cpu_sub_arch_name);
>                   cpu_sub_arch_name = NULL;
>                   cpu_arch_flags = cpu_arch[j].flags;
>                   if (flag_code == CODE_64BIT)
> @@ -13406,6 +13407,7 @@ md_parse_option (int c, const char *arg)
>                     continue;
>
>                   cpu_arch_name = cpu_arch[j].name;
> +                 xfree (cpu_sub_arch_name);
>                   cpu_sub_arch_name = NULL;
>                   cpu_arch_flags = cpu_arch[j].flags;
>                   cpu_arch_isa = cpu_arch[j].type;
> @@ -14086,6 +14088,7 @@ i386_target_format (void)
>         {
>           static const i386_cpu_flags iamcu_flags = CPU_IAMCU_FLAGS;
>           cpu_arch_name = "iamcu";
> +         xfree (cpu_sub_arch_name);
>           cpu_sub_arch_name = NULL;
>           cpu_arch_flags = iamcu_flags;
>           cpu_arch_isa = PROCESSOR_IAMCU;
>

Can we just use free?

-- 
H.J.