From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [IPv6:2607:f8b0:4864:20::b2d]) by sourceware.org (Postfix) with ESMTPS id 6056A3858003 for ; Tue, 25 Oct 2022 19:13:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6056A3858003 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yb1-xb2d.google.com with SMTP id i127so15881732ybc.11 for ; Tue, 25 Oct 2022 12:13:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=cHWiC9GDQJ4j2TY0I8Dbs43HHtBBZxGIGQnl5Hi/9xg=; b=gpKMj/6KXbke1MfVkLD6onsMVNoRUVaX41YWclc1eLu1GanZaed+8kf0V032ws+Th9 WbkbvWNl51vuoWUg9fwzsbHfYlsmJvCtjrAmrNQP6t6SPp0idrGPXj5t00piHU7L/OUx L1sLnIqIaV5//CKxZXLeC9vZ4hfIWLd6e0s2X3XYyJwKpMl3LoCST816Wr1Lv5Oy8D0R I5XNtS9QdZhBEY9oOON8cH54HiACDXRsOEpvO7sExE0cG0BoZB8Rm8WVdd1fnahPBaHb bppEIleXzqb4YZxeyTNYT4L3wMZDxvJb8PRrxGvN3TmeEBYShXWFUkupcwHfwfzbyhik rRbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cHWiC9GDQJ4j2TY0I8Dbs43HHtBBZxGIGQnl5Hi/9xg=; b=m/c3uJpN05XhAOV/j0AJdw910Y2o7RbwRWoRcx0rnohQCihzCF3bAqRPj0p2u1N5lr g7Vkja5sHVx43r1Pi+4UMvbpEsbAytueIfCTE6NIx/UIuRzkFHgjDHBhOXPUYMSxeY8R lpltnKQD7IqjtrvZsgJxs0W03ka8CaOCDKn2K5nftRgfAljZ8CXXN5i3m8kiPpOe6bz6 oiX1qKy9MY0iWxScPAd4RBxAOhXFf2End+WoMZfBzmxQNrqDwaQlmOhtpxfBZJm3bjtW DeWUe6cLkw8aFLtErb92aIMCMJFJt9t1FGdrFNJrvjsAX0UHkVkzmNHswT7+sbnnvLmG 9P1g== X-Gm-Message-State: ACrzQf2IsgpT7xKggYfKG2N6sjzSAvy8dJdhjNQgzOR1cMcyg54NLbFt x+d6KBylo9RCrDOEzkmqRBKOk2oQiTa4lNYs/oQCIy+F X-Google-Smtp-Source: AMsMyM7VTKmege6z9mLTmPS367kK85MdIt1DD+sg1PWgno0eVasqOirrXDTdbBbglxYaCawdrk3AwkHSN3tjMiVYeHc= X-Received: by 2002:a25:cf4e:0:b0:6bf:d596:5e48 with SMTP id f75-20020a25cf4e000000b006bfd5965e48mr36468852ybg.497.1666725228780; Tue, 25 Oct 2022 12:13:48 -0700 (PDT) MIME-Version: 1.0 References: <94fd668465b77e94f3c000982c694e7da8f828f1.camel@espressif.com> In-Reply-To: <94fd668465b77e94f3c000982c694e7da8f828f1.camel@espressif.com> From: Max Filippov Date: Tue, 25 Oct 2022 12:13:37 -0700 Message-ID: Subject: Re: [PATCH 0/5] Add Xtensa ESP chips support To: Alexey Lapshin Cc: "binutils@sourceware.org" , Anton Maklakov , Alexey Gerenkov , Ivan Grokhotkov Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,FROM_LOCAL_NOVOWEL,HK_RANDOM_ENVFROM,HK_RANDOM_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Alexey, On Sat, Oct 22, 2022 at 5:51 AM Alexey Lapshin via Binutils wrote: > > Since ESP chips are getting more and more popular for developers I > would like to suggest these patches to consider to include Xtensa ESP > chips support for binutils and gdb. > > The chips support was done in a not common binutils way. There are a > few reasons for that: > As I know, the Xtensa specific code for binutils and gdb is generated > with tools from Tensilica Inc. > To build binutils and gdb with other chip presets we need to override > some related files (https://github.com/espressif/xtensa-overlays). > To make it easy to integrate new chips I did refactor the code a bit to > make a possibility to just copy and paste Tensilica-generated files and > modify a few lines in a code to make it supported in binutils and gdb. > > Please consider these changes to merge, I believe this could be a > pretty improvement to extend supported CPUs without using third-party > sources patches. > > Alexey Lapshin (5): > bfd: xtensa: move common code from ld and gas > gas: xtensa: add endianness, loops, booleans options > ld: xtensa: use default LD command line options to specify endianness > gas: xtensa: add esp32, esp32s2, esp32s3 isa-modules options > gdb: xtensa: add support for esp32, esp32s2, esp32s3 isa-modules I'd like to review this series but it has two technical issues: - the patches are not in plain text format and so git am is unable to apply them - the 4th patch of the series didn't make it through the list, I guess it's too big I guess the easiest way for me to review this series is if you could point me to a public git repository with these patches. Alternatively you could use git send-email to send the patches, split patch 4 into pieces (e.g. one core per patch) and add me to the cc: list. -- Thanks. -- Max