* [PATCH] bfd: xtensa: fix PR ld/25630
@ 2020-03-05 4:53 Max Filippov
2020-03-05 17:36 ` augustine.sterling
0 siblings, 1 reply; 3+ messages in thread
From: Max Filippov @ 2020-03-05 4:53 UTC (permalink / raw)
To: binutils; +Cc: Sterling Augustine, Eric Tsai, linux-xtensa, Max Filippov
bfd/
2020-03-05 Max Filippov <jcmvbkbc@gmail.com>
* elf32-xtensa.c (shrink_dynamic_reloc_sections): Shrink dynamic
relocation sections for any removed reference to a dynamic symbol.
---
bfd/elf32-xtensa.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/bfd/elf32-xtensa.c b/bfd/elf32-xtensa.c
index 12ff9f772aaf..65e14d87940c 100644
--- a/bfd/elf32-xtensa.c
+++ b/bfd/elf32-xtensa.c
@@ -10148,10 +10148,9 @@ shrink_dynamic_reloc_sections (struct bfd_link_info *info,
if ((r_type == R_XTENSA_32 || r_type == R_XTENSA_PLT)
&& (input_section->flags & SEC_ALLOC) != 0
- && (dynamic_symbol || bfd_link_pic (info))
- && (!h || h->root.type != bfd_link_hash_undefweak
- || (dynamic_symbol
- && (bfd_link_dll (info) || info->export_dynamic))))
+ && (dynamic_symbol
+ || (bfd_link_pic (info)
+ && (!h || h->root.type != bfd_link_hash_undefweak))))
{
asection *srel;
bfd_boolean is_plt = FALSE;
--
2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] bfd: xtensa: fix PR ld/25630
2020-03-05 4:53 [PATCH] bfd: xtensa: fix PR ld/25630 Max Filippov
@ 2020-03-05 17:36 ` augustine.sterling
2020-03-06 3:52 ` Max Filippov
0 siblings, 1 reply; 3+ messages in thread
From: augustine.sterling @ 2020-03-05 17:36 UTC (permalink / raw)
To: Max Filippov; +Cc: Binutils, Eric Tsai, linux-xtensa
On Wed, Mar 4, 2020 at 8:53 PM Max Filippov <jcmvbkbc@gmail.com> wrote:
>
> bfd/
> 2020-03-05 Max Filippov <jcmvbkbc@gmail.com>
>
> * elf32-xtensa.c (shrink_dynamic_reloc_sections): Shrink dynamic
> relocation sections for any removed reference to a dynamic symbol.
Looks good. Thanks for the fix.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bfd: xtensa: fix PR ld/25630
2020-03-05 17:36 ` augustine.sterling
@ 2020-03-06 3:52 ` Max Filippov
0 siblings, 0 replies; 3+ messages in thread
From: Max Filippov @ 2020-03-06 3:52 UTC (permalink / raw)
To: augustine.sterling
Cc: Binutils, Eric Tsai, open list:TENSILICA XTENSA PORT (xtensa)
On Thu, Mar 5, 2020 at 9:36 AM augustine.sterling@gmail.com
<augustine.sterling@gmail.com> wrote:
>
> On Wed, Mar 4, 2020 at 8:53 PM Max Filippov <jcmvbkbc@gmail.com> wrote:
> >
> > bfd/
> > 2020-03-05 Max Filippov <jcmvbkbc@gmail.com>
> >
> > * elf32-xtensa.c (shrink_dynamic_reloc_sections): Shrink dynamic
> > relocation sections for any removed reference to a dynamic symbol.
>
> Looks good. Thanks for the fix.
Thanks. Applied to master.
-- Max
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-06 3:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-05 4:53 [PATCH] bfd: xtensa: fix PR ld/25630 Max Filippov
2020-03-05 17:36 ` augustine.sterling
2020-03-06 3:52 ` Max Filippov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).