From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30278 invoked by alias); 20 Mar 2014 12:07:11 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 30267 invoked by uid 89); 20 Mar 2014 12:07:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,FROM_LOCAL_NOVOWEL,HK_RANDOM_ENVFROM,HK_RANDOM_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 X-HELO: mail-oa0-f48.google.com Received: from mail-oa0-f48.google.com (HELO mail-oa0-f48.google.com) (209.85.219.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 20 Mar 2014 12:07:10 +0000 Received: by mail-oa0-f48.google.com with SMTP id m1so764995oag.7 for ; Thu, 20 Mar 2014 05:07:08 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.60.115.129 with SMTP id jo1mr37683905oeb.0.1395317228349; Thu, 20 Mar 2014 05:07:08 -0700 (PDT) Received: by 10.76.12.135 with HTTP; Thu, 20 Mar 2014 05:07:08 -0700 (PDT) In-Reply-To: <1394741157-5359-1-git-send-email-jcmvbkbc@gmail.com> References: <1394741157-5359-1-git-send-email-jcmvbkbc@gmail.com> Date: Thu, 20 Mar 2014 12:07:00 -0000 Message-ID: Subject: Re: [PATCH v2] Add "--trampolines" option to allow assembler to relax out-of-range jumps From: Max Filippov To: binutils@sourceware.org Cc: Sterling Augustine , David Weatherford , Marc Gauthier , Max Filippov Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-03/txt/msg00220.txt.bz2 Hi Sterling, On Fri, Mar 14, 2014 at 12:05 AM, Max Filippov wrote: > 2014-02-28 David Weatherford > Max Filippov > > gas/config/ > * tc-xtensa.c (xtensa_check_frag_count, xtensa_create_trampoline_frag) > (xtensa_maybe_create_trampoline_frag, init_trampoline_frag) > (find_trampoline_seg, search_trampolines, get_best_trampoline) > (check_and_update_trampolines, add_jump_to_trampoline) > (dump_trampolines): New function. > (md_parse_option): Add cases for --[no-]trampolines options. > (md_assemble, finish_vinsn, xtensa_end): Add call to > xtensa_check_frag_count. > (xg_assemble_vliw_tokens): Add call to > xtensa_maybe_create_trampoline_frag. > (xtensa_relax_frag): Relax fragments with RELAX_TRAMPOLINE state. > (relax_frag_immed): Relax jump instructions that cannot reach its > target. > * tc-xtensa.h (xtensa_relax_statesE::RELAX_TRAMPOLINE): New relax > state. > > gas/doc/ > * as.texinfo: Document --[no-]trampolines command-line options. > * c-xtensa.texi: Document trampolines relaxation and command line > options. > > gas/ > * frags.c (get_frag_count, clear_frag_count): New function. > (frag_alloc): Increment totalfrags counter. > * frags.h (get_frag_count, clear_frag_count): New function. > > gas/testsuite/gas/xtensa/ > * all.exp: Add test for trampoline relaxation. > * trampoline.d: Trampoline relaxation expected dump. > * trampoline.s: Trampoline relaxation test source. > --- > Changes v1 -> v2: > - spell out all abbreviations of 'trampoline'; > - fix structure definition style for struct trampoline_frag, trampoline_seg; > - add blank line in blocks after local variable declarations; > - combine changelog entries with similar changes. Is there anything else that needs to be done for this patch to be committed? -- Thanks. -- Max