From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-105300-listarch-binutils=sources.redhat.com@sourceware.org>
Received: (qmail 99018 invoked by alias); 11 Apr 2019 18:46:04 -0000
Mailing-List: contact binutils-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <binutils.sourceware.org>
List-Subscribe: <mailto:binutils-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: binutils-owner@sourceware.org
Received: (qmail 99008 invoked by uid 89); 11 Apr 2019 18:46:04 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=0.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,FREEMAIL_REPLY,FROM_LOCAL_NOVOWEL,HK_RANDOM_ENVFROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.1 spammy=H*f:sk:CAGSvup, jcmvbkbcgmailcom, jcmvbkbc@gmail.com, U*augustine.sterling
X-HELO: mail-yb1-f196.google.com
Received: from mail-yb1-f196.google.com (HELO mail-yb1-f196.google.com) (209.85.219.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 11 Apr 2019 18:46:03 +0000
Received: by mail-yb1-f196.google.com with SMTP id m5so793917ybk.13        for <binutils@sourceware.org>; Thu, 11 Apr 2019 11:46:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=gmail.com; s=20161025;        h=mime-version:references:in-reply-to:from:date:message-id:subject:to         :cc;        bh=KHk4CfnxZ0lQa5aFDVm+O5aOx0mfgKwhCnIojJ1oXgk=;        b=RkbLJvIn3jxwncYNQZRlVKTW4T2l1L2OjR0vUGqXdV1GX2oQB9wDZ4X9CsnhGb5cYn         Myy8uVBZ4hctAIHh8Lb+OO4xJqkNkrRtRltoEdzI1HYVPtxcPouizw8hPlrL7W6hy7Za         83FwLLEFVlXfpUkXgF9dO+bXz3ND4NUg2aCOVEL/vvqFPXg/QI/HFgRrLwTJv1Frig6A         iCLpbZw3q8sof5gw129Jw75bZ4UhcLuF9+5DjpZNkpObDVa0gA+zKcRNk4V2fiZkz/o8         o7iYyb0J6GJsYh1c3K3MdbOxdHjyn7ufpCKpzB0U9vPluHkbGAUMxl81QMtiqu7LDbCg         wU+g==
MIME-Version: 1.0
References: <20190410203402.18285-1-jcmvbkbc@gmail.com> <CAGSvup-1PmPk69vq-we_HHXNTUyuXWncx=d7ha9661EAtAM6WQ@mail.gmail.com>
In-Reply-To: <CAGSvup-1PmPk69vq-we_HHXNTUyuXWncx=d7ha9661EAtAM6WQ@mail.gmail.com>
From: Max Filippov <jcmvbkbc@gmail.com>
Date: Thu, 11 Apr 2019 18:46:00 -0000
Message-ID: <CAMo8BfLB-5OVUzGqnwijXz3Vr5qCkTp_ODnvNj=pELrAstbpiw@mail.gmail.com>
Subject: Re: [PATCH] xtensa: gas: clean up literal management code
To: "augustine.sterling@gmail.com" <augustine.sterling@gmail.com>
Cc: binutils@sourceware.org, Eric Tsai <erictsai@cadence.com>, 	linux-xtensa@linux-xtensa.org
Content-Type: text/plain; charset="UTF-8"
X-IsSubscribed: yes
X-SW-Source: 2019-04/txt/msg00138.txt.bz2

On Wed, Apr 10, 2019 at 5:09 PM augustine.sterling@gmail.com
<augustine.sterling@gmail.com> wrote:
>
> On Wed, Apr 10, 2019 at 1:34 PM Max Filippov <jcmvbkbc@gmail.com> wrote:
> >
> > gas/
> > 2019-04-10  Max Filippov  <jcmvbkbc@gmail.com>
> >
> >         * config/tc-xtensa.c (xtensa_literal_pseudo): Drop code that has
> >         no effect.
> >         (get_literal_pool_location): Only search for the literal pool
> >         when auto litpools is used, otherwise take one recorded in the
> >         tc_segment_info_data.
> >         (xtensa_assign_litpool_addresses): New function.
> >         (xtensa_move_literals): Don't duplicate 'literal pool location
> >         required...' error message. Call xtensa_assign_litpool_addresses.
>
> Thanks. Looks good.

Thanks. Applied to master.

-- Max