From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by sourceware.org (Postfix) with ESMTPS id 2C2063857B8C for ; Fri, 17 Jun 2022 05:11:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2C2063857B8C Received: by mail-ej1-x630.google.com with SMTP id y19so6609704ejq.6 for ; Thu, 16 Jun 2022 22:11:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=gdxxNobxtnP65jszcl7ZX1DIlAZ7DPTU848wtx34VJE=; b=4mvzL1Q364fd+XXkFB0KSZHc7RLE144FKqzR3DVzH32OhQnIzbrUO03/5B9Lj8IAV2 4AW5iDXg/oUpMfyUA7Frfk/+9bNgXF5yO2kpR3122lY/6rzC4FtR4qg3cqJG7eeXQ9FD j9acA5f1kiPCDrInSHeQHjtEmOiLDiqZjlK0ydIpTthUC+xkCs0AWRGCZ+bflRJwOEsp NEOJMTuqE8g3O+K9mRy7Jl1B7em+sFl5O5j0LD4bu22yw7OaarL2/R7oGYvw4eA9qjRE ItMXNw59cV5dUVfOqYPqKviSBlm0K1rOrgHEkl/oByfUFUyy3UGhIG1gS+WUSONVrFRt 06OQ== X-Gm-Message-State: AJIora+OO3dcDU5Og17YRHvP+ujFvL2fYvOvl+wH2OiSsRS/3Iik1791 X9ltGZjujYOw13MGMbPVBB8QkC/d4UO+2sweEF1EIVuLnYc= X-Google-Smtp-Source: AGRyM1uzYXCmO9hWhuMEoTHc0GxDU/Qc+DJYQRNhncGFoxJGfpbmZE2Wbmyg5ryz32HBCD0zNh2jyV8cnw84x/1C/+E= X-Received: by 2002:a17:906:685:b0:6fa:8e17:e9b5 with SMTP id u5-20020a170906068500b006fa8e17e9b5mr7891307ejb.522.1655442708565; Thu, 16 Jun 2022 22:11:48 -0700 (PDT) MIME-Version: 1.0 From: Dmitry Selyutin Date: Fri, 17 Jun 2022 08:11:12 +0300 Message-ID: Subject: Are big tests allowed in binutils? To: binutils@sourceware.org Cc: Alan Modra , Luke Leighton Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jun 2022 05:11:51 -0000 Hi folks, I'm going to submit a series of patches which add a couple of new instructions available as SVP64 extensions (under -mlibresoc switch). Since I want to be a good citizen, I also want to introduce tests for each instruction, basically comparing the expected results for dumps (aka run_dump_test). However, I'd like to cover various possible cases, so I generated a test to cover many different operands; this makes tests quite big. For example, the assembly listing for a new svremap instruction takes 10240 lines, and etalon dump takes a bit more lines. So, questions: 1. Is it OK at all to have tests that large? Time-wise they're fast, I'm mostly concerned about code base size and readers' patience. 2. Will you tolerate it if I post these tests in the mailing list? These will be a major headache for any reader if integrated into the patches. 3. If it's OK to post these tests into the mailing lists, is it allowed to post them as separate patches from the ones which add the instructions? My preferred option would be to split each patch into two parts: 1. The patch which adds the instruction itself. 2. The patch which adds the test for this instruction. However, looking at patches in PowerPC, I see that the tests generally come along with the implementation in scope of one patch. I'm afraid this might make patches barely readable. If needed, I can cut the size of tests; time-wise it's fast, 10420 lines of asm take 0,04s of real time, I'm only concerned about readability. I'd like to know your opinion on this. Thank you! -- Best regards, Dmitry Selyutin