From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ghostman.sd@gmail.com>
Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com
 [IPv6:2a00:1450:4864:20::52c])
 by sourceware.org (Postfix) with ESMTPS id DD479384F015;
 Thu, 12 May 2022 07:47:53 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DD479384F015
Received: by mail-ed1-x52c.google.com with SMTP id z19so5212677edx.9;
 Thu, 12 May 2022 00:47:53 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=U9rV3UxYrhlYz38rW0Bz3IPO160kmOWPZb4MKcmxyfw=;
 b=wnmMyShTrBM7Nrj1mB0MgVpO6ahHs0cAEHlBexUA+tu5Ate8twiuzi3GiuDatoBy9H
 G+4aA+HOpLC22OBGsMN0oFE4jZaAn3I/CZwCxNdGcFgoVwSvVD+x5zJt2UGlmX2mpUHR
 nTS49fQZRUTBfdymWq1fG3irjb1k+TBZ/2sfAJHkiaS6LUt0xVMh2pdH48I57dUCJxFv
 wNzzl0f2MCh5fKcUVCOtEhrWbbpea2MrgH/gcyzdTFep9kHm3MGAV6jss1tVdiCgp6Bs
 wPz4iTVjTS/oyYDi4zjcguCxLFda7kVHyxFRvyMet75oV17Fb840GB2pO9pnoMCb3QZx
 10Bw==
X-Gm-Message-State: AOAM533wq8D3/qcJM5Vv8/fr+2XdVYNXbLqVRCFmEhdpApqL0ymeNSs4
 qx9PuOitn+vWH36kjmMCUFhRxoIS5yC6Xj18b0qWbsFNTiZSww==
X-Google-Smtp-Source: ABdhPJxHDkcYjRmdid4r9wGDrtK5jLpryvSv+bfsrq3pwyDO8yZb/iZRUNhAPLDynvHgw3Dq3+3G+uLRVSzta/FMcDI=
X-Received: by 2002:a05:6402:2363:b0:425:bc13:4c8b with SMTP id
 a3-20020a056402236300b00425bc134c8bmr33759476eda.140.1652341672642; Thu, 12
 May 2022 00:47:52 -0700 (PDT)
MIME-Version: 1.0
References: <CAMqzjeuzs51B_f8oRAVPym0zu8=Nr5xhbaH1BJCnVhjhqPF31w@mail.gmail.com>
 <87y1z8szsv.fsf@igel.home>
In-Reply-To: <87y1z8szsv.fsf@igel.home>
From: Dmitry Selyutin <ghostmansd@gmail.com>
Date: Thu, 12 May 2022 10:47:16 +0300
Message-ID: <CAMqzjetTgDVnJwzpxM7n5g3TYDkZDnm=WZ448uT5NTh1KMK0jQ@mail.gmail.com>
Subject: Re: [PATCH 2/2] gas/write: extend fx_pcrel_adjust to 16 bits
To: Andreas Schwab <schwab@linux-m68k.org>, binutils@sourceware.org
Cc: Luke Kenneth Casson Leighton <lkcl@lkcl.net>, gdb-patches@sourceware.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: binutils@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Binutils mailing list <binutils.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/binutils>,
 <mailto:binutils-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/binutils>,
 <mailto:binutils-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 12 May 2022 07:47:55 -0000

On Wed, May 11, 2022 at 9:13 PM Andreas Schwab <schwab@linux-m68k.org> wrote:
> It's probably better to swap the fx_size and fx_pcrel_adjust fields, so
> that fx_pcrel_adjust is aligned on a 16 bit boundary.

Thank you for your suggestion! After thinking about it for a while, I
suggest moving the fx_pcrel_adjust (16 bits) field to the top, then
putting fx_size (8 bits), then the rest.
Also, I'd replace `unsigned fx_unused : 2` with a simple `unsigned :
2`, I think this way we can make it even clearer that these bits are
spare. But perhaps this should go as a separate change.