From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by sourceware.org (Postfix) with ESMTPS id EAFCF3858D37 for ; Mon, 15 Aug 2022 13:08:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EAFCF3858D37 Received: by mail-ej1-x631.google.com with SMTP id fy5so13449837ejc.3 for ; Mon, 15 Aug 2022 06:08:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=5sp7U/Vaz8CcA/OhFfW7my6uT81At3YFF8q1oViFz0s=; b=TGJPpvbstyjj4cZw22LdtNRfO6ALJkCYi8uTkFK5KOrvxqzXMtT0s8OnW+m3aA/gIx If9NjakLyePwDohxhoCVgIw/sG1uCdlznEGYd/Crl4C1dLNYPJBvXjMYJZSZeziVYhth XtMeYX/xGzEN7SbPRhHU53W1U3f5+yBARrJqQQbapyd1UbNiy7coq6b1Af0nLFISz5sL CnRNm36YsyGAKLQOwmwZlTggpL6eZ2ZRDkbXB8rXpRuqumRePkarculMEJXxBUS8Z2Bq Z4ZzJW/cvM5E+92RjQ1feickLhPcYAdb77rWRE9X6kC2UYK6Q1+hpXA59LvLI3IK1cyX SDOA== X-Gm-Message-State: ACgBeo3CNoWWS8pQvUNhCrzaEcpjRay4dymrMsjBJXh9OUeLbCU2bt0Y ZHAxhv3DEaB77CdMyvdi/kqmqmFkTDP74UKvZ+cGtdzDtfg= X-Google-Smtp-Source: AA6agR6F1PM7oJXsTo6Jq50aGsBtlv195MDB6izxtufp+oq0xbdLIRV45TbO5GMhIsoQ90OI8avigj+rpMHIR93Mzeo= X-Received: by 2002:a17:907:970b:b0:732:f76a:97a2 with SMTP id jg11-20020a170907970b00b00732f76a97a2mr10595829ejc.396.1660568935387; Mon, 15 Aug 2022 06:08:55 -0700 (PDT) MIME-Version: 1.0 References: <20220626190005.7727-1-ghostmansd@gmail.com> <20220725131020.128550-1-ghostmansd@gmail.com> <20220725131020.128550-4-ghostmansd@gmail.com> In-Reply-To: From: Dmitry Selyutin Date: Mon, 15 Aug 2022 16:08:19 +0300 Message-ID: Subject: Re: [PATCH v6 3/7] ppc/svp64: support setvl instructions To: lkcl Cc: Jan Beulich , binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Aug 2022 13:08:58 -0000 On Mon, Aug 15, 2022 at 9:18 AM Jan Beulich wrote: > Out of curiosity - was it intentional to omit a case with the last > operand non-zero? Nice catch! This was not intentional, I'll submit the patch to handle this case. Perhaps I either forgot to add this line, or removed it somehow... On Mon, Aug 15, 2022 at 3:59 PM lkcl wrote: > one for Dmitry - i believe these are all auto-generated? Except for the very first revisions with huge tests, I added the tests manually. One of the issues for generation is that we don't, in fact, maintain information about whether some operands should be non-zero. Another issue was that, until very recently, we had to generate the instructions manually, not from the parsed fields. In fact, we still encode these instructions manually even now, but at least now we have instruments to stop doing it. For now, I'll simply update the test; in an ideal world, yes, we should generate these tests. -- Best regards, Dmitry Selyutin