From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by sourceware.org (Postfix) with ESMTPS id CD9CC3857C50 for ; Tue, 12 Jul 2022 06:58:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CD9CC3857C50 Received: by mail-ej1-x62c.google.com with SMTP id ss3so6619727ejc.11 for ; Mon, 11 Jul 2022 23:58:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gMCpSyeqaq75zoI+akZFPxZ7TZzf1bY7b85CwtFnMP0=; b=WCz+2lZlUuIfjpXDQxL2Myv8ZYmqBysJKMlj4SXpjxsxV4Pgms6Rr7W92YEP8Mf3JB LGHmXEfkv3r+N0crZaWwjbZgh7P6uoSDnN/c6I0r+48n3ZycpsLCS57pYACJlZYeWHUg a21LUP6TG8CFULp88js8x+k6DBHpuY19QazQIQmuwiJkC5GgDEAJx/TS62bIvyQ7WPis esTvS+Iq7uDortqS8Pm5DWj/RxRILByx2PdkQKzodrmusMGNbz6v/yI+7qnqNXbjSV4g gp+Y5iM+px+Le7aIgwSWMewa6wOTRWRe03H0JmyVaiM44gIyK/+ft9G8BCy2qr8pHiRZ /kPg== X-Gm-Message-State: AJIora/w5g7GoHLsTiWyWigks8csUsQd9hFcAiGPE5E3ah89EbkGy7Ix /aoPtPw2WnMDhvf0hU2H2inNP7JbbqCqM42ct+c= X-Google-Smtp-Source: AGRyM1vziyIYBF/pxmTchn1G28LcX6crmlXaBLXF9AzmjEB0U/50m0GCAbufcePdMzQZkfH2XMwHPMzV80waUDewF0s= X-Received: by 2002:a17:907:a40b:b0:72b:64e3:4c5e with SMTP id sg11-20020a170907a40b00b0072b64e34c5emr6501982ejc.612.1657609131602; Mon, 11 Jul 2022 23:58:51 -0700 (PDT) MIME-Version: 1.0 References: <2A99A5EA-C863-465C-A983-244A48D2E3C3@gmail.com> <473de1ae-ab00-357c-56e1-a12e2eab779a@suse.com> In-Reply-To: <473de1ae-ab00-357c-56e1-a12e2eab779a@suse.com> From: Dmitry Selyutin Date: Tue, 12 Jul 2022 09:58:15 +0300 Message-ID: Subject: Re: Teaching expression() to treat some operations specially To: Jan Beulich Cc: lkcl , Binutils , Alan Modra Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jul 2022 06:58:55 -0000 On Tue, Jul 12, 2022 at 9:25 AM Jan Beulich wrote: > May I ask which other struct fields are consumed and where? It is > my understanding that for O_register other fields simply are > invalid ... Also, it seems a bit strange that, instead of providing md_operand, we rather try to parse with a custom routine, register_name: https://sourceware.org/git/?p=binutils-gdb.git;a=blob;f=gas/config/tc-ppc.c;h=5015777d60061e61ffe4c78591b793862919c769;hb=HEAD#l3444 I'd rather expect we have this logic in md_operand. We could avoid duplicating some bits in ppc_parse_name. Also, this way, we would cover macros as well, which we don't do now. -- Best regards, Dmitry Selyutin