From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by sourceware.org (Postfix) with ESMTPS id 074803856958 for ; Tue, 21 Jun 2022 11:55:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 074803856958 Received: by mail-ej1-x631.google.com with SMTP id o7so26973441eja.1 for ; Tue, 21 Jun 2022 04:55:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0Wz9TLjP06k1RC5CIDg1xNkwNelChfaP8oIlzMWCrX4=; b=IyOtmxlcVe2bYhiW3eErQsTO/alqJRTTu0qEKHjVXUL/Yr48pPnMSO83KKR9gNRfCZ wXvZvisHhFqe8yAkuBmwcrE4alevqIEJIY0Q6IPMQaBS9jDoCIeKAiV2O2W9bdweqhqy KY9ok/xv7gyf9vSVfPr2/cncBXpmb213bqOTrglvmihDm87nz5rU2YnuCpjecP/5HLv7 Q0mkS/ogL4CWV48It3pvR4HjZ0a+d06NVq9aaPc5zJvo4lBfUyVZDLOnCRwsUGi51Q+z m6qhTryTuaRIw1VUCGqusBYks3a2hYpe2zQp2VrLcx6GY0ybZu7oEP46w53I3ADglkRZ oppw== X-Gm-Message-State: AJIora+6sn8udBR7M31VP4N3LOrfaBr3wqjAdrvZu3tqp1U55vQSdAWL it32wrgsPrVdQ9wFx2WfNN+IDopSDTREMu4LQup82uix X-Google-Smtp-Source: AGRyM1tzXjFil9RDTSk0vKWd6wp8C+MwnMppKlrRtXIG/BE6j3lt/K7uUv6fHd8+4qx+TwzFcH1rEJXeSowAblzsOrQ= X-Received: by 2002:a17:906:2088:b0:711:f512:837a with SMTP id 8-20020a170906208800b00711f512837amr25557316ejq.113.1655812544836; Tue, 21 Jun 2022 04:55:44 -0700 (PDT) MIME-Version: 1.0 References: <20220617190820.452821-1-ghostmansd@gmail.com> In-Reply-To: From: Dmitry Selyutin Date: Tue, 21 Jun 2022 14:55:08 +0300 Message-ID: Subject: Re: [PATCH 0/5] ppc/svp64: support SVP64 and its first insns To: Alan Modra Cc: binutils@sourceware.org, Luke Kenneth Casson Leighton Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jun 2022 11:55:47 -0000 On Mon, Jun 20, 2022 at 2:50 AM Alan Modra wrote: > These all look good to me, and can be pushed when your copyright > assignment is complete. Still no news about it. We have contacted fst-records at GNU and copyright-clerk at FSF, no reply yet. > The only review comment I have is that > #define SVme TO > would be better for maintenance if placed with the TO definition, so > that someone doesn't change the TO entry without realising they are > also changing things for SVme. Similarly for the other aliases you > define. I've chosen the approach in patches since it made tracking arguments somewhat simpler. Anyway, I totally agree with your rationale, I've just submitted the updated patch to the mailing list.