public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Luca Boccassi <luca.boccassi@gmail.com>
To: Cary Coutant <ccoutant@gmail.com>
Cc: Binutils <binutils@sourceware.org>,
	Nick Clifton <nickc@redhat.com>,  Alan Modra <amodra@gmail.com>
Subject: Re: [PATCH v2] gold: add --package-metadata
Date: Fri, 5 Aug 2022 10:54:46 +0100	[thread overview]
Message-ID: <CAMw=ZnQ4ZNE9-q7nOSPrK3rAzFzSoVkqKOFFPx4frKbdk3nkaA@mail.gmail.com> (raw)
In-Reply-To: <CAJimCsFQEi20o65NJWt9QrSOb6YXb5U2RU5WntPLqDkLHO+34Q@mail.gmail.com>

On Fri, 5 Aug 2022 at 01:41, Cary Coutant <ccoutant@gmail.com> wrote:
>
> > v2: apply fixes from review
> >
> >  elfcpp/elfcpp.h                        |  4 ++-
> >  gold/Makefile.am                       |  8 ++---
> >  gold/configure.ac                      | 26 ++++++++++++++
> >  gold/layout.cc                         | 50 ++++++++++++++++++++++++++
> >  gold/layout.h                          |  6 ++++
> >  gold/options.h                         |  4 +++
> >  gold/testsuite/Makefile.am             | 15 +++++---
> >  gold/testsuite/package_metadata_main.c |  5 +++
>
> Committed. Thanks!
>
> elfcpp/
>         * elfcpp.h: Add FDO_PACKAGING_METADATA note type.
>
> gold/
>         * Makefile.am: Add jansson flags and libraries.
>         * configure.ac: Check for jansson library.
>         * layout.cc (Layout::create_notes): Call create_package_metadata().
>         (Layout::create_package_metadata): New function.
>         * layout.h (Layout::create_package_metadata): New function.
>         (Layout::package_metadata_note_): New data member.
>         * options.h (class General_options): Add --package-metadata option.
>         * testsuite/Makefile.am (object_unittest): Add jansson libraries.
>         (binary_unittest): Likewise.
>         (leb128_unittest): Likewise.
>         (overflow_unittest): Likewise.
>         (package_metadata_test): New test.
>         * testsuite/package_metadata_main.c: New test source.
>
> -cary

Fantastic, thank you very much!

Kind regards,
Luca Boccassi

      reply	other threads:[~2022-08-05  9:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-26 19:22 [PATCH] " luca.boccassi
2022-07-29 19:41 ` Cary Coutant
2022-07-29 22:30   ` Luca Boccassi
2022-07-29 22:29 ` [PATCH v2] " luca.boccassi
2022-08-02 10:50   ` Luca Boccassi
2022-08-04 14:08     ` Luca Boccassi
2022-08-05  0:41   ` Cary Coutant
2022-08-05  9:54     ` Luca Boccassi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMw=ZnQ4ZNE9-q7nOSPrK3rAzFzSoVkqKOFFPx4frKbdk3nkaA@mail.gmail.com' \
    --to=luca.boccassi@gmail.com \
    --cc=amodra@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=ccoutant@gmail.com \
    --cc=nickc@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).