From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by sourceware.org (Postfix) with ESMTPS id 9577A3857C7C for ; Tue, 2 Aug 2022 10:50:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9577A3857C7C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-f53.google.com with SMTP id ss3so25172487ejc.11 for ; Tue, 02 Aug 2022 03:50:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=PR4aj+wp0OoVhuyf6QKqfxu7y6bOfuEjvMNYZTYah8k=; b=5F5zMwXrvL8isL92HT7lF/1T1Clel+KNUwLW7pAy1MkRLaYjV2Vf2NW66mFJEGLBuY b9SHw5SSCM+evTsCLnaWej3PxqRl5q5HfIUqLSmly78SAZ3Ohm8Cm40v/jARm/Wcz5G7 FqTdAES/qQMmhB+euA2h9LGwB6eyCpWarupEcgXCVs65Px4JCK8FuD85wX4wHsBSRq5K HrVzY4oBHPOktunjfV9+X57Ykzg9u/30jSD3aqcVV8DYSBf10JHVEujvQU0NEDNR+wie e6muV1mjKmi3lJ7hvOHwvrAtrA0dCHwpNxcZhzfK6haLktLtX/wXowfsc2+x91DXlqv/ 12rg== X-Gm-Message-State: AJIora/rAUPPmksMbPaoxE406tfxS5tJdPHLNyx8lLMe3uh1YNKZYWIJ J0H8f7NrypM1zrUFMhmvwb0W02mx9uF2jw== X-Google-Smtp-Source: AGRyM1vLwHTGPWBTXaitYwBDc9U8HPedLSoWOuEICsP+J35dVjL3ozmt57CmA4qI7RRE3O5cr5r1tA== X-Received: by 2002:a17:906:dc92:b0:72f:da9b:7702 with SMTP id cs18-20020a170906dc9200b0072fda9b7702mr15741427ejc.383.1659437421373; Tue, 02 Aug 2022 03:50:21 -0700 (PDT) Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com. [209.85.218.52]) by smtp.gmail.com with ESMTPSA id o21-20020a1709061d5500b007300d771a98sm6256369ejh.175.2022.08.02.03.50.20 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Aug 2022 03:50:20 -0700 (PDT) Received: by mail-ej1-f52.google.com with SMTP id rq15so19193242ejc.10 for ; Tue, 02 Aug 2022 03:50:20 -0700 (PDT) X-Received: by 2002:a17:907:2d8a:b0:730:6880:c396 with SMTP id gt10-20020a1709072d8a00b007306880c396mr8835435ejc.192.1659437419936; Tue, 02 Aug 2022 03:50:19 -0700 (PDT) MIME-Version: 1.0 References: <20220726192216.1751042-1-luca.boccassi@gmail.com> <20220729222956.79836-1-luca.boccassi@gmail.com> In-Reply-To: <20220729222956.79836-1-luca.boccassi@gmail.com> From: Luca Boccassi Date: Tue, 2 Aug 2022 11:50:08 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] gold: add --package-metadata To: Binutils Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Aug 2022 10:50:24 -0000 On Fri, 29 Jul 2022 at 23:29, wrote: > > From: Luca Boccassi > > Following the same format as the implementation in ld: > 9e2bb0cb5e74aed4158f08495534922d7108f928 > > Generate a .note.package FDO package metadata ELF note, following > the spec: https://systemd.io/ELF_PACKAGE_METADATA/ > > If the jansson library is available at build time (and it is explicitly > enabled), link ld to it, and use it to validate that the input is > correct JSON, to avoid writing garbage to the file. The > configure option --enable-jansson has to be used to explicitly enable > it (error out when not found). This allows bootstrappers (or others who > are not interested) to seamlessly skip it without issues. > --- > v2: apply fixes from review Hello Cary, Anything else you'd like me to change here? Thanks! Kind regards, Luca Boccassi