Re: [PATCH] elf32-arm.c: Use prefix 0x when printing private flags. elfnn-aarch64.c: Likewise.

[Alexander Fedotov <alfedotov@gmail.com>]

Hi Andre

Could you please take a look in this patch ?

Best regards,
Alex

On Mon, Dec 14, 2020 at 3:46 PM Alexander Fedotov <alfedotov@gmail.com> wrote:
>
> Hi Nick
>
> Could you please take a look at this tiny fix. I've run make-check for
> Arm and AArch64 w/o errors locally.
>
> Best regards,
> Alex
>
>
> On Thu, Dec 10, 2020 at 3:43 PM Alexander Fedotov <alfedotov@gmail.com> wrote:
> >
> > Currently objudmp for Arm and AArch64 shows flags in decimal format that is misleading.
> >
> > ---
> >  bfd/ChangeLog       | 6 ++++++
> >  bfd/elf32-arm.c     | 4 ++--
> >  bfd/elfnn-aarch64.c | 4 ++--
> >  3 files changed, 10 insertions(+), 4 deletions(-)
> >
> > diff --git a/bfd/ChangeLog b/bfd/ChangeLog
> > index 99c275ce4f..3717cf4ffe 100644
> > --- a/bfd/ChangeLog
> > +++ b/bfd/ChangeLog
> > @@ -1,3 +1,9 @@
> > +2020-12-08  Alexander Fedotov  <alfedotov@gmail.com>
> > +
> > +       * elf32-arm.c (elf32_arm_print_private_bfd_data): Use prefix 0x
> > +       when printing private flags.
> > +       * elfnn-aarch64.c (elfNN_aarch64_print_private_bfd_data): Likewise.
> > +
> >  2020-12-07  Siddhesh Poyarekar  <siddhesh@sourceware.org>
> >
> >         PR 26945
> > diff --git a/bfd/elf32-arm.c b/bfd/elf32-arm.c
> > index 2f6bd88555..eadfc34249 100644
> > --- a/bfd/elf32-arm.c
> > +++ b/bfd/elf32-arm.c
> > @@ -15062,7 +15062,7 @@ elf32_arm_print_private_bfd_data (bfd *abfd, void * ptr)
> >    /* Ignore init flag - it may not be set, despite the flags field
> >       containing valid data.  */
> >
> > -  fprintf (file, _("private flags = %lx:"), elf_elfheader (abfd)->e_flags);
> > +  fprintf (file, _("private flags = 0x%lx:"), elf_elfheader (abfd)->e_flags);
> >
> >    switch (EF_ARM_EABI_VERSION (flags))
> >      {
> > @@ -15183,7 +15183,7 @@ elf32_arm_print_private_bfd_data (bfd *abfd, void * ptr)
> >    flags &= ~ (EF_ARM_RELEXEC | EF_ARM_PIC);
> >
> >    if (flags)
> > -    fprintf (file, _("<Unrecognised flag bits set>"));
> > +    fprintf (file, _(" <Unrecognised flag bits set>"));
> >
> >    fputc ('\n', file);
> >
> > diff --git a/bfd/elfnn-aarch64.c b/bfd/elfnn-aarch64.c
> > index fcb6171679..96eef4ec43 100644
> > --- a/bfd/elfnn-aarch64.c
> > +++ b/bfd/elfnn-aarch64.c
> > @@ -7331,10 +7331,10 @@ elfNN_aarch64_print_private_bfd_data (bfd *abfd, void *ptr)
> >       containing valid data.  */
> >
> >    /* xgettext:c-format */
> > -  fprintf (file, _("private flags = %lx:"), elf_elfheader (abfd)->e_flags);
> > +  fprintf (file, _("private flags = 0x%lx:"), elf_elfheader (abfd)->e_flags);
> >
> >    if (flags)
> > -    fprintf (file, _("<Unrecognised flag bits set>"));
> > +    fprintf (file, _(" <Unrecognised flag bits set>"));
> >
> >    fputc ('\n', file);
> >
> > --
> > 2.25.1
> >