From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oo1-xc33.google.com (mail-oo1-xc33.google.com [IPv6:2607:f8b0:4864:20::c33]) by sourceware.org (Postfix) with ESMTPS id D8B28385841B for ; Fri, 11 Feb 2022 18:17:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D8B28385841B Received: by mail-oo1-xc33.google.com with SMTP id t75-20020a4a3e4e000000b002e9c0821d78so11327205oot.4 for ; Fri, 11 Feb 2022 10:17:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9OQuqdkmhV6yWpM0nQP1s6hqv+QNhcoXY0cJfMO2mGc=; b=JybmzI49U2zSVtSCbw1Q/wayVC1LPcSN2qfNjiPIQNkoeQE3cMw56QyG8b6McREbN6 EDSLwduElPSTwH1N5XVJLQQ8d+UN1l9zzkl+7ElYCmTVBkH/GiZiiV7h+R0LJl5P426K 8B8colFP+M4B4jaMjZS0Ax8tprXNi0AyYvnAF+/xRfN9IVZ1xBtXRKtKqTHEoiGn3h39 6iRUrHMjl7MVK/KtpSSPXsFLpHjfJrZiQtSJnYYaZrQzLzXlOPaRxMsSIx4uwue0pO8X IvojjT0vEFniDlGZDG2pA+Uab0VPHDjtGoUcCiT+w/khEoFV+hbsWdS8R+rDzrUrmCHG li0g== X-Gm-Message-State: AOAM532shQxittVLQ0c/BBkJfpKHbZdJlmCbAggcPb7a3Tp2t0fdrbG7 cpRwU0LRWsxNl/5LiWnOzGVXFYaA4y5P7i+efBOOhAMp X-Google-Smtp-Source: ABdhPJwk5607NSdgmvhFPVcA0v5igV0j1W2w9agdEntT08p8vE3fnBsdXOTWIN5PjDOm9DSnv0Ztf0+ROA4+CRnKfcI= X-Received: by 2002:a05:6870:a485:: with SMTP id j5mr529215oal.89.1644603449293; Fri, 11 Feb 2022 10:17:29 -0800 (PST) MIME-Version: 1.0 References: <9b561d25-fcfd-eb52-6237-472d12ead934@redhat.com> In-Reply-To: From: Alexander Lindsay Date: Fri, 11 Feb 2022 10:17:17 -0800 Message-ID: Subject: Re: Noted slowness in profile loading with binutils 2.37 To: Nick Clifton Cc: Binutils X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, HTML_MESSAGE, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Feb 2022 18:17:31 -0000 So it looks like you were spot-on On Fri, Feb 11, 2022 at 10:16 AM Alexander Lindsay wrote: > Hi Nick, > > This was the result of my bisect: > > ca8f6bc629cb27792ce449e7253c74a3f6f75fda is the first bad commit > Date: Tue Mar 2 16:08:23 2021 +0000 > > Fix the BFD library's parsing of DIEs where specification attributes > can refer to variables that are defined later on. > > PR 27484 > * dwarf2.c (scan_unit_for_symbols): Scan twice, once to > accumulate > function and variable tags and a second time to resolve their > attributes. > > bfd/ChangeLog | 7 ++++ > bfd/dwarf2.c | 133 > ++++++++++++++++++++++++++++++++++++++++++++++------------ > 2 files changed, 114 insertions(+), 26 deletions(-) > > On Thu, Feb 10, 2022 at 3:00 AM Nick Clifton wrote: > >> Hi Alexander, >> >> > - binutils version 2.36.1: 6.5 seconds >> > - binutils version 2.37: Still not loaded at 6 minutes >> > >> > I think the relevant binutil tool here is addr2line. Does anyone have a >> > quick idea for what may have caused the slow-down? >> >> It will be a change in the BFD library. More specifically it >> is likely to be a change to bfd/dwarf2.c. Have a look at the >> ChangeLog in the bfd/ directory for the 2.37 release for more >> hints. >> >> I suspect, but do not know for sure, that it could be the patch >> for PR 27484 .... >> >> Cheers >> Nick >> >> >>