From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x32d.google.com (mail-ot1-x32d.google.com [IPv6:2607:f8b0:4864:20::32d]) by sourceware.org (Postfix) with ESMTPS id 04CD63858030 for ; Fri, 11 Feb 2022 18:16:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 04CD63858030 Received: by mail-ot1-x32d.google.com with SMTP id b17-20020a9d4791000000b005a17fc2dfc1so6682933otf.1 for ; Fri, 11 Feb 2022 10:16:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oU7KNmA2UI//POXOCG2ouu08WsWmqGUDLNXMyGj4OCo=; b=Bz9bPRxnPtdtdvIGD1gh4bAI8NCRNkibI2jb5JgZGVbr7rp++PgId5vOHnYZNIXzxO h3V2vI78e/njlBjseRQw3oQoSeBiIvvnrWVp9JUt/PqTZvOMn26v78JnlSBjE43HYS5l kN4D7pc0R1GV/TCYS8ZoMil22xr/5mmSRDLP6SYDCXb6vw8MhaLCWBnhY2TXJan3CHqS 49NtpoLDDrqTffBWSCSA9wq8AyX7fm5hM5mWQPhVV7pwfP3JJtnOKicqegY4SiE8UPtv xXg/3gAWGbus54ZwH+B2OhyvKxW0MdSyl3RxgzBwUwQJGHUTRBgyk+00dphDBy3bkQhc wjoA== X-Gm-Message-State: AOAM532WvY7EwYtcZKTS5PyzNdC9kjWxZLHFpmnotsrMlaAUSN7vn81N v0D1pUPcz+TwUCtAUuFDHn7geuH7Q9Lf5BQF4rmxYtlXDRE= X-Google-Smtp-Source: ABdhPJzXXwbLpjMOzq8TStweg1J+bC+VD+rvQV0ZD51VKBDW6gQ736yKukyCPthfhXnr30CII7s9xRxZYp3ewzFLVIw= X-Received: by 2002:a9d:6e0f:: with SMTP id e15mr1043842otr.81.1644603392388; Fri, 11 Feb 2022 10:16:32 -0800 (PST) MIME-Version: 1.0 References: <9b561d25-fcfd-eb52-6237-472d12ead934@redhat.com> In-Reply-To: <9b561d25-fcfd-eb52-6237-472d12ead934@redhat.com> From: Alexander Lindsay Date: Fri, 11 Feb 2022 10:16:20 -0800 Message-ID: Subject: Re: Noted slowness in profile loading with binutils 2.37 To: Nick Clifton Cc: Binutils X-Spam-Status: No, score=-0.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, HTML_MESSAGE, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Feb 2022 18:16:35 -0000 Hi Nick, This was the result of my bisect: ca8f6bc629cb27792ce449e7253c74a3f6f75fda is the first bad commit Date: Tue Mar 2 16:08:23 2021 +0000 Fix the BFD library's parsing of DIEs where specification attributes can refer to variables that are defined later on. PR 27484 * dwarf2.c (scan_unit_for_symbols): Scan twice, once to accumulate function and variable tags and a second time to resolve their attributes. bfd/ChangeLog | 7 ++++ bfd/dwarf2.c | 133 ++++++++++++++++++++++++++++++++++++++++++++++------------ 2 files changed, 114 insertions(+), 26 deletions(-) On Thu, Feb 10, 2022 at 3:00 AM Nick Clifton wrote: > Hi Alexander, > > > - binutils version 2.36.1: 6.5 seconds > > - binutils version 2.37: Still not loaded at 6 minutes > > > > I think the relevant binutil tool here is addr2line. Does anyone have a > > quick idea for what may have caused the slow-down? > > It will be a change in the BFD library. More specifically it > is likely to be a change to bfd/dwarf2.c. Have a look at the > ChangeLog in the bfd/ directory for the 2.37 release for more > hints. > > I suspect, but do not know for sure, that it could be the patch > for PR 27484 .... > > Cheers > Nick > > >