* [PATCH/PR14355] Fix in XOP table in objdump
@ 2012-07-19 12:41 Michael Zolotukhin
2012-07-19 13:42 ` H.J. Lu
0 siblings, 1 reply; 3+ messages in thread
From: Michael Zolotukhin @ 2012-07-19 12:41 UTC (permalink / raw)
To: binutils; +Cc: Kirill Yukhin, H.J. Lu
[-- Attachment #1: Type: text/plain, Size: 982 bytes --]
Hi,
The patch fixes this bug:
http://sourceware.org/bugzilla/show_bug.cgi?id=14355
Ok for trunk?
opcodes/Changelog entry:
2012-07-19 Michael Zolotukhin <michael.v.zolotukhin@intel.com>
PR binutils/14355
* i386-dis.c (VEX_LEN_0FXOP_08_CC): New.
(VEX_LEN_0FXOP_08_CD): Likewise.
(VEX_LEN_0FXOP_08_CE): Likewise.
(VEX_LEN_0FXOP_08_CF): Likewise.
(VEX_LEN_0FXOP_08_EC): Likewise.
(VEX_LEN_0FXOP_08_ED): Likewise.
(VEX_LEN_0FXOP_08_EE): Likewise.
(VEX_LEN_0FXOP_08_EF): Likewise.
(xop_table): Fix entries for vpcomb, vpcomw, vpcomd, vpcomq, vpcomub,
vpcomuw, vpcomud, vpcomuq.
(vex_len_table): Add entries for VEX_LEN_0FXOP_08_CC,
VEX_LEN_0FXOP_08_CD, VEX_LEN_0FXOP_08_CE, VEX_LEN_0FXOP_08_CF,
VEX_LEN_0FXOP_08_EC, VEX_LEN_0FXOP_08_ED, VEX_LEN_0FXOP_08_EE,
VEX_LEN_0FXOP_08_EF.
--
---
Best regards,
Michael V. Zolotukhin,
Software Engineer
Intel Corporation.
[-- Attachment #2: 14355.patch --]
[-- Type: application/octet-stream, Size: 2502 bytes --]
diff --git a/opcodes/i386-dis.c b/opcodes/i386-dis.c
index 4a01441..4979aff 100644
--- a/opcodes/i386-dis.c
+++ b/opcodes/i386-dis.c
@@ -1318,8 +1318,16 @@ enum
VEX_LEN_0F3A7F_P_2,
VEX_LEN_0F3ADF_P_2,
VEX_LEN_0F3AF0_P_3,
+ VEX_LEN_0FXOP_08_CC,
+ VEX_LEN_0FXOP_08_CD,
+ VEX_LEN_0FXOP_08_CE,
+ VEX_LEN_0FXOP_08_CF,
+ VEX_LEN_0FXOP_08_EC,
+ VEX_LEN_0FXOP_08_ED,
+ VEX_LEN_0FXOP_08_EE,
+ VEX_LEN_0FXOP_08_EF,
VEX_LEN_0FXOP_09_80,
- VEX_LEN_0FXOP_09_81
+ VEX_LEN_0FXOP_09_81,
};
enum
@@ -6885,10 +6893,10 @@ static const struct dis386 xop_table[][256] = {
{ Bad_Opcode },
{ Bad_Opcode },
{ Bad_Opcode },
- { "vpcomb", { XM, Vex128, EXx, Ib } },
- { "vpcomw", { XM, Vex128, EXx, Ib } },
- { "vpcomd", { XM, Vex128, EXx, Ib } },
- { "vpcomq", { XM, Vex128, EXx, Ib } },
+ { VEX_LEN_TABLE (VEX_LEN_0FXOP_08_CC) },
+ { VEX_LEN_TABLE (VEX_LEN_0FXOP_08_CD) },
+ { VEX_LEN_TABLE (VEX_LEN_0FXOP_08_CE) },
+ { VEX_LEN_TABLE (VEX_LEN_0FXOP_08_CF) },
/* d0 */
{ Bad_Opcode },
{ Bad_Opcode },
@@ -6921,10 +6929,10 @@ static const struct dis386 xop_table[][256] = {
{ Bad_Opcode },
{ Bad_Opcode },
{ Bad_Opcode },
- { "vpcomub", { XM, Vex128, EXx, Ib } },
- { "vpcomuw", { XM, Vex128, EXx, Ib } },
- { "vpcomud", { XM, Vex128, EXx, Ib } },
- { "vpcomuq", { XM, Vex128, EXx, Ib } },
+ { VEX_LEN_TABLE (VEX_LEN_0FXOP_08_EC) },
+ { VEX_LEN_TABLE (VEX_LEN_0FXOP_08_ED) },
+ { VEX_LEN_TABLE (VEX_LEN_0FXOP_08_EE) },
+ { VEX_LEN_TABLE (VEX_LEN_0FXOP_08_EF) },
/* f0 */
{ Bad_Opcode },
{ Bad_Opcode },
@@ -8993,6 +9001,46 @@ static const struct dis386 vex_len_table[][2] = {
{ "rorxS", { Gdq, Edq, Ib } },
},
+ /* VEX_LEN_0FXOP_08_CC */
+ {
+ { "vpcomb", { XM, Vex128, EXx, Ib } },
+ },
+
+ /* VEX_LEN_0FXOP_08_CD */
+ {
+ { "vpcomw", { XM, Vex128, EXx, Ib } },
+ },
+
+ /* VEX_LEN_0FXOP_08_CE */
+ {
+ { "vpcomd", { XM, Vex128, EXx, Ib } },
+ },
+
+ /* VEX_LEN_0FXOP_08_CF */
+ {
+ { "vpcomq", { XM, Vex128, EXx, Ib } },
+ },
+
+ /* VEX_LEN_0FXOP_08_EC */
+ {
+ { "vpcomub", { XM, Vex128, EXx, Ib } },
+ },
+
+ /* VEX_LEN_0FXOP_08_ED */
+ {
+ { "vpcomuw", { XM, Vex128, EXx, Ib } },
+ },
+
+ /* VEX_LEN_0FXOP_08_EE */
+ {
+ { "vpcomud", { XM, Vex128, EXx, Ib } },
+ },
+
+ /* VEX_LEN_0FXOP_08_EF */
+ {
+ { "vpcomuq", { XM, Vex128, EXx, Ib } },
+ },
+
/* VEX_LEN_0FXOP_09_80 */
{
{ "vfrczps", { XM, EXxmm } },
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH/PR14355] Fix in XOP table in objdump
2012-07-19 12:41 [PATCH/PR14355] Fix in XOP table in objdump Michael Zolotukhin
@ 2012-07-19 13:42 ` H.J. Lu
2012-07-19 13:44 ` Michael Zolotukhin
0 siblings, 1 reply; 3+ messages in thread
From: H.J. Lu @ 2012-07-19 13:42 UTC (permalink / raw)
To: Michael Zolotukhin; +Cc: binutils, Kirill Yukhin
On Thu, Jul 19, 2012 at 5:41 AM, Michael Zolotukhin
<michael.v.zolotukhin@gmail.com> wrote:
> Hi,
> The patch fixes this bug:
> http://sourceware.org/bugzilla/show_bug.cgi?id=14355
>
> Ok for trunk?
>
> opcodes/Changelog entry:
> 2012-07-19 Michael Zolotukhin <michael.v.zolotukhin@intel.com>
>
> PR binutils/14355
> * i386-dis.c (VEX_LEN_0FXOP_08_CC): New.
> (VEX_LEN_0FXOP_08_CD): Likewise.
> (VEX_LEN_0FXOP_08_CE): Likewise.
> (VEX_LEN_0FXOP_08_CF): Likewise.
> (VEX_LEN_0FXOP_08_EC): Likewise.
> (VEX_LEN_0FXOP_08_ED): Likewise.
> (VEX_LEN_0FXOP_08_EE): Likewise.
> (VEX_LEN_0FXOP_08_EF): Likewise.
> (xop_table): Fix entries for vpcomb, vpcomw, vpcomd, vpcomq, vpcomub,
> vpcomuw, vpcomud, vpcomuq.
> (vex_len_table): Add entries for VEX_LEN_0FXOP_08_CC,
> VEX_LEN_0FXOP_08_CD, VEX_LEN_0FXOP_08_CE, VEX_LEN_0FXOP_08_CF,
> VEX_LEN_0FXOP_08_EC, VEX_LEN_0FXOP_08_ED, VEX_LEN_0FXOP_08_EE,
> VEX_LEN_0FXOP_08_EF.
>
>
It looks good. I checked it in for you with a tiny change.
Thanks.
--
H.J.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH/PR14355] Fix in XOP table in objdump
2012-07-19 13:42 ` H.J. Lu
@ 2012-07-19 13:44 ` Michael Zolotukhin
0 siblings, 0 replies; 3+ messages in thread
From: Michael Zolotukhin @ 2012-07-19 13:44 UTC (permalink / raw)
To: H.J. Lu; +Cc: binutils, Kirill Yukhin
Thanks, HJ!
On 19 July 2012 17:42, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Thu, Jul 19, 2012 at 5:41 AM, Michael Zolotukhin
> <michael.v.zolotukhin@gmail.com> wrote:
>> Hi,
>> The patch fixes this bug:
>> http://sourceware.org/bugzilla/show_bug.cgi?id=14355
>>
>> Ok for trunk?
>>
>> opcodes/Changelog entry:
>> 2012-07-19 Michael Zolotukhin <michael.v.zolotukhin@intel.com>
>>
>> PR binutils/14355
>> * i386-dis.c (VEX_LEN_0FXOP_08_CC): New.
>> (VEX_LEN_0FXOP_08_CD): Likewise.
>> (VEX_LEN_0FXOP_08_CE): Likewise.
>> (VEX_LEN_0FXOP_08_CF): Likewise.
>> (VEX_LEN_0FXOP_08_EC): Likewise.
>> (VEX_LEN_0FXOP_08_ED): Likewise.
>> (VEX_LEN_0FXOP_08_EE): Likewise.
>> (VEX_LEN_0FXOP_08_EF): Likewise.
>> (xop_table): Fix entries for vpcomb, vpcomw, vpcomd, vpcomq, vpcomub,
>> vpcomuw, vpcomud, vpcomuq.
>> (vex_len_table): Add entries for VEX_LEN_0FXOP_08_CC,
>> VEX_LEN_0FXOP_08_CD, VEX_LEN_0FXOP_08_CE, VEX_LEN_0FXOP_08_CF,
>> VEX_LEN_0FXOP_08_EC, VEX_LEN_0FXOP_08_ED, VEX_LEN_0FXOP_08_EE,
>> VEX_LEN_0FXOP_08_EF.
>>
>>
>
> It looks good. I checked it in for you with a tiny change.
>
> Thanks.
>
>
> --
> H.J.
--
---
Best regards,
Michael V. Zolotukhin,
Software Engineer
Intel Corporation.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-07-19 13:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-19 12:41 [PATCH/PR14355] Fix in XOP table in objdump Michael Zolotukhin
2012-07-19 13:42 ` H.J. Lu
2012-07-19 13:44 ` Michael Zolotukhin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).