From: Gianluca Guida <gianluca@rivosinc.com>
To: Tsukasa OI <research_trasio@irq.a4lg.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
Andrew Waterman <andrew@sifive.com>,
Jim Wilson <jim.wilson.gcc@gmail.com>,
Nelson Chu <nelson@rivosinc.com>,
Kito Cheng <kito.cheng@sifive.com>,
binutils@sourceware.org
Subject: Re: [PATCH 0/1] RISC-V: Add support for 'Zacas' atomic CAS
Date: Wed, 6 Dec 2023 18:39:38 +0000 [thread overview]
Message-ID: <CAOOZEBR0Knj+sqFcR=r38Kea7pZqibx6NJno6RCkYYqoK+=vXg@mail.gmail.com> (raw)
In-Reply-To: <cover.1697857915.git.research_trasio@irq.a4lg.com>
Hi Tsukasa,
I somehow missed this thread completely, as I wasn't in CC. Catching up now.
On Sat, Oct 21, 2023 at 4:12 AM Tsukasa OI <research_trasio@irq.a4lg.com> wrote:
>
> Differences to Gianluka's:
> 1. Correct data size (INSN_DREF|INSN_*_BYTE) we are handling
Correct, that was in fact fixed in my patch on my current tree.
Surprised didn't catch that earlier.
> 2. Make register pair matching function to be template
> to enable reusing this framework for upcoming P and existing Zdinx and
> V (many V cases are invalid only on certain runtime configuration and
> "always invalid" detectable cases are rare, but not zero).
Sure, I wondered about other generalising support for pair of
registers, but I was expecting some kind of discussion on the review,
so I went for the simplest patch possible, when I implemented that in
the v2.
I don't have any strong opinion on which patch to use.
Gianluca.
prev parent reply other threads:[~2023-12-06 18:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-21 3:12 Tsukasa OI
2023-10-21 3:12 ` [PATCH 1/1] " Tsukasa OI
2023-10-22 3:54 ` [PATCH v2] " Tsukasa OI
2023-10-22 3:57 ` [REVIEW ONLY] UNRATIFIED RISC-V: Add support for 'Zabha' subword AMO extension Tsukasa OI
2023-10-22 3:59 ` [PATCH v2] RISC-V: Add support for 'Zacas' atomic CAS Tsukasa OI
2023-10-23 6:47 ` Jan Beulich
2023-10-24 4:07 ` Tsukasa OI
2023-10-24 6:02 ` Jan Beulich
2023-10-25 2:15 ` Nelson Chu
2023-10-25 6:02 ` Jan Beulich
2023-12-06 18:39 ` Gianluca Guida [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOOZEBR0Knj+sqFcR=r38Kea7pZqibx6NJno6RCkYYqoK+=vXg@mail.gmail.com' \
--to=gianluca@rivosinc.com \
--cc=andrew@sifive.com \
--cc=binutils@sourceware.org \
--cc=jim.wilson.gcc@gmail.com \
--cc=kito.cheng@sifive.com \
--cc=nelson@rivosinc.com \
--cc=palmer@dabbelt.com \
--cc=research_trasio@irq.a4lg.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).