From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by sourceware.org (Postfix) with ESMTPS id E0D843858D35 for ; Mon, 22 Apr 2024 12:26:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E0D843858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E0D843858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::536 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713788796; cv=none; b=t9+c7X5Fcl71PJlq2+h43enh66FDG7kKODHXaUeZxHnidpOgxAzwLjWLA32whlZSfjbmuKW7XdtA0NLOpoFRWfGpT2iUzMOw1h+my95FztLS+XQjJF3H9GcdYZL6ItqZ1tKy5ZUu/c2SixKu2nVVUrRf025ZrW4MoNEEugx3jtQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713788796; c=relaxed/simple; bh=5V7yIphExJJ+vgxevh7ejxcHEzOqg+dJiwkC7j5Ekn8=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=lT720IQ0v91YFstT8liGqT8Mkij/19cIpMHPSgBNMc9gTvm7x3lUJGrnHO46KsceppAdoTaee6UOvrrv9PVT2NwTYTSQWpUfktUtcOSibngZwqJnC4U9KavCNjdLxjlzLqYKBzJUuCD80Na1U4OCpu2X/GC035tp5sRZ8fefLYo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-5709cb80b03so4943394a12.2 for ; Mon, 22 Apr 2024 05:26:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713788793; x=1714393593; darn=sourceware.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=smrRmlxcsnbbTBWjGwFrLw32DY1wiodFm69vVS/oaBw=; b=iX3UonZo3SWnwLaCM/OPpttjyqlcmpenoC18hksd3v2yWNWZ97gpEo50QK2awp8guo Mx+Dr0KQB4IFnYe90LUb8M0nRfVArqB7mOgyk2TnEs20/6CuIskVXz/8HuIadGhY07aQ A1QevhTncTrXU/vikdL7mH8au7wZ33iffDpMcRD9m6pjrqJoq7mSBz29D1Ysi5llppxM VZDSckWoircwCe4dTCsayIsyNlrj0+H2l1Dapz0D85afUUD20wYk5Yh7PBtGxwvb2/Mm hPllKKY9OXcdTFpl2l/F1hx6ZZqUTq5QY7czLCGl+I9H/Mw+Gvaxqor5u9geqk/ldoLd Xkrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713788793; x=1714393593; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=smrRmlxcsnbbTBWjGwFrLw32DY1wiodFm69vVS/oaBw=; b=NL+vpDwQaZW5ILSYijj8lOJteRmB29KIyIMBUv4EoiPuveu5OOSmHvVDcHI3P5boY5 /i62JjDrF2UFOqxUufW5TJhjGgznchjbYpF7uUMsuY0gcGK6TnOArEwmMkddYCToS3LL aviPCRhBX16UaIgtKCCt4KYWDLErz7tq0ZJs3FQmszEpII9BowH6qbBA+UC4zMyXGF6+ o/9Q4hJAaVDkva5+brQC9WrGLTtcYlmsgNUc21aKmVlFrY0O/qCp/hLcmLRzq+Zq0Uyu apgKjKz4a5QuwFWFIzt8zibCmd1RvsL8jBpjJ42HX2Per6T3z88nfavNkJKDWRkZbt42 envA== X-Gm-Message-State: AOJu0Ywolc8pYWF62qA5nhBb8yWcN61XybYQ/yRRK8uZPpGuazkOJCrY nVpj6MGCYwlvQqlmNOypEvbYjVP4tY6+g07zL5SYF5XyRxnilisjg+GV1TvEtG7hDIC7JQjdavA cBU0oUOFN3EZLZUwQ37JgQ9GLIpgeLzwvCC6MBA== X-Google-Smtp-Source: AGHT+IGyV4QFPDFi6qS/DuYz3iz8fqBrPmZc5zFjoba0F/J4PD7VTebV47bcdEjKuBLamLCBNQc4OE9hn39OWS8B/0A= X-Received: by 2002:a17:907:1b10:b0:a55:ac38:7839 with SMTP id mp16-20020a1709071b1000b00a55ac387839mr3353086ejc.32.1713788793036; Mon, 22 Apr 2024 05:26:33 -0700 (PDT) MIME-Version: 1.0 References: <20240422093500.46611-1-victor.donascimento@arm.com> In-Reply-To: <20240422093500.46611-1-victor.donascimento@arm.com> From: Christophe Lyon Date: Mon, 22 Apr 2024 14:26:21 +0200 Message-ID: Subject: Re: [PATCH] aarch64: Fix coding style issue in `aarch64-dis.c' To: Victor Do Nascimento Cc: binutils@sourceware.org, richard.earnshaw@arm.com, nickc@redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-10.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Victor, On Mon, 22 Apr 2024 at 11:35, Victor Do Nascimento wrote: > > Fix integer value being returned from boolean function, as introduced > in `aarch64: Remove asserts from operand qualifier decoders [PR31595]'. > --- > opcodes/aarch64-dis.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/opcodes/aarch64-dis.c b/opcodes/aarch64-dis.c > index b70e6da9eb7..e1c3f557874 100644 > --- a/opcodes/aarch64-dis.c > +++ b/opcodes/aarch64-dis.c > @@ -1038,7 +1038,7 @@ aarch64_ext_ft (const aarch64_operand *self ATTRIBUTE_UNUSED, > return false; > info->qualifier = get_sreg_qualifier_from_value (value); > if (info->qualifier == AARCH64_OPND_QLF_ERR) > - return 0; > + return false; > } > > return true; > -- > 2.34.1 > I'd say this counts as 'obvious' ? Thanks, Christophe