From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by sourceware.org (Postfix) with ESMTPS id 39CE8384772F for ; Wed, 3 Apr 2024 08:22:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 39CE8384772F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 39CE8384772F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::632 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712132557; cv=none; b=jxbok9lbpXXy8C69Y10fwf1p+78ekC3wiiGrncRx/YEjko0uNqkFUcbdxXUtNWoulltORrosiL2nEdWcZEyZjSN6z2S3rE82CHLW24sJLZyKwhfM72nBYecTbAslxhrpIBKp2LnjYzxCbqtYtmuRTLn4/HwSQMvA8jrTFzBsM/s= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712132557; c=relaxed/simple; bh=BZMn75XgI2+o4bDWSmaPZ0MfVUDUF0dnRa6LBpdY8Xw=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=oEY3EBzQEzfwrFJmfTKnaGt4u+kwOgURWbsjybXVjy0VtAjU7Ev4ygiq0SQUKf8Uhe4QVOAXnte/GmXaJom/xJobwJ9FsesGR6LK139wq35VyIjUs0mI7pT4iS30sJM5u4IRfCAkZqe/lrljWkvuMKlIEea1QcoSyI4WFVBfu2Y= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-a4e8904bd71so204425466b.1 for ; Wed, 03 Apr 2024 01:22:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712132552; x=1712737352; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=fZ0Ykr9db+CsTI6dwTuEYs30wV/BzbOIarwxpevxEnk=; b=Gu9ZhLl7+makNXyqDb3Q69Pf/BYd+I22CHtGeh8D3DYipxcyJEqDDhiAd2bMBp0LPk wUJknPcB5NW/txu+SVLakDyN+iBXXBIAQ1cXXJ4NVVZtgHoy9/dvHF4otVlEeTgQd5Oz 2YSITWcUNegdis6ExaAg1/Zbldl3jBjpMa4Jw8R+vr/P/e8vjB7VW/t0zp5+s72Mt2YF APk3UHMdBcIQwOIjWPslaBcK0tMGlhioSFPfctyEyr0HHoRn+OLERGLjeTLZMAyVImhh 99eoqNl0zvvCjR9g/Ea+SWExAU5WXwe+AXCJpBH0zumwMmDm0oWkV6dHykgGi/O2jx/b nRkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712132552; x=1712737352; h=content-transfer-encoding:cc:to:subject:message-id:date:from :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fZ0Ykr9db+CsTI6dwTuEYs30wV/BzbOIarwxpevxEnk=; b=QPj1HRssrOX/PAWKykhumOhVfk1yRonSzA8Mb6Ht84WwQzRS7B7hbJP21WoBWoP0SP TZe70EJWxVZHhAo+RhhrJDvQnzGRF5h1dpgBSDGLR/3PFMZgJrz1ZCSVaymui8iuuJ/J KRU2H0KA91TY0Z8hnbwdyu+d2CTjakiFfkpS53afjyHiQd81zlvPx3F+Vqe1WcFfAjhF euSNx1GZ0m+Qq0dzRzmp6osFsjYCzyakTKHmQ5CoWokPzrTgzev6Q+vAXhY92Bl+AF5R XdVzNznfm0JPYq2Cj2C5dV39RGMy29eYIOx6PYwK6laHyrRjmR3i7hWJv8twb83ifI1J GzYg== X-Gm-Message-State: AOJu0YzK/6bqMzbk6QKcebRa3YoGYqvCUXfya+cipINtsX3ATCV+SKZL BDoiH7t2AYv7mROJ/ET2skyeC2l9ZNSHcxlIpssBml084r8wwP5PqudG44RQSCsDT5ImESrfZTl yDGZ0WHOmPtQRLUltaBoo9RY72FKnPzpW6lNI+zUBEdZIlPAd6a2COQ== X-Google-Smtp-Source: AGHT+IGwE6cRDJS1sZuSCAU4AwVp2Xge9Je31IaFtNfOd889wet/umuKawQcO4oNsdhUzkTNpZq5JKDEGR7e1pd5IkI= X-Received: by 2002:a17:906:7245:b0:a4e:2269:bc21 with SMTP id n5-20020a170906724500b00a4e2269bc21mr9653459ejk.1.1712132551828; Wed, 03 Apr 2024 01:22:31 -0700 (PDT) MIME-Version: 1.0 From: Christophe Lyon Date: Wed, 3 Apr 2024 10:22:24 +0200 Message-ID: Subject: Patches submission policy change To: binutils@sourceware.org, GCC Mailing List , gdb@sourceware.org, Nick Clifton , Richard Biener , Jakub Jelinek , Joel Brobecker , "Carlos O'Donell" Cc: Maxim Kuvyrkov , Thiago Bauermann , Adhemerval Zanella Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_MANYTO,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Dear release managers and developers, TL;DR: For the sake of improving precommit CI coverage and simplifying workflows, I=E2=80=99d like to request a patch submission policy change, so that we now include regenerated files. This was discussed during the last GNU toolchain office hours meeting [1] (2024-03-28). Benefits or this change include: - Increased compatibility with precommit CI - No need to manually edit patches before submitting, thus the =E2=80=9Cgit send-email=E2=80=9D workflow is simplified - Patch reviewers can be confident that the committed patch will be exactly what they approved - Precommit CI can test exactly what has been submitted Any concerns/objections? As discussed on the lists and during the meeting, we have been facing issues with testing a class of patches: those which imply regenerating some files. Indeed, for binutils and gcc, the current patch submission policy is to *not* include the regenerated files (IIUC the policy is different for gdb [2]). This means that precommit CI receives an incomplete patch, leading to wrong and misleading regression reports, and complaints/frustration. (our notifications now include a warning, making it clear that we do not regenerate files ;-) ) I thought the solution was as easy as adding =E2=80=93enable-maintainer-mod= e to the configure arguments but this has proven to be broken (random failures with highly parallel builds). I tried to workaround that by adding new =E2=80=9Cregenerate=E2=80=9D rules in the makefiles, that we cou= ld build at -j1 before running the real build with a higher parallelism level, but this is not ideal, not to mention that in the case of gcc, configuring target libraries requires having built all-gcc before, which is quite slow at -j1. Another approach used in binutils and gdb builtbots is a dedicated script (aka autoregen.py) which calls autotools as appropriate. It could be extended to update other types of files, but this can be a bit tricky (eg. some opcodes files require to build a generator first, some doc fragments also use non-trivial build sequences), and it creates a maintenance issue: the build recipe is duplicated in the script and in the makefiles. Such a script has proven to be useful though in postcommit CI, to catch regeneration errors. Having said that, it seems that for the sake of improving usefulness of precommit CI, the simplest way forward is to change the policy to include regenerated files. This does not seem to be a burden for developers, since they have to regenerate the files before pushing their patches anyway, and it also enables reviewers to make sure the generated files are correct. Said differently, if you want to increase the chances of having your patches tested by precommit CI, make sure to include all the regenerated files, otherwise you might receive failure notifications. Any concerns/objections? Thanks, Christophe [1] https://gcc.gnu.org/wiki/OfficeHours#Meeting:_2024-03-28_.40_1100h_EST5= EDT [2] https://inbox.sourceware.org/gdb/cc0a5c86-a041-429a-9890-efd3937606e5@s= imark.ca/