From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2a.google.com (mail-oa1-x2a.google.com [IPv6:2001:4860:4864:20::2a]) by sourceware.org (Postfix) with ESMTPS id F162D3858D28 for ; Thu, 4 May 2023 08:16:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F162D3858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-oa1-x2a.google.com with SMTP id 586e51a60fabf-1929818d7faso9390285fac.0 for ; Thu, 04 May 2023 01:16:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20221208.gappssmtp.com; s=20221208; t=1683188180; x=1685780180; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+fKzBfRKQUBoP4wM3hP6u3WOc12kUdmodi62cGjcxXo=; b=1H2lrlj19LNzP0axwYYa/1dha8Re9p1J9IXHxOAbXoNb3QqvbULGO2wer1uteHvUNg 5VsHw3ja4u6Eq4C7AA9WTQ4k3dmd3+hsn8GXY2TtFRsO6wUz3SwDADBJHe/Ge28hbbgI /Yi2wnYWHvDgiYlcdo4hmV1Z5V/ns2W0tvtNXLqOqgDJnAoozCcFUWMxkAse44rvnsAy iNc/3XT0hyn2/flnG4NLaw+om7HMO8tdXlnCGiBJoJfky9g/goxGPqEqy0TaVlM0aTnI iDpWZLm9qmOAieVuhgxrpdHMGRImlWObHejxUwi2Nbiq5b08+M7XqZWAhazXJx8wR7Mh TT2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683188180; x=1685780180; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+fKzBfRKQUBoP4wM3hP6u3WOc12kUdmodi62cGjcxXo=; b=XnrOGr6qK/NMO1xAt1NdYXMC9yZKbOarPtw792pCpLFvVopBIfPLPPOVwCugr5NI2n M0kepn1HgygwoD3Z/LLYIbmwCBN/nOTNpesgv87E8Xo/FVkROO/2xkmem0nb6VtXnKWa G8TILSf41yRPBKpvIsW+wrJri4V5tYImnrJ4FQ92Wvj33kbXcq64JNH9h1VR5ePpZ992 5lZjgRvXnLPYdqR8fRqMqBqcKOdGGdfJsyCAYGHP235URputYpZOd3GGvns6Hsewr4Z8 TpGNFuTVljAu6/D8H+nEpu1MM6vThlRIS5temIDYJwli8aC+I/nIEwdX6MMdny6dkKZ9 yRcw== X-Gm-Message-State: AC+VfDwpXFS10ipGlvsFEw6L2yoyPkA0za8K/kEAftD7f6nmVPG8g3pa 5oEoqfC2fPXxfL2dPz3cSeoQXIiuRZs9M/WmVajkgQ== X-Google-Smtp-Source: ACHHUZ7Lbpq6PR8oHg6KsglAg3oCooErcx7aYxGPAkugSdWHnsP6cHsBY4djf9V5Uh25LeYSi0eB8UVQRTnHCCWp3pk= X-Received: by 2002:aca:1c12:0:b0:387:4229:c48f with SMTP id c18-20020aca1c12000000b003874229c48fmr899275oic.26.1683188180338; Thu, 04 May 2023 01:16:20 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Nelson Chu Date: Thu, 4 May 2023 16:16:09 +0800 Message-ID: Subject: Re: [PATCH] RISC-V: tighten post-relocation-operator separator expectation To: Jan Beulich Cc: Binutils , Palmer Dabbelt , Andrew Waterman , Jim Wilson Content-Type: multipart/alternative; boundary="00000000000094655f05fad9c9e9" X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000094655f05fad9c9e9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks for helping to fix this :) Nelson On Fri, Apr 28, 2023 at 8:57=E2=80=AFPM Jan Beulich wro= te: > As per the spec merely a blank isn't okay as a separator, the operand > to the relocation function ought to be parenthesized. Enforcing this > then also eliminates an inconsistency in that > > lui t0, %hi sym > lui t0, %hi 0x1000 > > were accepted, but > > lui t0, %hi +sym > lui t0, %hi -0x1000 > > were not. > > --- a/gas/config/tc-riscv.c > +++ b/gas/config/tc-riscv.c > @@ -2200,7 +2200,9 @@ parse_relocation (char **str, bfd_reloc_ > { > size_t len =3D 1 + strlen (percent_op->str); > > - if (!ISSPACE ((*str)[len]) && (*str)[len] !=3D '(') > + while (ISSPACE ((*str)[len])) > + ++len; > + if ((*str)[len] !=3D '(') > continue; > > *str +=3D len; > --- a/gas/testsuite/gas/riscv/auipc-parsing.l > +++ b/gas/testsuite/gas/riscv/auipc-parsing.l > @@ -3,3 +3,5 @@ > .*: Error: illegal operands `lui x10,x11' > .*: Error: illegal operands `auipc x12,symbol' > .*: Error: illegal operands `lui x13,symbol' > +.*: Error: illegal operands `auipc x14,%hi symbol' > +.*: Error: illegal operands `lui x15,%hi symbol' > --- a/gas/testsuite/gas/riscv/auipc-parsing.s > +++ b/gas/testsuite/gas/riscv/auipc-parsing.s > @@ -4,3 +4,6 @@ > # Don't accept a symbol without %hi() for 'u' operands. > auipc x12,symbol > lui x13,symbol > +# Don't accept reloc functions without parentheses. > + auipc x14,%hi symbol > + lui x15,%hi symbol > --00000000000094655f05fad9c9e9--