From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2f.google.com (mail-oa1-x2f.google.com [IPv6:2001:4860:4864:20::2f]) by sourceware.org (Postfix) with ESMTPS id 2BFFF385829D for ; Fri, 16 Sep 2022 03:26:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2BFFF385829D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-oa1-x2f.google.com with SMTP id 586e51a60fabf-1280590722dso50388248fac.1 for ; Thu, 15 Sep 2022 20:26:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=odlDOXuSu3obtRonzf3o2IslTQWOncG2IED10z5yhZA=; b=w38Wp+Y/jKHHG6X4wvMrJb2NOIc5ImGPhGRgunPuSfgSqCH6Cid1DbPl4k0X2Ancm0 rCSAoLtFbweR4u+KBA9ikR/huKohE32/FHeJydKugMQLKxGB+hMR5xqFdtVQ95dIc+Jt N3B49N8DtDEU2cOzssZ5/ppyHPuiFQ381dmnbgEZl/sZ9Xd6YVDuV0aD9KN77X2sv5LI lCYrSlq7G4p4D6qcOe/LOUF2asYoMK22n+NnCG04INoTwxTfugudYdRos5JLvmpscP17 TJ7pWPe1inf/5ASQo770ARGdMiHm8MUdpkp1sRPv+z5emPzwHikbSa72MWvTZc1lOwOW FVKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=odlDOXuSu3obtRonzf3o2IslTQWOncG2IED10z5yhZA=; b=txwpgHPxWidPRUZ+K9fMJi9jBAyGzVb0lAhuAM2Y+iqojSR13GndybLY+9Qb2da3C5 blhpnhpqXURWCxLN4+rPWW5kXD+Q3FcBlst5yf/exQVlSdFBovGGthchxRm0Lue4OjA0 hzoAlumTwLihL18JQIvgF6MdmOE83TsxjR8nzvKUiuONKIt2x9P1xuv5uMeSUiPsIWSm gi6/EauZWpejX0fwcuO9j9vqpWcoHZp4MpRwnL0TMani+U6Yfw5tT+WgJAT9/kPpMI22 jVntpP0XAPd8Zm+6zqKeNlrn4XjbwpIW9lUqP6vdH62jnguiFyj7Lur3pL7t6+OoCWmr quOQ== X-Gm-Message-State: ACgBeo2j6WZGSkb1QZ2g3B9WtBDznBUNCFARyInHfbLyhMRPfsFh0uMj WnplKngK3ztmmJt5itsDtk5j1Z+FKIPhtM8Z2Jp94Q== X-Google-Smtp-Source: AA6agR6TmSN3kXOpTKlo5OvZidac0UY7q34gvTsh0OaAvZOfaCfRx/lUJqvWeXAby/t6o+JTY6xRuI2ZQ2zYWvXPpgQ= X-Received: by 2002:a05:6870:58aa:b0:118:307d:bb43 with SMTP id be42-20020a05687058aa00b00118307dbb43mr7421376oab.82.1663298801017; Thu, 15 Sep 2022 20:26:41 -0700 (PDT) MIME-Version: 1.0 References: <20220916013903.45339-1-nelson@rivosinc.com> In-Reply-To: From: Nelson Chu Date: Fri, 16 Sep 2022 11:26:30 +0800 Message-ID: Subject: Re: [committed] RISC-V: Make g imply zmmul extension. To: Jeff Law Cc: binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Sep 16, 2022 at 10:34 AM Jeff Law via Binutils wrote: > > > On 9/15/22 19:39, Nelson Chu wrote: > > bfd/ > > * elfxx-riscv.c (riscv_implicit_subset): Moved entry of m after g, > > so that g can imply zmmul. > > gas/ > > * testsuite/gas/riscv/attribute-01.d: Updated. > > * testsuite/gas/riscv/attribute-02.d: Likewise. > > * testsuite/gas/riscv/attribute-03.d: Likewise. > > * testsuite/gas/riscv/attribute-04.d: Likewise. > > * testsuite/gas/riscv/attribute-05.d: Likewise. > > * testsuite/gas/riscv/attribute-10.d: Likewise. > > * testsuite/gas/riscv/march-imply-g.d: Likewise. > > * testsuite/gas/riscv/march-imply-unsupported.d: Likewise. > > Does this happen to fix this kind of failure that started showing up a > week or two ago? > > /tmp/ccdAErP7.s:6522: Error: unrecognized opcode `mul a5,a4,a5', > extension `m' or `zmmul' required I get the same error message if I just assemble files with -march=rv32/64g, or just use the default rv64g arch setting. I remember gcc should always pass the expanded imafd for g to assembler, so the errors won't happen. This error should only happen when we set g for architecture string. Hope the patch can fix the problem you mentioned, it seems like the same as what I meet. > I started chasing it down and concluded it likely wasn't the compiler, > but couldn't take it further before covid knocked me out. I'm just > starting to try and catch up on things today... > Glad to hear you recovered :) Nelson > > jeff >