From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com [IPv6:2607:f8b0:4864:20::32e]) by sourceware.org (Postfix) with ESMTPS id 247113858C2C for ; Mon, 7 Nov 2022 03:48:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 247113858C2C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-ot1-x32e.google.com with SMTP id 46-20020a9d0631000000b00666823da25fso5893825otn.0 for ; Sun, 06 Nov 2022 19:48:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=7S3ELFyFRsGULITzPNvQY61Tk+1MAKggTewfJcTIB50=; b=WB/sZX24v9OcwEO5dP9b7zyqgO7ZivSU5Rgsf/4g9WMHqfpFl7ztx3OclO9X2AQCUV eqo8VVH03SFnsFtQfAgW2OKmi2c/gD58y3utyBLNdCoHRjVRRtOuH9GNl6RPYieyXg+G idULZmVI8J8Mo2ijFe1cpiChAU23Hj4lKFbDW46gqrsg+kTytFOgdoESsU9Cp9agl9LZ jWCeIVGI4DlCtx4KkFa6ANVyin2LHIdFY0H+KGcOo/DVBEUCuIm3Pn1SeNIKPzJGfUVA DlWEytWk32lCi9ffQw0eq/BGCMoEq8LeF7zGtJ3c4HGYuJm/YJKm9ewnVhhF69BSnb0L xb/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7S3ELFyFRsGULITzPNvQY61Tk+1MAKggTewfJcTIB50=; b=PHp1SkjZDpeIdwu34Nvq1ioDGG/6FS8xqyGo1zF0vVIVvAxLI0T78CKsPqbqlL6tVT 1v1GsmKMuxn4moEuFhigP4SuPs8DRx13gke+eBa9WOez9+keFXImDdfXRhfVVn1mOYu7 kxadLUsRrNvJyg/dQE79PD6R1N2P4QkwzrAa4XPVwLY/Bvca+dNtPlKHr2/e0H0QQmG6 ZBaskwlRZiYr7NWpDcV0UmGXZ3I0HJeJWB6Bs88bWSmDPGB6psmsJNiEhyBqkhSwrwS5 ot8vj49qRyUw+d75rGI+Of+TAZnvIvXnznfRVJGJ8kJjb54tOaxbigydcZ+tBMTit6cz +4ZQ== X-Gm-Message-State: ACrzQf3q18qRBcydSEFtM31QuM0TmWWeHVujtCwAJXsBjVnCCalQw6TF kX2c/deOrvGGLdRmIHeCwhbu8hm9ztq/VoiRpyNotVLzYNsQuw== X-Google-Smtp-Source: AMsMyM5oWx9K1Ua60laaAK+Sjvtp4NI5t4zDLPhP88EjYIDoE13fQTweKh7BC5zKjfmGXkV2sHzf3c18o6a4Nq4PpWg= X-Received: by 2002:a05:6830:10c5:b0:66c:5410:39a4 with SMTP id z5-20020a05683010c500b0066c541039a4mr20239387oto.320.1667792912418; Sun, 06 Nov 2022 19:48:32 -0800 (PST) MIME-Version: 1.0 References: <345c5c3b3a53eab04a1e6e91197de2642095c94f.1666185237.git.research_trasio@irq.a4lg.com> <39cd67c0-ec74-42f3-9805-519b9b43eaca@irq.a4lg.com> In-Reply-To: <39cd67c0-ec74-42f3-9805-519b9b43eaca@irq.a4lg.com> From: Nelson Chu Date: Mon, 7 Nov 2022 11:48:21 +0800 Message-ID: Subject: Re: [PING^1]Re: [PATCH] RISC-V: Remove RV32EF conflict To: Tsukasa OI Cc: binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: OK, please commit since it looks good to Kito. Thanks Nelson On Sat, Nov 5, 2022 at 7:50 PM Tsukasa OI wrote: > > Ping. > > c.f.: Original > > c.f.: LGTM by Kito > > > Regards, > Tsukasa > > On 2022/10/19 22:14, Tsukasa OI wrote: > > Despite that the RISC-V ISA Manual version 2.2 prohibited "RV32EF", later > > versions beginning with the version 20190608-Base-Ratified removed this > > restriction. Because the 'E' extension is still a draft, the author chose > > to *just* remove the conflict (not checking the ISA version). > > > > Note that, because RV32E is only used with a soft-float calling convention, > > there's no valid official ABI for RV32EF. It means, even if we can assemble > > a program with -march=rv32ef -mabi=ilp32e, floating-point registers are kept > > in an unmanaged state (outside ABI management). > > > > The purpose of this commit is to suppress unnecessary errors while parsing > > an ISA string and/or disassembling, not to allow hard-float with RVE. > > > > bfd/ChangeLog: > > > > * elfxx-riscv.c (riscv_parse_check_conflicts): Accept RV32EF > > because only older specifications disallowed it. > > > > gas/ChangeLog: > > > > * testsuite/gas/riscv/march-fail-rv32ef.d: Remove as not directly > > prohibited. > > * testsuite/gas/riscv/march-fail-rv32ef.l: Likewise. > > --- > > bfd/elfxx-riscv.c | 7 ------- > > gas/testsuite/gas/riscv/march-fail-rv32ef.d | 3 --- > > gas/testsuite/gas/riscv/march-fail-rv32ef.l | 2 -- > > 3 files changed, 12 deletions(-) > > delete mode 100644 gas/testsuite/gas/riscv/march-fail-rv32ef.d > > delete mode 100644 gas/testsuite/gas/riscv/march-fail-rv32ef.l > > > > diff --git a/bfd/elfxx-riscv.c b/bfd/elfxx-riscv.c > > index c89b1e53e92..334a63f0873 100644 > > --- a/bfd/elfxx-riscv.c > > +++ b/bfd/elfxx-riscv.c > > @@ -1870,13 +1870,6 @@ riscv_parse_check_conflicts (riscv_parse_subset_t *rps) > > rps->error_handler (_("rv%d does not support the `q' extension"), xlen); > > no_conflict = false; > > } > > - if (riscv_lookup_subset (rps->subset_list, "e", &subset) > > - && riscv_lookup_subset (rps->subset_list, "f", &subset)) > > - { > > - rps->error_handler > > - (_("rv32e does not support the `f' extension")); > > - no_conflict = false; > > - } > > if (riscv_lookup_subset (rps->subset_list, "zfinx", &subset) > > && riscv_lookup_subset (rps->subset_list, "f", &subset)) > > { > > diff --git a/gas/testsuite/gas/riscv/march-fail-rv32ef.d b/gas/testsuite/gas/riscv/march-fail-rv32ef.d > > deleted file mode 100644 > > index d7b51c3c17d..00000000000 > > --- a/gas/testsuite/gas/riscv/march-fail-rv32ef.d > > +++ /dev/null > > @@ -1,3 +0,0 @@ > > -#as: -march=rv32ef > > -#source: empty.s > > -#error_output: march-fail-rv32ef.l > > diff --git a/gas/testsuite/gas/riscv/march-fail-rv32ef.l b/gas/testsuite/gas/riscv/march-fail-rv32ef.l > > deleted file mode 100644 > > index e6d93f28fa5..00000000000 > > --- a/gas/testsuite/gas/riscv/march-fail-rv32ef.l > > +++ /dev/null > > @@ -1,2 +0,0 @@ > > -.*Assembler messages: > > -.*Error: .*rv32e does not support the `f' extension > > > > base-commit: 2b06e59de0675c2cb526af2de6803dae29703d15