Re: [PATCH 1/1] RISC-V: Set EF_RISCV_TSO also on .option arch

[Nelson Chu <nelson@rivosinc.com>]

OK, looks good, please commit if you think it's time.

Thanks
Nelson

On Wed, Sep 21, 2022 at 2:41 PM Tsukasa OI <research_trasio@irq.a4lg.com> wrote:
>
> This is a minor fix to commit 96462b012988d35ebb1137a2ad9fd0a96547d79a
> ("RISC-V: Implement Ztso extension").  Currently, it sets EF_RISCV_TSO ELF
> flag when initial ISA string contains the 'Ztso' extension.  However, GAS
> has a way to update the ISA string: ".option arch".
>
> When the architecture is updated by ".option arch", EF_RISCV_RVC ELF flag
> is set when the 'C' extension is detected.  Analogously, this commit sets
> the EF_RISCV_TSO when the 'Ztso' extension is detected.
>
> gas/ChangeLog:
>
>         * config/tc-riscv.c (s_riscv_option): Set TSO ELF flag if the
>         'Ztso' extension is specified via ".option arch" directive.
> ---
>  gas/config/tc-riscv.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/gas/config/tc-riscv.c b/gas/config/tc-riscv.c
> index b1abc8553b0..42d7bf62e4f 100644
> --- a/gas/config/tc-riscv.c
> +++ b/gas/config/tc-riscv.c
> @@ -3888,6 +3888,9 @@ s_riscv_option (int x ATTRIBUTE_UNUSED)
>        riscv_set_rvc (false);
>        if (riscv_subset_supports (&riscv_rps_as, "c"))
>         riscv_set_rvc (true);
> +
> +      if (riscv_subset_supports (&riscv_rps_as, "ztso"))
> +       riscv_set_tso ();
>      }
>    else if (strcmp (name, "push") == 0)
>      {
> --
> 2.34.1
>