From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22e.google.com (mail-oi1-x22e.google.com [IPv6:2607:f8b0:4864:20::22e]) by sourceware.org (Postfix) with ESMTPS id 83BE0385780A for ; Fri, 28 Oct 2022 07:38:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 83BE0385780A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-oi1-x22e.google.com with SMTP id i7so5385175oif.4 for ; Fri, 28 Oct 2022 00:38:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8DmclifSzln/HFwHIK1s7YcMk+1wGSEFnWSAkY8xC30=; b=3BTNxPyDAch3mK2YBstsM0g4WSbz69w7j/ZzpDoa5SwePN9BW4fq5e+mmOnfGDNFRo AcY08OqZ38EcuZzg572ijp0jc5+7EFS9M07MI5z63RyoTQapWJ/Qkl2RztlmnhHNCfmR PaePw19jiw7r6B98fnsljmloMb/5jdsHz/DrI76nHNrZlPcHEqjqD0TL78Aqo/VmfNgt s9I+pSlMNdgwqnqcTNIHkx4TO4QQoaUD1dJe0widL+VmaPaifkLI5NqDQMfLwnQO4L5O 66Q0xL5zTTmc9EiyZFPgTWOfGciPaAVkE9Qxb6BNsXogqgNOAlSiFDil891DLRucmesF vMcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8DmclifSzln/HFwHIK1s7YcMk+1wGSEFnWSAkY8xC30=; b=ckK486YiXMSeRRzLv8d0hKrVMVnvqL7ydGeJdxct84epXvp6vsUtzXfXADsnLVOjvN fKxlVOtQAZYthpGn/CnoFvtNXPFP8Qk52pbIxxb+ImHCMvrbRsSCZPg+TVSAIf24JlWv W5WKw/u4ZLtW4zYSRFXysruPysxpd6LiO0fnVT8cIKyLmG/uWZb8VJB78p2k2qRK9PMg cOlFFmPMfVGpMyOqxHO/dWRlWXOXVZ3Ix33UzR5HbNPp5F0Ns7FD8e1KeGTsmklE9LKJ MvnvS7JHvARDwm37rUbdqni8UGSxzYRnkFcDF31Yn1FrB/TaxL+KsmqW9OOsNrPLMU0N uGDA== X-Gm-Message-State: ACrzQf0Smxu45oONk8Rsu3jD6MQ1dPd9V4Q/jdgdOKlQEWTeU/3bpV++ mM22X9OS3w1BlOow79+Dt9O++hn6/VE/Q/7x3FLCDA== X-Google-Smtp-Source: AMsMyM5ciKI3KWVV5GFAIWQk7xvcNxJ0QKZA9Iz+fe9ZgGCcW4DgZM7z+RqV0Ihggsh1m2ug1kPLcwp6IzxDIss8WvE= X-Received: by 2002:a05:6808:211a:b0:354:b569:7a4d with SMTP id r26-20020a056808211a00b00354b5697a4dmr7352694oiw.107.1666942709940; Fri, 28 Oct 2022 00:38:29 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Nelson Chu Date: Fri, 28 Oct 2022 15:38:19 +0800 Message-ID: Subject: Re: [PATCH] RISC-V: Fix build failure for -Werror=maybe-uninitialized To: Tsukasa OI Cc: Kito Cheng , Palmer Dabbelt , binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-9.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Thanks, please commit. Nelson On Fri, Oct 28, 2022 at 2:53 PM Tsukasa OI w= rote: > > Commit 40f1a1a4564b ("RISC-V: Output mapping symbols with ISA string.") > caused a build failure on GCC 12 as follows: > > make[3]: Entering directory '$(builddir)/gas' > CC config/tc-riscv.o > In file included from $(srcdir)/gas/config/tc-riscv.c:23: > $(srcdir)/gas/as.h: In function =E2=80=98make_mapping_symbol=E2=80=99: > $(srcdir)/gas/as.h:123:15: error: =E2=80=98buff=E2=80=99 may be used unin= itialized [-Werror=3Dmaybe-uninitialized] > 123 | #define xfree free > | ^~~~ > $(srcdir)/gas/config/tc-riscv.c:487:9: note: =E2=80=98buff=E2=80=99 was d= eclared here > 487 | char *buff; > | ^~~~ > cc1: all warnings being treated as errors > make[3]: *** [Makefile:1425: config/tc-riscv.o] Error 1 > > This is caused by a false positive of "maybe uninitialized" variable > detection (-Wmaybe-uninitialized). To avoid this error, this commit > initializes the local variable buff to NULL first in all cases. > > gas/ChangeLog: > > * config/tc-riscv.c (make_mapping_symbol): Initialize variable > buff with NULL to avoid build failure caused by a GCC's false > positive of maybe uninitialized variable detection. > --- > gas/config/tc-riscv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gas/config/tc-riscv.c b/gas/config/tc-riscv.c > index 91cff7de604..f4478eac11e 100644 > --- a/gas/config/tc-riscv.c > +++ b/gas/config/tc-riscv.c > @@ -484,7 +484,7 @@ make_mapping_symbol (enum riscv_seg_mstate state, > bool reset_seg_arch_str) > { > const char *name; > - char *buff; > + char *buff =3D NULL; > switch (state) > { > case MAP_DATA: > > base-commit: 56d4450bdfc873ff3c2d1ebb194c7a076d4d13f6 > -- > 2.37.2 >