From: Nelson Chu <nelson@rivosinc.com>
To: Jiawei <jiawei@iscas.ac.cn>
Cc: binutils@sourceware.org, kito.cheng@sifive.com,
palmer@dabbelt.com, jbeulich@suse.com,
research_trasio@irq.a4lg.com, christoph.muellner@vrull.eu,
jeremy.bennett@embecosm.com, nandni.jamnadas@embecosm.com,
mary.bennett@embecosm.com, charlie.keaney@embecosm.com,
simon.cook@embecosm.com, sinan.lin@linux.alibaba.com,
gaofei@eswincomputing.com, fujin.zhao@foxmail.com,
wuwei2016@iscas.ac.cn, shihua@iscas.ac.cn,
shiyulong@iscas.ac.cn, chenyixuan@iscas.ac.cn
Subject: Re: [PATCH v7] RISC-V: Support Zcmp push/pop instructions.
Date: Tue, 9 Apr 2024 16:48:36 +0800 [thread overview]
Message-ID: <CAPpQWtAn5icGK-Ms_5=qfGx6qYBh9M2sRwOOenoOdC-7xn7FSg@mail.gmail.com> (raw)
In-Reply-To: <20240227034811.412600-1-jiawei@iscas.ac.cn>
[-- Attachment #1: Type: text/plain, Size: 37500 bytes --]
Committed after passing regressions of riscv-gnu-toolchain. Here is the
committed patch,
https://sourceware.org/pipermail/binutils/2024-April/133473.html.
However, I also do some changes as follows,
On Tue, Feb 27, 2024 at 11:49 AM Jiawei <jiawei@iscas.ac.cn> wrote:
> diff --git a/bfd/elfxx-riscv.h b/bfd/elfxx-riscv.h
> index ae4cbee7bc3..e60a40f63bb 100644
> --- a/bfd/elfxx-riscv.h
> +++ b/bfd/elfxx-riscv.h
> @@ -26,6 +26,7 @@
> #include "cpu-riscv.h"
>
> #define RISCV_UNKNOWN_VERSION -1
> +#define ZCMP_SP_ALIGNMENT 16
>
This seems duplicate in include/opcode/riscv.h, so I only keep one there.
> struct riscv_elf_params
> {
> diff --git a/gas/config/tc-riscv.c b/gas/config/tc-riscv.c
> index cbead954f09..c0613a5a664 100644
> --- a/gas/config/tc-riscv.c
> +++ b/gas/config/tc-riscv.c
> @@ -1253,6 +1253,130 @@ flt_lookup (float f, const float *array, size_t
> size, unsigned *regnop)
> return false;
> }
>
> +/* Map ra and s-register to [4,15], so that we can check if the
> + reg2 in register list reg1-reg2 or single reg2 is valid or not,
> + and obtain the corresponding reg_list value.
> +
> + ra - 4
> + s0 - 5
> + s1 - 6
> + ....
> + s10 - 0 (invalid)
> + s11 - 15. */
> +
> +static int
> +regno_to_reg_list (unsigned regno)
> +{
> + if (regno == X_RA)
> + return 4;
> + else if (regno == X_S0 || regno == X_S1)
> + return 5 + regno - X_S0;
> + else if (regno >= X_S2 && regno < X_S10)
> + return 7 + regno - X_S2;
> + else if (regno == X_S11)
> + return 15;
> +
> + return 0; /* invalid symbol */
> +}
> +
> +/* Parse register list, and the parsed reg_list value is stored in
> reg_list
> + argument.
> +
> + If ABI register names are used (e.g. ra and s0), the register
> + list could be "{ra}", "{ra, s0}", "{ra, s0-sN}", where 0 < N < 10 or
> + N == 11.
> +
> + If numeric register names are used (e.g. x1 and x8), the register list
> + could be "{x1}", "{x1,x8}", "{x1,x8-x9}", "{x1,x8-x9,x18}" and
> + "{x1,x8-x9,x18-xN}", where 19 < N < 25 or N == 27.
> +
> + It will fail if numeric register names and ABI register names are used
> + at the same time.
> +*/
> +
> +static bool
> +reglist_lookup (char **s, unsigned *reg_list)
> +{
> + unsigned regno = 0;
> + unsigned regnum = 0;
> + char *reglist = strdup (*s);
> + char *regname[3];
> +
> + if (reglist == NULL)
> + goto next;
> +
> + /* Use reglist to judge the reg name use. */
> + char *token = strtok (reglist, "}");
> + for(token = strtok (token, ","); token ;token = strtok (NULL, ",")) {
> + regname[regnum] = token;
> + regnum++;
> + }
>
The strtok has been used for extracting registers here, but the following
code still parses the original string before strtok, it seems weird
though. Therefore, I re-write the parser here. First of all, if the
register list is {x1, x8-x9, x18-x25}, then regname[0] is x1, rename[1] is
x8-x9, regname is x18-x25. However, we can extract the registers more
detailedly so that it's easier to analyze them later. Therefore, I update
regname[3] to 2-D regname[3][2] = {{x1, NULL}, {x8, x9}, {x18, x25}} by
strtok_r.
char *token = strtok_r (reglist, ",", &save_tok);
for (i = 0; i < 3 && token != NULL; token = strtok_r (NULL, ",",
&save_tok), i++)
{
char *subtoken = strtok_r (token, "-", &save_subtok);
for (j = 0; j < 2 && subtoken != NULL; subtoken = strtok_r (NULL, "-",
&save_subtok), j++)
regname[i][j] = subtoken;
}
> + /* Use to check if the register format is xreg. */
> + bool use_xreg = **s == 'x';
> +
> + /* The first register in the register list should be ra. */
> + if (!reg_lookup (s, RCLASS_GPR, ®no)
> + || !(*reg_list = regno_to_reg_list (regno)) /* update reg_list */
> + || regno != X_RA)
> + goto next;
> +
> + if (regnum == 1)
> + goto done;
> +
> + /* Do not use numeric and abi names at the same time. */
> + if ((*++*s != 'x') && use_xreg)
> + goto next;
>
Seems should be,
if ( ((*++*s != 'x') && use_xreg) || ((*++*s == 'x') && !use_xreg))
> + /* Reg1 should be s0 or its numeric names x8. */
> + if (!reg_lookup (s, RCLASS_GPR, ®no)
> + || !(*reg_list = regno_to_reg_list (regno))
> + || regno != X_S0)
> + goto next;
> +
> + if (strlen (regname[1]) == 2)
> + goto done;
> +
> + if ((*++*s != 'x') && use_xreg)
> + goto next;
> + /* Reg2 is x9 if the numeric name is used, otherwise,
> + it could be any other sN register, where N > 0. */
> + if (!reg_lookup (s, RCLASS_GPR, ®no)
> + || !(*reg_list = regno_to_reg_list (regno))
> + || regno <= X_S0
> + || (use_xreg && regno != X_S1))
> + goto next;
> +
> + if (regnum == 2)
> + goto done;
> +
> + if (regnum == 3 && use_xreg) {
> + if ((*++*s != 'x') && use_xreg)
> + goto next;
> + /* Reg3 should be s2. */
> + if (!reg_lookup (s, RCLASS_GPR, ®no)
> + || !(*reg_list = regno_to_reg_list (regno))
> + || regno != X_S2)
> + goto next;
> + if(strlen(regname[2]) == 3)
> + goto done;
> + if ((*++*s != 'x') && use_xreg)
> + goto next;
> + /* Reg4 could be any other sN register, where N > 1. */
> + if (!reg_lookup (s, RCLASS_GPR, ®no)
> + || !(*reg_list = regno_to_reg_list (regno))
> + || regno <= X_S2)
> + goto next;
> + goto done;
> + }
>
These bunches of if-else statements look complicated, so I rewrote them
into a switch, which means "case i" analysis regname[i][0] and
regname[i][1]. The tricky thing here is that the regname[i][j] will be
NULL after reg_lookup, so we need to take care that the reg_lookup should
be called the last.
There is a TODO - report more detailed error messages for every illegal
case here.
> + next:
> + free (reglist);
> + return false;
> + done:
> + free (reglist);
> + return true;
>
I wrapped another function outside to do strdup and free, so that we don't
need bunches of goto here.
> +}
> +
> #define USE_BITS(mask,shift) (used_bits |= ((insn_t)(mask) << (shift)))
> #define USE_IMM(n, s) \
> (used_bits |= ((insn_t)((1ull<<n)-1) << (s)))
> @@ -1369,6 +1493,8 @@ validate_riscv_insn (const struct riscv_opcode *opc,
> int length)
> case ',': break;
> case '(': break;
> case ')': break;
> + case '{': break;
> + case '}': break;
> case '<': USE_BITS (OP_MASK_SHAMTW, OP_SH_SHAMTW); break;
> case '>': USE_BITS (OP_MASK_SHAMT, OP_SH_SHAMT); break;
> case 'A': break; /* Macro operand, must be symbol. */
> @@ -1449,6 +1575,10 @@ validate_riscv_insn (const struct riscv_opcode
> *opc, int length)
> case 'h': used_bits |= ENCODE_ZCB_HALFWORD_UIMM (-1U);
> break;
> /* halfword immediate operators, load/store halfword
> insns. */
> case 'b': used_bits |= ENCODE_ZCB_BYTE_UIMM (-1U); break;
> + /* immediate offset operand for cm.push and cm.pop. */
> + case 'p': used_bits |= ENCODE_ZCMP_SPIMM (-1U); break;
> + /* register list operand for cm.push and cm.pop. */
> + case 'r': USE_BITS (OP_MASK_REG_LIST, OP_SH_REG_LIST);
> break;
> case 'f': break;
> default:
> goto unknown_validate_operand;
> @@ -3201,6 +3331,8 @@ riscv_ip (char *str, struct riscv_cl_insn *ip,
> expressionS *imm_expr,
> case ')':
> case '[':
> case ']':
> + case '{':
> + case '}':
> if (*asarg++ == *oparg)
> continue;
> break;
> @@ -3656,6 +3788,27 @@ riscv_ip (char *str, struct riscv_cl_insn *ip,
> expressionS *imm_expr,
> break;
> ip->insn_opcode |= ENCODE_ZCB_BYTE_UIMM
> (imm_expr->X_add_number);
> goto rvc_imm_done;
> + case 'r':
> + /* we use regno to store reglist value here. */
> + if (!reglist_lookup (&asarg, ®no))
> + break;
> + INSERT_OPERAND (REG_LIST, *ip, regno);
> + continue;
> + case 'p':
> + if (my_getSmallExpression (imm_expr, imm_reloc,
> asarg, p)
> + || imm_expr->X_op != O_constant)
> + break;
> + /* convert stack adjust of cm.push to a positive
> offset. */
> + if (ip->insn_mo->match == MATCH_CM_PUSH)
> + imm_expr->X_add_number *= -1;
> + /* subtract base stack adjust and get spimm. */
> + imm_expr->X_add_number -=
> + riscv_get_sp_base (ip->insn_opcode,
> *riscv_rps_as.xlen);
> + if (!VALID_ZCMP_SPIMM (imm_expr->X_add_number))
> + break;
> + ip->insn_opcode |=
> + ENCODE_ZCMP_SPIMM (imm_expr->X_add_number);
> + goto rvc_imm_done;
> case 'f': /* Operand for matching immediate 255. */
> if (my_getSmallExpression (imm_expr, imm_reloc,
> asarg, p)
> || imm_expr->X_op != O_constant
> diff --git a/gas/testsuite/gas/riscv/zcmp-push-pop-fail.d
> b/gas/testsuite/gas/riscv/zcmp-push-pop-fail.d
> new file mode 100644
> index 00000000000..84ecf263c54
> --- /dev/null
> +++ b/gas/testsuite/gas/riscv/zcmp-push-pop-fail.d
> @@ -0,0 +1,3 @@
> +#as: -march=rv64i_zcmp
> +#source: zcmp-push-pop-fail.s
> +#error_output: zcmp-push-pop-fail.l
> diff --git a/gas/testsuite/gas/riscv/zcmp-push-pop-fail.l
> b/gas/testsuite/gas/riscv/zcmp-push-pop-fail.l
> new file mode 100644
> index 00000000000..955e495d5bb
> --- /dev/null
> +++ b/gas/testsuite/gas/riscv/zcmp-push-pop-fail.l
> @@ -0,0 +1,9 @@
> +.*: Assembler messages:
> +.*: Error: illegal operands `cm.push \{a0\},-64'
> +.*: Error: illegal operands `cm.pop \{ra,s1\},-64'
> +.*: Error: illegal operands `cm.popret \{ra,s2-s3\},-64'
> +.*: Error: illegal operands `cm.popretz \{ra,s0-s10\},-112'
> +.*: Error: illegal operands `cm.push \{ra\},0'
> +.*: Error: illegal operands `cm.pop \{ra,s0\},-80'
> +.*: Error: illegal operands `cm.popret \{ra,s0-s1\},-15'
> +.*: Error: illegal operands `cm.popretz \{ra,s0-s11\},-165'
> diff --git a/gas/testsuite/gas/riscv/zcmp-push-pop-fail.s
> b/gas/testsuite/gas/riscv/zcmp-push-pop-fail.s
> new file mode 100644
> index 00000000000..0e8df5800dd
> --- /dev/null
> +++ b/gas/testsuite/gas/riscv/zcmp-push-pop-fail.s
> @@ -0,0 +1,13 @@
> +target:
> +
> + # reg_list
> + cm.push {a0}, -64
> + cm.pop {ra, s1}, -64
> + cm.popret {ra, s2-s3}, -64
> + cm.popretz {ra, s0-s10}, -112
> +
> + # spimm
> + cm.push {ra}, 0
> + cm.pop {ra, s0}, -80
> + cm.popret {ra, s0-s1}, -15
> + cm.popretz {ra, s0-s11}, -165
> diff --git a/gas/testsuite/gas/riscv/zcmp-push-pop.d
> b/gas/testsuite/gas/riscv/zcmp-push-pop.d
> new file mode 100644
> index 00000000000..e21295051ec
> --- /dev/null
> +++ b/gas/testsuite/gas/riscv/zcmp-push-pop.d
> @@ -0,0 +1,154 @@
> +#as: -march=rv64i_zcmp
> +#source: zcmp-push-pop.s
> +#objdump: -dr -Mno-aliases
> +
> +.*:[ ]+file format .*
> +
> +
> +Disassembly of section .text:
> +
> +0+000 <target>:
> +[ ]*[0-9a-f]+:[ ]+b84e[ ]+cm.push[ ]+\{ra\},-64
> +[ ]*[0-9a-f]+:[ ]+b85e[ ]+cm.push[ ]+\{ra,s0\},-64
> +[ ]*[0-9a-f]+:[ ]+b86a[ ]+cm.push[ ]+\{ra,s0-s1\},-64
> +[ ]*[0-9a-f]+:[ ]+b87a[ ]+cm.push[ ]+\{ra,s0-s2\},-64
> +[ ]*[0-9a-f]+:[ ]+b8da[ ]+cm.push[
> ]+\{ra,s0-s8\},-112
> +[ ]*[0-9a-f]+:[ ]+b8e6[ ]+cm.push[
> ]+\{ra,s0-s9\},-112
> +[ ]*[0-9a-f]+:[ ]+b8f2[ ]+cm.push[
> ]+\{ra,s0-s11\},-112
> +[ ]*[0-9a-f]+:[ ]+b84e[ ]+cm.push[ ]+\{ra\},-64
> +[ ]*[0-9a-f]+:[ ]+b85e[ ]+cm.push[ ]+\{ra,s0\},-64
> +[ ]*[0-9a-f]+:[ ]+b86a[ ]+cm.push[ ]+\{ra,s0-s1\},-64
> +[ ]*[0-9a-f]+:[ ]+b87a[ ]+cm.push[ ]+\{ra,s0-s2\},-64
> +[ ]*[0-9a-f]+:[ ]+b8da[ ]+cm.push[
> ]+\{ra,s0-s8\},-112
> +[ ]*[0-9a-f]+:[ ]+b8e6[ ]+cm.push[
> ]+\{ra,s0-s9\},-112
> +[ ]*[0-9a-f]+:[ ]+b8f2[ ]+cm.push[
> ]+\{ra,s0-s11},-112
> +[ ]*[0-9a-f]+:[ ]+b842[ ]+cm.push[ ]+\{ra\},-16
> +[ ]*[0-9a-f]+:[ ]+b846[ ]+cm.push[ ]+\{ra\},-32
> +[ ]*[0-9a-f]+:[ ]+b84e[ ]+cm.push[ ]+\{ra\},-64
> +[ ]*[0-9a-f]+:[ ]+b872[ ]+cm.push[ ]+\{ra,s0-s2\},-32
> +[ ]*[0-9a-f]+:[ ]+b87a[ ]+cm.push[ ]+\{ra,s0-s2\},-64
> +[ ]*[0-9a-f]+:[ ]+b87e[ ]+cm.push[ ]+\{ra,s0-s2\},-80
> +[ ]*[0-9a-f]+:[ ]+b882[ ]+cm.push[ ]+\{ra,s0-s3\},-48
> +[ ]*[0-9a-f]+:[ ]+b886[ ]+cm.push[ ]+\{ra,s0-s3\},-64
> +[ ]*[0-9a-f]+:[ ]+b88e[ ]+cm.push[ ]+\{ra,s0-s3\},-96
> +[ ]*[0-9a-f]+:[ ]+b8b2[ ]+cm.push[ ]+\{ra,s0-s6\},-64
> +[ ]*[0-9a-f]+:[ ]+b8b6[ ]+cm.push[ ]+\{ra,s0-s6\},-80
> +[ ]*[0-9a-f]+:[ ]+b8be[ ]+cm.push[
> ]+\{ra,s0-s6\},-112
> +[ ]*[0-9a-f]+:[ ]+b8c2[ ]+cm.push[ ]+\{ra,s0-s7\},-80
> +[ ]*[0-9a-f]+:[ ]+b8c6[ ]+cm.push[ ]+\{ra,s0-s7\},-96
> +[ ]*[0-9a-f]+:[ ]+b8ce[ ]+cm.push[
> ]+\{ra,s0-s7\},-128
> +[ ]*[0-9a-f]+:[ ]+b8e2[ ]+cm.push[ ]+\{ra,s0-s9\},-96
> +[ ]*[0-9a-f]+:[ ]+b8e6[ ]+cm.push[
> ]+\{ra,s0-s9\},-112
> +[ ]*[0-9a-f]+:[ ]+b8ee[ ]+cm.push[
> ]+\{ra,s0-s9\},-144
> +[ ]*[0-9a-f]+:[ ]+b8f2[ ]+cm.push[
> ]+\{ra,s0-s11\},-112
> +[ ]*[0-9a-f]+:[ ]+b8f6[ ]+cm.push[
> ]+\{ra,s0-s11\},-128
> +[ ]*[0-9a-f]+:[ ]+b8fa[ ]+cm.push[
> ]+\{ra,s0-s11\},-144
> +[ ]*[0-9a-f]+:[ ]+b8fe[ ]+cm.push[
> ]+\{ra,s0-s11\},-160
> +[ ]*[0-9a-f]+:[ ]+ba4e[ ]+cm.pop[ ]+\{ra\},64
> +[ ]*[0-9a-f]+:[ ]+ba5e[ ]+cm.pop[ ]+\{ra,s0\},64
> +[ ]*[0-9a-f]+:[ ]+ba6a[ ]+cm.pop[ ]+\{ra,s0-s1\},64
> +[ ]*[0-9a-f]+:[ ]+ba7a[ ]+cm.pop[ ]+\{ra,s0-s2\},64
> +[ ]*[0-9a-f]+:[ ]+bada[ ]+cm.pop[ ]+\{ra,s0-s8\},112
> +[ ]*[0-9a-f]+:[ ]+bae6[ ]+cm.pop[ ]+\{ra,s0-s9\},112
> +[ ]*[0-9a-f]+:[ ]+baf2[ ]+cm.pop[
> ]+\{ra,s0-s11\},112
> +[ ]*[0-9a-f]+:[ ]+ba4e[ ]+cm.pop[ ]+\{ra\},64
> +[ ]*[0-9a-f]+:[ ]+ba5e[ ]+cm.pop[ ]+\{ra,s0\},64
> +[ ]*[0-9a-f]+:[ ]+ba6a[ ]+cm.pop[ ]+\{ra,s0-s1\},64
> +[ ]*[0-9a-f]+:[ ]+ba7a[ ]+cm.pop[ ]+\{ra,s0-s2\},64
> +[ ]*[0-9a-f]+:[ ]+bada[ ]+cm.pop[ ]+\{ra,s0-s8\},112
> +[ ]*[0-9a-f]+:[ ]+bae6[ ]+cm.pop[ ]+\{ra,s0-s9\},112
> +[ ]*[0-9a-f]+:[ ]+baf2[ ]+cm.pop[ ]+\{ra,s0-s11},112
> +[ ]*[0-9a-f]+:[ ]+ba42[ ]+cm.pop[ ]+\{ra\},16
> +[ ]*[0-9a-f]+:[ ]+ba46[ ]+cm.pop[ ]+\{ra\},32
> +[ ]*[0-9a-f]+:[ ]+ba4e[ ]+cm.pop[ ]+\{ra\},64
> +[ ]*[0-9a-f]+:[ ]+ba72[ ]+cm.pop[ ]+\{ra,s0-s2\},32
> +[ ]*[0-9a-f]+:[ ]+ba7a[ ]+cm.pop[ ]+\{ra,s0-s2\},64
> +[ ]*[0-9a-f]+:[ ]+ba7e[ ]+cm.pop[ ]+\{ra,s0-s2\},80
> +[ ]*[0-9a-f]+:[ ]+ba82[ ]+cm.pop[ ]+\{ra,s0-s3\},48
> +[ ]*[0-9a-f]+:[ ]+ba86[ ]+cm.pop[ ]+\{ra,s0-s3\},64
> +[ ]*[0-9a-f]+:[ ]+ba8e[ ]+cm.pop[ ]+\{ra,s0-s3\},96
> +[ ]*[0-9a-f]+:[ ]+bab2[ ]+cm.pop[ ]+\{ra,s0-s6\},64
> +[ ]*[0-9a-f]+:[ ]+bab6[ ]+cm.pop[ ]+\{ra,s0-s6\},80
> +[ ]*[0-9a-f]+:[ ]+babe[ ]+cm.pop[ ]+\{ra,s0-s6\},112
> +[ ]*[0-9a-f]+:[ ]+bac2[ ]+cm.pop[ ]+\{ra,s0-s7\},80
> +[ ]*[0-9a-f]+:[ ]+bac6[ ]+cm.pop[ ]+\{ra,s0-s7\},96
> +[ ]*[0-9a-f]+:[ ]+bace[ ]+cm.pop[ ]+\{ra,s0-s7\},128
> +[ ]*[0-9a-f]+:[ ]+bae2[ ]+cm.pop[ ]+\{ra,s0-s9\},96
> +[ ]*[0-9a-f]+:[ ]+bae6[ ]+cm.pop[ ]+\{ra,s0-s9\},112
> +[ ]*[0-9a-f]+:[ ]+baee[ ]+cm.pop[ ]+\{ra,s0-s9\},144
> +[ ]*[0-9a-f]+:[ ]+baf2[ ]+cm.pop[
> ]+\{ra,s0-s11\},112
> +[ ]*[0-9a-f]+:[ ]+baf6[ ]+cm.pop[
> ]+\{ra,s0-s11\},128
> +[ ]*[0-9a-f]+:[ ]+bafa[ ]+cm.pop[
> ]+\{ra,s0-s11\},144
> +[ ]*[0-9a-f]+:[ ]+bafe[ ]+cm.pop[
> ]+\{ra,s0-s11\},160
> +[ ]*[0-9a-f]+:[ ]+be4e[ ]+cm.popret[ ]+\{ra\},64
> +[ ]*[0-9a-f]+:[ ]+be5e[ ]+cm.popret[ ]+\{ra,s0\},64
> +[ ]*[0-9a-f]+:[ ]+be6a[ ]+cm.popret[ ]+\{ra,s0-s1\},64
> +[ ]*[0-9a-f]+:[ ]+be7a[ ]+cm.popret[ ]+\{ra,s0-s2\},64
> +[ ]*[0-9a-f]+:[ ]+beda[ ]+cm.popret[ ]+\{ra,s0-s8\},112
> +[ ]*[0-9a-f]+:[ ]+bee6[ ]+cm.popret[ ]+\{ra,s0-s9\},112
> +[ ]*[0-9a-f]+:[ ]+bef2[ ]+cm.popret[
> ]+\{ra,s0-s11\},112
> +[ ]*[0-9a-f]+:[ ]+be4e[ ]+cm.popret[ ]+\{ra\},64
> +[ ]*[0-9a-f]+:[ ]+be5e[ ]+cm.popret[ ]+\{ra,s0\},64
> +[ ]*[0-9a-f]+:[ ]+be6a[ ]+cm.popret[ ]+\{ra,s0-s1\},64
> +[ ]*[0-9a-f]+:[ ]+be7a[ ]+cm.popret[ ]+\{ra,s0-s2\},64
> +[ ]*[0-9a-f]+:[ ]+beda[ ]+cm.popret[ ]+\{ra,s0-s8\},112
> +[ ]*[0-9a-f]+:[ ]+bee6[ ]+cm.popret[ ]+\{ra,s0-s9\},112
> +[ ]*[0-9a-f]+:[ ]+bef2[ ]+cm.popret[ ]+\{ra,s0-s11},112
> +[ ]*[0-9a-f]+:[ ]+be42[ ]+cm.popret[ ]+\{ra\},16
> +[ ]*[0-9a-f]+:[ ]+be46[ ]+cm.popret[ ]+\{ra\},32
> +[ ]*[0-9a-f]+:[ ]+be4e[ ]+cm.popret[ ]+\{ra\},64
> +[ ]*[0-9a-f]+:[ ]+be72[ ]+cm.popret[ ]+\{ra,s0-s2\},32
> +[ ]*[0-9a-f]+:[ ]+be7a[ ]+cm.popret[ ]+\{ra,s0-s2\},64
> +[ ]*[0-9a-f]+:[ ]+be7e[ ]+cm.popret[ ]+\{ra,s0-s2\},80
> +[ ]*[0-9a-f]+:[ ]+be82[ ]+cm.popret[ ]+\{ra,s0-s3\},48
> +[ ]*[0-9a-f]+:[ ]+be86[ ]+cm.popret[ ]+\{ra,s0-s3\},64
> +[ ]*[0-9a-f]+:[ ]+be8e[ ]+cm.popret[ ]+\{ra,s0-s3\},96
> +[ ]*[0-9a-f]+:[ ]+beb2[ ]+cm.popret[ ]+\{ra,s0-s6\},64
> +[ ]*[0-9a-f]+:[ ]+beb6[ ]+cm.popret[ ]+\{ra,s0-s6\},80
> +[ ]*[0-9a-f]+:[ ]+bebe[ ]+cm.popret[ ]+\{ra,s0-s6\},112
> +[ ]*[0-9a-f]+:[ ]+bec2[ ]+cm.popret[ ]+\{ra,s0-s7\},80
> +[ ]*[0-9a-f]+:[ ]+bec6[ ]+cm.popret[ ]+\{ra,s0-s7\},96
> +[ ]*[0-9a-f]+:[ ]+bece[ ]+cm.popret[ ]+\{ra,s0-s7\},128
> +[ ]*[0-9a-f]+:[ ]+bee2[ ]+cm.popret[ ]+\{ra,s0-s9\},96
> +[ ]*[0-9a-f]+:[ ]+bee6[ ]+cm.popret[ ]+\{ra,s0-s9\},112
> +[ ]*[0-9a-f]+:[ ]+beee[ ]+cm.popret[ ]+\{ra,s0-s9\},144
> +[ ]*[0-9a-f]+:[ ]+bef2[ ]+cm.popret[
> ]+\{ra,s0-s11\},112
> +[ ]*[0-9a-f]+:[ ]+bef6[ ]+cm.popret[
> ]+\{ra,s0-s11\},128
> +[ ]*[0-9a-f]+:[ ]+befa[ ]+cm.popret[
> ]+\{ra,s0-s11\},144
> +[ ]*[0-9a-f]+:[ ]+befe[ ]+cm.popret[
> ]+\{ra,s0-s11\},160
> +[ ]*[0-9a-f]+:[ ]+bc4e[ ]+cm.popretz[ ]+\{ra\},64
> +[ ]*[0-9a-f]+:[ ]+bc5e[ ]+cm.popretz[ ]+\{ra,s0\},64
> +[ ]*[0-9a-f]+:[ ]+bc6a[ ]+cm.popretz[ ]+\{ra,s0-s1\},64
> +[ ]*[0-9a-f]+:[ ]+bc7a[ ]+cm.popretz[ ]+\{ra,s0-s2\},64
> +[ ]*[0-9a-f]+:[ ]+bcda[ ]+cm.popretz[ ]+\{ra,s0-s8\},112
> +[ ]*[0-9a-f]+:[ ]+bce6[ ]+cm.popretz[ ]+\{ra,s0-s9\},112
> +[ ]*[0-9a-f]+:[ ]+bcf2[ ]+cm.popretz[
> ]+\{ra,s0-s11\},112
> +[ ]*[0-9a-f]+:[ ]+bc4e[ ]+cm.popretz[ ]+\{ra\},64
> +[ ]*[0-9a-f]+:[ ]+bc5e[ ]+cm.popretz[ ]+\{ra,s0\},64
> +[ ]*[0-9a-f]+:[ ]+bc6a[ ]+cm.popretz[ ]+\{ra,s0-s1\},64
> +[ ]*[0-9a-f]+:[ ]+bc7a[ ]+cm.popretz[ ]+\{ra,s0-s2\},64
> +[ ]*[0-9a-f]+:[ ]+bcda[ ]+cm.popretz[ ]+\{ra,s0-s8\},112
> +[ ]*[0-9a-f]+:[ ]+bce6[ ]+cm.popretz[ ]+\{ra,s0-s9\},112
> +[ ]*[0-9a-f]+:[ ]+bcf2[ ]+cm.popretz[ ]+\{ra,s0-s11},112
> +[ ]*[0-9a-f]+:[ ]+bc42[ ]+cm.popretz[ ]+\{ra\},16
> +[ ]*[0-9a-f]+:[ ]+bc46[ ]+cm.popretz[ ]+\{ra\},32
> +[ ]*[0-9a-f]+:[ ]+bc4e[ ]+cm.popretz[ ]+\{ra\},64
> +[ ]*[0-9a-f]+:[ ]+bc72[ ]+cm.popretz[ ]+\{ra,s0-s2\},32
> +[ ]*[0-9a-f]+:[ ]+bc7a[ ]+cm.popretz[ ]+\{ra,s0-s2\},64
> +[ ]*[0-9a-f]+:[ ]+bc7e[ ]+cm.popretz[ ]+\{ra,s0-s2\},80
> +[ ]*[0-9a-f]+:[ ]+bc82[ ]+cm.popretz[ ]+\{ra,s0-s3\},48
> +[ ]*[0-9a-f]+:[ ]+bc86[ ]+cm.popretz[ ]+\{ra,s0-s3\},64
> +[ ]*[0-9a-f]+:[ ]+bc8e[ ]+cm.popretz[ ]+\{ra,s0-s3\},96
> +[ ]*[0-9a-f]+:[ ]+bcb2[ ]+cm.popretz[ ]+\{ra,s0-s6\},64
> +[ ]*[0-9a-f]+:[ ]+bcb6[ ]+cm.popretz[ ]+\{ra,s0-s6\},80
> +[ ]*[0-9a-f]+:[ ]+bcbe[ ]+cm.popretz[ ]+\{ra,s0-s6\},112
> +[ ]*[0-9a-f]+:[ ]+bcc2[ ]+cm.popretz[ ]+\{ra,s0-s7\},80
> +[ ]*[0-9a-f]+:[ ]+bcc6[ ]+cm.popretz[ ]+\{ra,s0-s7\},96
> +[ ]*[0-9a-f]+:[ ]+bcce[ ]+cm.popretz[ ]+\{ra,s0-s7\},128
> +[ ]*[0-9a-f]+:[ ]+bce2[ ]+cm.popretz[ ]+\{ra,s0-s9\},96
> +[ ]*[0-9a-f]+:[ ]+bce6[ ]+cm.popretz[ ]+\{ra,s0-s9\},112
> +[ ]*[0-9a-f]+:[ ]+bcee[ ]+cm.popretz[ ]+\{ra,s0-s9\},144
> +[ ]*[0-9a-f]+:[ ]+bcf2[ ]+cm.popretz[
> ]+\{ra,s0-s11\},112
> +[ ]*[0-9a-f]+:[ ]+bcf6[ ]+cm.popretz[
> ]+\{ra,s0-s11\},128
> +[ ]*[0-9a-f]+:[ ]+bcfa[ ]+cm.popretz[
> ]+\{ra,s0-s11\},144
> +[ ]*[0-9a-f]+:[ ]+bcfe[ ]+cm.popretz[
> ]+\{ra,s0-s11\},160
> diff --git a/gas/testsuite/gas/riscv/zcmp-push-pop.s
> b/gas/testsuite/gas/riscv/zcmp-push-pop.s
> new file mode 100644
> index 00000000000..dc441bc2776
> --- /dev/null
> +++ b/gas/testsuite/gas/riscv/zcmp-push-pop.s
> @@ -0,0 +1,162 @@
> +target:
> +
> + # push
> + # abi names
> + cm.push {ra}, -64
> + cm.push {ra, s0}, -64
> + cm.push {ra, s0-s1}, -64
> + cm.push {ra, s0-s2}, -64
> + cm.push {ra, s0-s8}, -112
> + cm.push {ra, s0-s9}, -112
> + cm.push {ra, s0-s11}, -112
> + # numeric names
> + cm.push {x1}, -64
> + cm.push {x1, x8}, -64
> + cm.push {x1, x8-x9}, -64
> + cm.push {x1, x8-x9, x18}, -64
> + cm.push {x1, x8-x9, x18-x24}, -112
> + cm.push {x1, x8-x9, x18-x25}, -112
> + cm.push {x1, x8-x9, x18-x27}, -112
> + # spimm
> + cm.push {ra}, -16
> + cm.push {ra}, -32
> + cm.push {ra}, -64
> + cm.push {ra, s0-s2}, -32
> + cm.push {ra, s0-s2}, -64
> + cm.push {ra, s0-s2}, -80
> + cm.push {ra, s0-s3}, -48
> + cm.push {ra, s0-s3}, -64
> + cm.push {ra, s0-s3}, -96
> + cm.push {ra, s0-s6}, -64
> + cm.push {ra, s0-s6}, -80
> + cm.push {ra, s0-s6}, -112
> + cm.push {ra, s0-s7}, -80
> + cm.push {ra, s0-s7}, -96
> + cm.push {ra, s0-s7}, -128
> + cm.push {ra, s0-s9}, -96
> + cm.push {ra, s0-s9}, -112
> + cm.push {ra, s0-s9}, -144
> + cm.push {ra, s0-s11}, -112
> + cm.push {ra, s0-s11}, -128
> + cm.push {ra, s0-s11}, -144
> + cm.push {ra, s0-s11}, -160
> + # pop
> + # abi names
> + cm.pop {ra}, 64
> + cm.pop {ra, s0}, 64
> + cm.pop {ra, s0-s1}, 64
> + cm.pop {ra, s0-s2}, 64
> + cm.pop {ra, s0-s8}, 112
> + cm.pop {ra, s0-s9}, 112
> + cm.pop {ra, s0-s11}, 112
> + # numeric names
> + cm.pop {x1}, 64
> + cm.pop {x1, x8}, 64
> + cm.pop {x1, x8-x9}, 64
> + cm.pop {x1, x8-x9, x18}, 64
> + cm.pop {x1, x8-x9, x18-x24}, 112
> + cm.pop {x1, x8-x9, x18-x25}, 112
> + cm.pop {x1, x8-x9, x18-x27}, 112
> + # spimm
> + cm.pop {ra}, 16
> + cm.pop {ra}, 32
> + cm.pop {ra}, 64
> + cm.pop {ra, s0-s2}, 32
> + cm.pop {ra, s0-s2}, 64
> + cm.pop {ra, s0-s2}, 80
> + cm.pop {ra, s0-s3}, 48
> + cm.pop {ra, s0-s3}, 64
> + cm.pop {ra, s0-s3}, 96
> + cm.pop {ra, s0-s6}, 64
> + cm.pop {ra, s0-s6}, 80
> + cm.pop {ra, s0-s6}, 112
> + cm.pop {ra, s0-s7}, 80
> + cm.pop {ra, s0-s7}, 96
> + cm.pop {ra, s0-s7}, 128
> + cm.pop {ra, s0-s9}, 96
> + cm.pop {ra, s0-s9}, 112
> + cm.pop {ra, s0-s9}, 144
> + cm.pop {ra, s0-s11}, 112
> + cm.pop {ra, s0-s11}, 128
> + cm.pop {ra, s0-s11}, 144
> + cm.pop {ra, s0-s11}, 160
> + # popret
> + # abi names
> + cm.popret {ra}, 64
> + cm.popret {ra, s0}, 64
> + cm.popret {ra, s0-s1}, 64
> + cm.popret {ra, s0-s2}, 64
> + cm.popret {ra, s0-s8}, 112
> + cm.popret {ra, s0-s9}, 112
> + cm.popret {ra, s0-s11}, 112
> + # numeric names
> + cm.popret {x1}, 64
> + cm.popret {x1, x8}, 64
> + cm.popret {x1, x8-x9}, 64
> + cm.popret {x1, x8-x9, x18}, 64
> + cm.popret {x1, x8-x9, x18-x24}, 112
> + cm.popret {x1, x8-x9, x18-x25}, 112
> + cm.popret {x1, x8-x9, x18-x27}, 112
> + # spimm
> + cm.popret {ra}, 16
> + cm.popret {ra}, 32
> + cm.popret {ra}, 64
> + cm.popret {ra, s0-s2}, 32
> + cm.popret {ra, s0-s2}, 64
> + cm.popret {ra, s0-s2}, 80
> + cm.popret {ra, s0-s3}, 48
> + cm.popret {ra, s0-s3}, 64
> + cm.popret {ra, s0-s3}, 96
> + cm.popret {ra, s0-s6}, 64
> + cm.popret {ra, s0-s6}, 80
> + cm.popret {ra, s0-s6}, 112
> + cm.popret {ra, s0-s7}, 80
> + cm.popret {ra, s0-s7}, 96
> + cm.popret {ra, s0-s7}, 128
> + cm.popret {ra, s0-s9}, 96
> + cm.popret {ra, s0-s9}, 112
> + cm.popret {ra, s0-s9}, 144
> + cm.popret {ra, s0-s11}, 112
> + cm.popret {ra, s0-s11}, 128
> + cm.popret {ra, s0-s11}, 144
> + cm.popret {ra, s0-s11}, 160
> + # popretz
> + # abi names
> + cm.popretz {ra}, 64
> + cm.popretz {ra, s0}, 64
> + cm.popretz {ra, s0-s1}, 64
> + cm.popretz {ra, s0-s2}, 64
> + cm.popretz {ra, s0-s8}, 112
> + cm.popretz {ra, s0-s9}, 112
> + cm.popretz {ra, s0-s11}, 112
> + # numeric names
> + cm.popretz {x1}, 64
> + cm.popretz {x1, x8}, 64
> + cm.popretz {x1, x8-x9}, 64
> + cm.popretz {x1, x8-x9, x18}, 64
> + cm.popretz {x1, x8-x9, x18-x24}, 112
> + cm.popretz {x1, x8-x9, x18-x25}, 112
> + cm.popretz {x1, x8-x9, x18-x27}, 112
> + # spimm
> + cm.popretz {ra}, 16
> + cm.popretz {ra}, 32
> + cm.popretz {ra}, 64
> + cm.popretz {ra, s0-s2}, 32
> + cm.popretz {ra, s0-s2}, 64
> + cm.popretz {ra, s0-s2}, 80
> + cm.popretz {ra, s0-s3}, 48
> + cm.popretz {ra, s0-s3}, 64
> + cm.popretz {ra, s0-s3}, 96
> + cm.popretz {ra, s0-s6}, 64
> + cm.popretz {ra, s0-s6}, 80
> + cm.popretz {ra, s0-s6}, 112
> + cm.popretz {ra, s0-s7}, 80
> + cm.popretz {ra, s0-s7}, 96
> + cm.popretz {ra, s0-s7}, 128
> + cm.popretz {ra, s0-s9}, 96
> + cm.popretz {ra, s0-s9}, 112
> + cm.popretz {ra, s0-s9}, 144
> + cm.popretz {ra, s0-s11}, 112
> + cm.popretz {ra, s0-s11}, 128
> + cm.popretz {ra, s0-s11}, 144
> + cm.popretz {ra, s0-s11}, 160
> diff --git a/include/opcode/riscv-opc.h b/include/opcode/riscv-opc.h
> index e77b49a6298..d0f93b11f01 100644
> --- a/include/opcode/riscv-opc.h
> +++ b/include/opcode/riscv-opc.h
> @@ -2235,6 +2235,15 @@
> #define MASK_C_NOT 0xfc7f
> #define MATCH_C_MUL 0x9c41
> #define MASK_C_MUL 0xfc63
> +/* Zcmp instructions. */
> +#define MATCH_CM_PUSH 0xb802
> +#define MASK_CM_PUSH 0xff03
> +#define MATCH_CM_POP 0xba02
> +#define MASK_CM_POP 0xff03
> +#define MATCH_CM_POPRET 0xbe02
> +#define MASK_CM_POPRET 0xff03
> +#define MATCH_CM_POPRETZ 0xbc02
> +#define MASK_CM_POPRETZ 0xff03
> /* Svinval instruction. */
> #define MATCH_SINVAL_VMA 0x16000073
> #define MASK_SINVAL_VMA 0xfe007fff
> @@ -3916,6 +3925,11 @@ DECLARE_INSN(c_lhu, MATCH_C_LHU, MASK_C_LHU)
> DECLARE_INSN(c_lh, MATCH_C_LH, MASK_C_LH)
> DECLARE_INSN(c_sb, MATCH_C_SB, MASK_C_SB)
> DECLARE_INSN(c_sh, MATCH_C_SH, MASK_C_SH)
> +/* Zcmp instructions. */
> +DECLARE_INSN(cm_push, MATCH_CM_PUSH, MASK_CM_PUSH)
> +DECLARE_INSN(cm_pop, MATCH_CM_POP, MASK_CM_POP)
> +DECLARE_INSN(cm_popret, MATCH_CM_POPRET, MASK_CM_POPRET)
> +DECLARE_INSN(cm_popretz, MATCH_CM_POPRETZ, MASK_CM_POPRETZ)
> /* Vendor-specific (T-Head) XTheadBa instructions. */
> DECLARE_INSN(th_addsl, MATCH_TH_ADDSL, MASK_TH_ADDSL)
> /* Vendor-specific (T-Head) XTheadBb instructions. */
> diff --git a/include/opcode/riscv.h b/include/opcode/riscv.h
> index adea7dbc794..40cc2494eac 100644
> --- a/include/opcode/riscv.h
> +++ b/include/opcode/riscv.h
> @@ -112,6 +112,8 @@ static inline unsigned int riscv_insn_length (insn_t
> insn)
> (RV_X(x, 6, 1) | (RV_X(x, 5, 1) << 1))
> #define EXTRACT_ZCB_HALFWORD_UIMM(x) \
> (RV_X(x, 5, 1) << 1)
> +#define EXTRACT_ZCMP_SPIMM(x) \
> + (RV_X(x, 2, 2) << 4)
> /* Vendor-specific (CORE-V) extract macros. */
> #define EXTRACT_CV_IS2_UIMM5(x) \
> (RV_X(x, 20, 5))
> @@ -168,6 +170,8 @@ static inline unsigned int riscv_insn_length (insn_t
> insn)
> ((RV_X(x, 0, 1) << 6) | (RV_X(x, 1, 1) << 5))
> #define ENCODE_ZCB_HALFWORD_UIMM(x) \
> (RV_X(x, 1, 1) << 5)
> +#define ENCODE_ZCMP_SPIMM(x) \
> + (RV_X(x, 4, 2) << 2)
> /* Vendor-specific (CORE-V) encode macros. */
> #define ENCODE_CV_IS2_UIMM5(x) \
> (RV_X(x, 0, 5) << 20)
> @@ -200,6 +204,7 @@ static inline unsigned int riscv_insn_length (insn_t
> insn)
> #define VALID_RVV_VC_IMM(x) (EXTRACT_RVV_VC_IMM(ENCODE_RVV_VC_IMM(x)) ==
> (x))
> #define VALID_ZCB_BYTE_UIMM(x)
> (EXTRACT_ZCB_BYTE_UIMM(ENCODE_ZCB_BYTE_UIMM(x)) == (x))
> #define VALID_ZCB_HALFWORD_UIMM(x)
> (EXTRACT_ZCB_HALFWORD_UIMM(ENCODE_ZCB_HALFWORD_UIMM(x)) == (x))
> +#define VALID_ZCMP_SPIMM(x) (EXTRACT_ZCMP_SPIMM(ENCODE_ZCMP_SPIMM(x)) ==
> (x))
>
> #define RISCV_RTYPE(insn, rd, rs1, rs2) \
> ((MATCH_ ## insn) | ((rd) << OP_SH_RD) | ((rs1) << OP_SH_RS1) | ((rs2)
> << OP_SH_RS2))
> @@ -337,6 +342,11 @@ static inline unsigned int riscv_insn_length (insn_t
> insn)
> #define OP_MASK_XTHEADVTYPE_RES 0xf
> #define OP_SH_XTHEADVTYPE_RES 7
>
> +/* Zc fields. */
> +#define OP_MASK_REG_LIST 0xf
> +#define OP_SH_REG_LIST 4
> +#define ZCMP_SP_ALIGNMENT 16
> +
> #define NVECR 32
> #define NVECM 1
>
> @@ -355,6 +365,11 @@ static inline unsigned int riscv_insn_length (insn_t
> insn)
> #define X_T0 5
> #define X_T1 6
> #define X_T2 7
> +#define X_S0 8
> +#define X_S1 9
> +#define X_S2 18
> +#define X_S10 26
> +#define X_S11 27
> #define X_T3 28
>
> #define NGPR 32
> @@ -464,6 +479,7 @@ enum riscv_insn_class
> INSN_CLASS_ZCB_AND_ZBA,
> INSN_CLASS_ZCB_AND_ZBB,
> INSN_CLASS_ZCB_AND_ZMMUL,
> + INSN_CLASS_ZCMP,
> INSN_CLASS_SVINVAL,
> INSN_CLASS_ZICBOM,
> INSN_CLASS_ZICBOP,
> @@ -582,6 +598,19 @@ enum
> M_NUM_MACROS
> };
>
> +/* get sp base adjustment */
> +
> +static inline unsigned int
> +riscv_get_sp_base (insn_t opcode, unsigned int xlen)
> +{
> + unsigned reg_size = xlen / 8;
> + unsigned reg_list = EXTRACT_BITS (opcode, OP_MASK_REG_LIST,
> OP_SH_REG_LIST);
> +
> + unsigned min_sp_adj = (reg_list - 3) * reg_size + (reg_list == 15 ?
> reg_size : 0);
> + return ((min_sp_adj / ZCMP_SP_ALIGNMENT) + (min_sp_adj %
> ZCMP_SP_ALIGNMENT != 0))
> + * ZCMP_SP_ALIGNMENT;
> +}
>
I moved this to opcodes/riscv-opc.c, since there should be the most
suitable place to define a function that can be used by assembler and
dis-assembler.
Thanks
Nelson
> /* The mapping symbol states. */
> enum riscv_seg_mstate
> {
> diff --git a/opcodes/riscv-dis.c b/opcodes/riscv-dis.c
> index 3019b9a5130..8de03f7d399 100644
> --- a/opcodes/riscv-dis.c
> +++ b/opcodes/riscv-dis.c
> @@ -75,7 +75,6 @@ static const char (*riscv_fpr_names)[NRC];
> /* If set, disassemble as most general instruction. */
> static bool no_aliases = false;
>
> -
> /* Set default RISC-V disassembler options. */
>
> static void
> @@ -215,6 +214,51 @@ maybe_print_address (struct riscv_private_data *pd,
> int base_reg, int offset,
> pd->print_addr = (bfd_vma)(uint32_t)pd->print_addr;
> }
>
> +/* Get Zcmp reg_list field. */
> +
> +static void
> +print_reg_list (disassemble_info *info, insn_t l)
> +{
> + bool numeric = riscv_gpr_names == riscv_gpr_names_numeric;
> + unsigned reg_list = (int)EXTRACT_OPERAND (REG_LIST, l);
> + unsigned r_start = numeric ? X_S2 : X_S0;
> + info->fprintf_func (info->stream, "%s", riscv_gpr_names[X_RA]);
> +
> + if (reg_list == 5)
> + info->fprintf_func (info->stream, ",%s", riscv_gpr_names[X_S0]);
> + else if (reg_list == 6 || (numeric && reg_list > 6))
> + info->fprintf_func (info->stream, ",%s-%s",
> + riscv_gpr_names[X_S0],
> + riscv_gpr_names[X_S1]);
> +
> + if (reg_list == 15)
> + info->fprintf_func (info->stream, ",%s-%s",
> + riscv_gpr_names[r_start],
> + riscv_gpr_names[X_S11]);
> + else if (reg_list == 7 && numeric)
> + info->fprintf_func (info->stream, ",%s",
> + riscv_gpr_names[X_S2]);
> + else if (reg_list > 6)
> + info->fprintf_func (info->stream, ",%s-%s",
> + riscv_gpr_names[r_start],
> + riscv_gpr_names[reg_list + 11]);
> +}
> +
> +/* Get Zcmp sp adjustment immediate. */
> +
> +static int
> +riscv_get_spimm (insn_t l)
> +{
> + int spimm = riscv_get_sp_base(l, *riscv_rps_dis.xlen);
> +
> + spimm += EXTRACT_ZCMP_SPIMM (l);
> +
> + if (((l ^ MATCH_CM_PUSH) & MASK_CM_PUSH) == 0)
> + spimm *= -1;
> +
> + return spimm;
> +}
> +
> /* Print insn arguments for 32/64-bit code. */
>
> static void
> @@ -420,6 +464,8 @@ print_insn_args (const char *oparg, insn_t l, bfd_vma
> pc, disassemble_info *info
> case ')':
> case '[':
> case ']':
> + case '{':
> + case '}':
> print (info->stream, dis_style_text, "%c", *oparg);
> break;
>
> @@ -634,6 +680,13 @@ print_insn_args (const char *oparg, insn_t l, bfd_vma
> pc, disassemble_info *info
> print (info->stream, dis_style_immediate, "%d",
> (int)EXTRACT_ZCB_HALFWORD_UIMM (l));
> break;
> + case 'r':
> + print_reg_list (info, l);
> + break;
> + case 'p':
> + print (info->stream, dis_style_immediate, "%d",
> + riscv_get_spimm (l));
> + break;
> default:
> goto undefined_modifier;
> }
> diff --git a/opcodes/riscv-opc.c b/opcodes/riscv-opc.c
> index fdd05ac75dc..3da75db6db1 100644
> --- a/opcodes/riscv-opc.c
> +++ b/opcodes/riscv-opc.c
> @@ -1993,6 +1993,12 @@ const struct riscv_opcode riscv_opcodes[] =
> {"c.zext.b", 0, INSN_CLASS_ZCB, "Cs", MATCH_C_ZEXT_B, MASK_C_ZEXT_B,
> match_opcode, 0 },
> {"c.sext.w", 64, INSN_CLASS_ZCB, "d", MATCH_C_ADDIW,
> MASK_C_ADDIW|MASK_RVC_IMM, match_rd_nonzero, INSN_ALIAS },
>
> +/* Zcmp instructions. */
> +{"cm.push", 0, INSN_CLASS_ZCMP, "{Wcr},Wcp", MATCH_CM_PUSH,
> MASK_CM_PUSH, match_opcode, 0 },
> +{"cm.pop", 0, INSN_CLASS_ZCMP, "{Wcr},Wcp", MATCH_CM_POP,
> MASK_CM_POP, match_opcode, 0 },
> +{"cm.popret", 0, INSN_CLASS_ZCMP, "{Wcr},Wcp", MATCH_CM_POPRET,
> MASK_CM_POPRET, match_opcode, 0 },
> +{"cm.popretz", 0, INSN_CLASS_ZCMP, "{Wcr},Wcp", MATCH_CM_POPRETZ,
> MASK_CM_POPRETZ, match_opcode, 0 },
> +
> /* Supervisor instructions. */
> {"csrr", 0, INSN_CLASS_ZICSR, "d,E", MATCH_CSRRS,
> MASK_CSRRS|MASK_RS1, match_opcode, INSN_ALIAS },
> {"csrwi", 0, INSN_CLASS_ZICSR, "E,Z", MATCH_CSRRWI,
> MASK_CSRRWI|MASK_RD, match_opcode, INSN_ALIAS },
> --
> 2.25.1
>
>
prev parent reply other threads:[~2024-04-09 8:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 3:48 Jiawei
2024-04-09 8:48 ` Nelson Chu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPpQWtAn5icGK-Ms_5=qfGx6qYBh9M2sRwOOenoOdC-7xn7FSg@mail.gmail.com' \
--to=nelson@rivosinc.com \
--cc=binutils@sourceware.org \
--cc=charlie.keaney@embecosm.com \
--cc=chenyixuan@iscas.ac.cn \
--cc=christoph.muellner@vrull.eu \
--cc=fujin.zhao@foxmail.com \
--cc=gaofei@eswincomputing.com \
--cc=jbeulich@suse.com \
--cc=jeremy.bennett@embecosm.com \
--cc=jiawei@iscas.ac.cn \
--cc=kito.cheng@sifive.com \
--cc=mary.bennett@embecosm.com \
--cc=nandni.jamnadas@embecosm.com \
--cc=palmer@dabbelt.com \
--cc=research_trasio@irq.a4lg.com \
--cc=shihua@iscas.ac.cn \
--cc=shiyulong@iscas.ac.cn \
--cc=simon.cook@embecosm.com \
--cc=sinan.lin@linux.alibaba.com \
--cc=wuwei2016@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).