From: Nelson Chu <nelson@rivosinc.com>
To: Palmer Dabbelt <palmer@dabbelt.com>
Cc: aburgess@redhat.com, binutils@sourceware.org,
research_trasio@irq.a4lg.com, kito.cheng@sifive.com
Subject: Re: [PATCH v2 0/6] RISC-V: Fix disassembler types and styles
Date: Tue, 4 Oct 2022 09:41:01 +0800 [thread overview]
Message-ID: <CAPpQWtApJmKn3EBei7yUKz38Xs=xBt7tnXYU2s2zV+dNLxWVHA@mail.gmail.com> (raw)
In-Reply-To: <mhng-639730c6-6a67-4076-bd5f-35b0f7fd7899@palmer-ri-x1c9>
On Tue, Oct 4, 2022 at 1:40 AM Palmer Dabbelt <palmer@dabbelt.com> wrote:
>
> On Mon, 03 Oct 2022 02:59:18 PDT (-0700), aburgess@redhat.com wrote:
> > Tsukasa OI via Binutils <binutils@sourceware.org> writes:
> >
> >> Hello,
> >>
> >> This patchset fixes various typing and styling errors on the RISC-V
> >> disassembler.
> >
> > I can't approve binutils patches.
> >
> > I've taken a look through this series, and other than the minor typo I
> > spotted, this all looks good to me.
>
> My worry with these things is that it's sort of a grey area in terms of
> what our stable user interface is: there's definitely folks who try and
> parse the text output of tools like objdump and changing anything risks
> breaking that.
I have the same worry, but we probably won't hear someone really yell
until the next release. However I am not the maintainer and user of
these analysis tools either, so I cannot say such dis-assembler
patches, including the patch to sort the opcode table, will definitely
break something. But being too conservative does make development
slower, even if stable things should still have a chance to be
improved, so I struggle every time when I see these kinds of patches.
What I can only say is that - if you think these kinds of things may
be helpful to someone, and have not only one maintainer or experts say
these are probably fine, then we can try to commit the patches after a
while, if there are not any objections.
Nelson
> IMO that's too strict of a stable interface to keep
> around as it pretty much prevents us from fixing any disassembly
> weirdness, but I'm not sure if that's what other ports do and I don't
> want to make a mess by breaking users' expectations here.
>
> That said, as far as I can tell the only user-visible change here is to
> print some bits with the correct syntax coloring in GDB. Seems pretty
> straight-forward to say anything users can't rely on parsing syntax
> highlighting colors being a stable interface, so maybe we can just punt
> on the grey area for now ;)
>
> Yep. These LGTM, but I'm still kind of buried thanks to the
> a few weeks of conference->COVID. They're probably fine, but hopefully
> Nelson has the time to chime in -- if not I'll leave them in the queue.
next prev parent reply other threads:[~2022-10-04 1:41 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 13:40 [PATCH] RISC-V: fix printf types on riscv-dis.c Tsukasa OI
2022-08-03 4:27 ` [PATCH 0/4] RISC-V: Fix disassembler types and styles Tsukasa OI
2022-08-03 4:27 ` [PATCH 1/4] RISC-V: Fix immediates to have `immediate' style Tsukasa OI
2022-08-10 11:16 ` Andrew Burgess
2022-08-10 13:48 ` Tsukasa OI
2022-08-03 4:27 ` [PATCH 2/4] RISC-V: Fix printf argument types corresponding %x Tsukasa OI
2022-08-03 4:27 ` [PATCH 3/4] RISC-V: Optimize riscv_disassemble_data printf Tsukasa OI
2022-08-03 4:27 ` [PATCH 4/4] RISC-V: Print comma and tabs as the `text' style Tsukasa OI
2022-08-10 11:20 ` Andrew Burgess
2022-08-10 13:54 ` Tsukasa OI
2022-09-26 12:26 ` [PATCH v2 0/6] RISC-V: Fix disassembler types and styles Tsukasa OI
2022-09-26 12:26 ` [PATCH v2 1/6] RISC-V: Fix immediates to have "immediate" style Tsukasa OI
2022-09-26 12:26 ` [PATCH v2 2/6] RISC-V: Fix printf argument types corresponding %x Tsukasa OI
2022-09-26 12:26 ` [PATCH v2 3/6] RISC-V: Optimize riscv_disassemble_data printf Tsukasa OI
2022-09-26 12:26 ` [PATCH v2 4/6] RISC-V: Print comma and tabs as the "text" style Tsukasa OI
2022-09-26 12:26 ` [PATCH v2 5/6] RISC-V: Fix T-Head immediate types on printing Tsukasa OI
2022-10-03 9:57 ` Andrew Burgess
2022-10-03 11:06 ` Christoph Müllner
2022-09-26 12:26 ` [PATCH v2 6/6] RISC-V: Print XTheadMemPair literal as "immediate" Tsukasa OI
2022-10-03 11:06 ` Christoph Müllner
2022-10-03 9:59 ` [PATCH v2 0/6] RISC-V: Fix disassembler types and styles Andrew Burgess
2022-10-03 17:40 ` Palmer Dabbelt
2022-10-04 1:34 ` Tsukasa OI
2022-10-04 1:41 ` Nelson Chu [this message]
2022-10-04 8:46 ` Andrew Burgess
2022-10-05 22:37 ` Palmer Dabbelt
2022-10-05 21:52 ` Jeff Law
2022-10-03 10:43 ` [PATCH v3 " Tsukasa OI
2022-10-03 10:43 ` [PATCH v3 1/6] RISC-V: Fix immediates to have "immediate" style Tsukasa OI
2022-10-03 10:44 ` [PATCH v3 2/6] RISC-V: Fix printf argument types corresponding %x Tsukasa OI
2022-10-03 10:44 ` [PATCH v3 3/6] RISC-V: Optimize riscv_disassemble_data printf Tsukasa OI
2022-10-03 10:44 ` [PATCH v3 4/6] RISC-V: Print comma and tabs as the "text" style Tsukasa OI
2022-10-03 10:44 ` [PATCH v3 5/6] RISC-V: Fix T-Head immediate types on printing Tsukasa OI
2022-10-03 10:44 ` [PATCH v3 6/6] RISC-V: Print XTheadMemPair literal as "immediate" Tsukasa OI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPpQWtApJmKn3EBei7yUKz38Xs=xBt7tnXYU2s2zV+dNLxWVHA@mail.gmail.com' \
--to=nelson@rivosinc.com \
--cc=aburgess@redhat.com \
--cc=binutils@sourceware.org \
--cc=kito.cheng@sifive.com \
--cc=palmer@dabbelt.com \
--cc=research_trasio@irq.a4lg.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).