From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x31.google.com (mail-oa1-x31.google.com [IPv6:2001:4860:4864:20::31]) by sourceware.org (Postfix) with ESMTPS id 65B683858D1E for ; Tue, 4 Oct 2022 01:41:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 65B683858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-oa1-x31.google.com with SMTP id 586e51a60fabf-127dca21a7dso14944465fac.12 for ; Mon, 03 Oct 2022 18:41:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=dPrIOo2lr36J9NQa3+dmaSINqr9kLu2lbxN+rxQ4jDI=; b=C2QbFsU059qF4NkgZpt0aviKzej49QLdwu7NDBs5/kg4WLoGRr5Rcl1D45S+/rUetg vsyl5VJKmW2FiiN9GgxLsshTWSFLe3N2tT16TUn5NZjhYN11CO9E5EaEE5OlRVX7942F J463fJwCZU1Ln8vS+vIa1yPGsh1lfxKn1PRoCVyPS0MkznCmByFMQ2Lt7dEP0Ay6EAVr e5i1EaryLdIoJh4ia0CcXCI8ZYrf7FOBua/QX4T72YJoTXoYaxhrTTdq70rlGwk/0QNQ 4oS/kd74YPPy4vssaqLLSZ5MjYJiRlaGqNiF4nG2OlbjnXTmUjSaH1DZ6yceibiWVdAQ MKsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=dPrIOo2lr36J9NQa3+dmaSINqr9kLu2lbxN+rxQ4jDI=; b=vaiRkQH7tgb3YJULndfvU89Xb3+D/+7EMr38ckxazN/lGNrw2YXOJgIEkcmrMxa7n1 /yJwp8Kcf3fq6Ox0jRpaKzhf2YiE1UrvuiJN38S2V+Iy00+Y2122GV89tLl7ynbQ+wEZ QN1bBvVn31cmgmo8NQzSMOx+BFGS50LE+1aygBHzVz7IJVWoIEmZwiW573b3EHASyui3 Q9m2ZLAx0/wmCcxC46V0/qb93v2CLuUd9FiMxGsJymf58eoSZsE3sekUyB4JticpHMZY rynlvW+scClAD0eSueFI/Mz/btzbAA3xDIhhabFK/S9661oGkSg3Lqdhec1v5Wv6uOfQ OzKQ== X-Gm-Message-State: ACrzQf26kMSYrREwm4Plks7A4nJzO3/I8ZNd0bFE2ENLbnj6DsbDHJmW seBzrEnSKtIfJAkjUyDw6jJvee6Li1kqgkESMp1nxA== X-Google-Smtp-Source: AMsMyM4kOkEOXgo4+wvfgzWT7snhDgI4lTcp4+0arT8kJv82TKKu0JnbzYmdq8sgxrvt6vrCii4V8jRdJiWKqddOkKk= X-Received: by 2002:a05:6870:507:b0:130:ae8d:db0e with SMTP id j7-20020a056870050700b00130ae8ddb0emr7062749oao.82.1664847671787; Mon, 03 Oct 2022 18:41:11 -0700 (PDT) MIME-Version: 1.0 References: <87h70lgrd5.fsf@redhat.com> In-Reply-To: From: Nelson Chu Date: Tue, 4 Oct 2022 09:41:01 +0800 Message-ID: Subject: Re: [PATCH v2 0/6] RISC-V: Fix disassembler types and styles To: Palmer Dabbelt Cc: aburgess@redhat.com, binutils@sourceware.org, research_trasio@irq.a4lg.com, kito.cheng@sifive.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Oct 4, 2022 at 1:40 AM Palmer Dabbelt wrote: > > On Mon, 03 Oct 2022 02:59:18 PDT (-0700), aburgess@redhat.com wrote: > > Tsukasa OI via Binutils writes: > > > >> Hello, > >> > >> This patchset fixes various typing and styling errors on the RISC-V > >> disassembler. > > > > I can't approve binutils patches. > > > > I've taken a look through this series, and other than the minor typo I > > spotted, this all looks good to me. > > My worry with these things is that it's sort of a grey area in terms of > what our stable user interface is: there's definitely folks who try and > parse the text output of tools like objdump and changing anything risks > breaking that. I have the same worry, but we probably won't hear someone really yell until the next release. However I am not the maintainer and user of these analysis tools either, so I cannot say such dis-assembler patches, including the patch to sort the opcode table, will definitely break something. But being too conservative does make development slower, even if stable things should still have a chance to be improved, so I struggle every time when I see these kinds of patches. What I can only say is that - if you think these kinds of things may be helpful to someone, and have not only one maintainer or experts say these are probably fine, then we can try to commit the patches after a while, if there are not any objections. Nelson > IMO that's too strict of a stable interface to keep > around as it pretty much prevents us from fixing any disassembly > weirdness, but I'm not sure if that's what other ports do and I don't > want to make a mess by breaking users' expectations here. > > That said, as far as I can tell the only user-visible change here is to > print some bits with the correct syntax coloring in GDB. Seems pretty > straight-forward to say anything users can't rely on parsing syntax > highlighting colors being a stable interface, so maybe we can just punt > on the grey area for now ;) > > Yep. These LGTM, but I'm still kind of buried thanks to the > a few weeks of conference->COVID. They're probably fine, but hopefully > Nelson has the time to chime in -- if not I'll leave them in the queue.