From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nelson@rivosinc.com>
Received: from mail-oi1-x235.google.com (mail-oi1-x235.google.com [IPv6:2607:f8b0:4864:20::235])
	by sourceware.org (Postfix) with ESMTPS id 4DF853858C39
	for <binutils@sourceware.org>; Fri, 14 Oct 2022 03:47:52 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4DF853858C39
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com
Received: by mail-oi1-x235.google.com with SMTP id n130so3852191oia.6
        for <binutils@sourceware.org>; Thu, 13 Oct 2022 20:47:52 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=rivosinc-com.20210112.gappssmtp.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=mnruhleUtlhs9XyOm7TkIbXVmL1mlzdZDhXf7KfxwWs=;
        b=vB4OT7TYjunEMgwJC5dPoP1Z1gLysG+5Z09x+UzrpC/tXxbK9sK9Ywe4jAocu9Qe6P
         oIc4f330PHERyIxPBOBbvzaJn1OFoqfFu8cErVpyaxjacJ6Jt0nrYSdHgDwZB3lDbU6o
         45h+JLX9SjmFYK7QJSY10vTWB78YAzp56BnPcNcW88BrU6zwG0nnNWk5UWLbzKFwBtpW
         aBWLwWuIDyp+Ko/KcXDrH21rAIk48SyZXJMiKQq90jeFuWJ0Fgqh2d7zQzQJOS90H1JC
         gaxCavuBaERDBpJzrckYZRWrVxb2VCfjfBoaxcEDrq18Z83GG1l+79Ep2xvEGwMv/aBB
         Q4WQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=mnruhleUtlhs9XyOm7TkIbXVmL1mlzdZDhXf7KfxwWs=;
        b=a9roTlQag5184GRyV7/FVzgLJsHi4yeUi1oddNsXzZmBK5IyjsheypzJcwXYNGDxDu
         ZGKSbv65uG0YbbocK/x5pI3OBuXUg+k6gGO2fWhBQDrxbG89Yr/8f2GT7CGlxMICvrOp
         MEKqnNqg0knfc4BimXM0uQasvhBVHa88mCFanMhrioN0DhJ3hV3s4bbSGfL3xYvh7Zzh
         j5r1LTg8V7c2YLXV1d97cs0LJjCEb9MFIpxCxf3fkPSKL+/DuYwpbubZmJIW+wc5tsSh
         WR6b402fL+McxDnUzP7OLRrDkg4mAHjiysdfruU/KBLvJm5zTsDbQ5iSLonPDEdGibZn
         pn0g==
X-Gm-Message-State: ACrzQf2+pymJXBw5ljmcNCwiXFJk4zx6zmXjFlbQG0OArA85zZ5Bu3QM
	eA/DQBdQJuwHLzC7XwoT/j5lfmhXst0b06ITW9GmjA==
X-Google-Smtp-Source: AMsMyM6jHFZ9SeSCXCxn7qtjgmoZ5P5j4v6FVq9Ygab7aJeWXYBiXqH1dn2rZd++q+HQTcddmewPW0LJNQD2ZrQqyUU=
X-Received: by 2002:a05:6808:bca:b0:350:b22b:1283 with SMTP id
 o10-20020a0568080bca00b00350b22b1283mr6403284oik.82.1665719271612; Thu, 13
 Oct 2022 20:47:51 -0700 (PDT)
MIME-Version: 1.0
References: <cover.1665203660.git.research_trasio@irq.a4lg.com>
In-Reply-To: <cover.1665203660.git.research_trasio@irq.a4lg.com>
From: Nelson Chu <nelson@rivosinc.com>
Date: Fri, 14 Oct 2022 11:47:40 +0800
Message-ID: <CAPpQWtBg0gqhyUhXyVWEH+KKGoaC83fjdyUWQ42tp0ZXNX+ztg@mail.gmail.com>
Subject: Re: [PATCH 0/5] RISC-V: Requirements for disassembler optimizations 1
 (Tidying part)
To: Tsukasa OI <research_trasio@irq.a4lg.com>
Cc: Kito Cheng <kito.cheng@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, binutils@sourceware.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <binutils.sourceware.org>

On Sat, Oct 8, 2022 at 12:34 PM Tsukasa OI <research_trasio@irq.a4lg.com> wrote:
>
> Hello,
>
> To improve the core disassembler (both for performance and feature), this
> patchset now prepares for it.
>
> This is the part 1 of (planned) 4 part patchsets.
>
> 1.  Tidying (you are here)
> 2.  Reorganization of the disassembler architecture
>     (including some small optimizations)
> 3.  Optimization 1
> 4.  Optimization 2
>
> Project:
> <https://github.com/a4lg/binutils-gdb/wiki/proj_dis_perf_improvements_1>
>
> Batch 1, Part 1 is the only hardly-functional part of the whole patchsets
> and considered non-debatable.
>
> -   Adds/fixes some comments
> -   Fixes some formatting / typing
> -   Removes/makes static some local variables
>
> Again, this is mostly a tidying patchset.
>
> Thanks,
> Tsukasa
>
>
>
>
> Tsukasa OI (5):
>   opcodes/riscv-dis.c: Tidying with comments/clarity
>   opcodes/riscv-dis.c: Tidying with spacing
>   opcodes/riscv-dis.c: Use bool type whenever possible
>   opcodes/riscv-dis.c: Make XLEN variable static
>   opcodes/riscv-dis.c: Remove last_map_state

OK, looks good.  Although I am not sure what optimization you want to
do, at least the tidy patches are always welcome and independent, so
please commit.

Thanks
Nelson

>  opcodes/riscv-dis.c | 40 +++++++++++++++++++++++++++-------------
>  1 file changed, 27 insertions(+), 13 deletions(-)
>
>
> base-commit: 4cbfd0daabd68516651ee37a19d0e24ca4789ea3
> --
> 2.34.1
>