From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2e.google.com (mail-oa1-x2e.google.com [IPv6:2001:4860:4864:20::2e]) by sourceware.org (Postfix) with ESMTPS id DF7683858C2D for ; Thu, 3 Nov 2022 13:12:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DF7683858C2D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-oa1-x2e.google.com with SMTP id 586e51a60fabf-13ae8117023so2035053fac.9 for ; Thu, 03 Nov 2022 06:12:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=VY18cgeB5ubkZBg0oLGwpeBOB5gdB6o7bETfcFJoL5E=; b=2AfD0bEfDvCfHxPEkzoZbVNc9Ehqnv7WWu8tUCMvWjkJIz11mC/tiIoJL8YOeWKUop AwrZ42u89JtMhN/vyL1YKoz3+E5atydXmc0WQ3C47v01lLbQPwJ00e+4AfiLMr6aq8hi ps46io2D5La0Rse0Ny2A3ntW9GuyAgrSDzYHnKZZedzFLyRCmlinxpXp4ZH42lmFhHHI BFtrO/jVLuA2rkqS7LPeXX26LkrfhmcCiCNicDZBW3HvuSRbJ6hAdFYAoyq9gLZXWbMy dhAK45soB7uQAr9ujyAQ1LnBkg/3/ufLUPEE5naBNBwZPzSRHCniRJl9c3TmJnLVaHJT 5auw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VY18cgeB5ubkZBg0oLGwpeBOB5gdB6o7bETfcFJoL5E=; b=QWlZNp46e42eGZ/gPjuGyWCQWoNXYy+eNYmqTZFJfrybs2+qyXVKgEPCk24HHASajo M0bkbN7i/Pq710ZADbUG+hvsmxa5gCOYm+O3uneHlegC/KyxQDq5vNIlERNNq2VlzWeF Uduk7M6C7Pat2UlsuTp/HcCFxcts5dTOHsm8FByPjE4HGcMwTtmybPLNSDXoVmJ+7KTA +xG1btnjW1iuIIbW1Q+23xrAY0KfIRMF8N9NNe60TlSBzh0HWiunJypSPrHGsc/PkhUQ aut+eGiLFQtodNx/7hYZI2NuZESF2RqQXwCaHb47GnlbXgg2yH50jDMzosrc7w0d2SfX v/bw== X-Gm-Message-State: ACrzQf0UX9SdkeFtpcvz/8xgzAOAdIME+RfDYYFWQbfP6PESqKqDeIAq umcNW8U5zscq9mBjH3agM/crCJIUDuOGuiUj2C4MR3keZ4CTfw== X-Google-Smtp-Source: AMsMyM6Qm99H4RCFVPzOft1tSronztwujamI6F06TKe6+yUtZ7LUvkDq+C63YeLxoUPqc26xFmsDTY7XnXm3MRz4Jw0= X-Received: by 2002:a05:6870:507:b0:130:ae8d:db0e with SMTP id j7-20020a056870050700b00130ae8ddb0emr28297377oao.82.1667481125192; Thu, 03 Nov 2022 06:12:05 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Nelson Chu Date: Thu, 3 Nov 2022 21:11:54 +0800 Message-ID: Subject: Re: [REVIEW ONLY 0/2] NEAR RATIFICATION RISC-V: Extensions from the RISC-V Profiles To: Tsukasa OI Cc: Kito Cheng , Palmer Dabbelt , binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Nov 3, 2022 at 8:26 PM Tsukasa OI wrote: > > Hello, > > This patchset implements all extensions from RISC-V Profiles (but not > profile itself). I'm not sure whether this patchset helps someone > implementing RISC-V Profiles but I hope so. > > Thanks, > Tsukasa > > > > > Tsukasa OI (2): > NEAR-RATIFICATION RISC-V: Add 'Ssstateen' extension and its CSRs Looks good. > NEAR-RATIFICATION RISC-V: Add platform property/capability extensions If we just need to recognize them in assembler, then it looks good. Thanks for arranging these bunch of extensions before everything gets messy... Generally, since they are frozen, we have good reason to commit them to the mainline. But if you prefer to wait until they are ratified, then that's also work to me, I believe you know when will be the best time, so please commit at that time. Thanks Nelson Nelson > bfd/elfxx-riscv.c | 38 +++++++++++++++- > gas/config/tc-riscv.c | 20 +++++---- > gas/testsuite/gas/riscv/csr-version-1p10.l | 48 ++++++++++----------- > gas/testsuite/gas/riscv/csr-version-1p11.l | 48 ++++++++++----------- > gas/testsuite/gas/riscv/csr-version-1p12.l | 48 ++++++++++----------- > gas/testsuite/gas/riscv/csr-version-1p9p1.l | 48 ++++++++++----------- > gas/testsuite/gas/riscv/csr.s | 2 +- > gas/testsuite/gas/riscv/smstateen-csr-s.d | 22 ++++++++++ > gas/testsuite/gas/riscv/ssstateen-csr.d | 22 ++++++++++ > gas/testsuite/gas/riscv/ssstateen-csr.s | 13 ++++++ > include/opcode/riscv-opc.h | 26 +++++------ > 11 files changed, 215 insertions(+), 120 deletions(-) > create mode 100644 gas/testsuite/gas/riscv/smstateen-csr-s.d > create mode 100644 gas/testsuite/gas/riscv/ssstateen-csr.d > create mode 100644 gas/testsuite/gas/riscv/ssstateen-csr.s > > > base-commit: ae1c45ead6b60ef0fd338bbeb6a4c5e5808c6e6a > -- > 2.37.2 >