From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com [IPv6:2607:f8b0:4864:20::32e]) by sourceware.org (Postfix) with ESMTPS id BA2AA3858C78 for ; Tue, 12 Dec 2023 10:34:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BA2AA3858C78 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BA2AA3858C78 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::32e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702377279; cv=none; b=clGK2rfMvywBErPWpawUV+kUXQesi/KXY0nGugJru+gLfdm9trgv02vDY3em+Hy1SYPySiLpYc56hbEQOvA8dGYLuI3Sk4p4hC8FFBjYeOi0hUynrCNOWhrbub56ZJ1S8IQYw0iJ+NJ+0V7QvSMZHgftpD2I3kk2o/tL+gQCGhI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702377279; c=relaxed/simple; bh=UHvXLgNKIr+nwePpiV6/Tjz1gVfaZaLI/+KVhFSotQU=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=ZCmvZ55secNeKzD7IVGb1k7VWHJFs1ogMeHC/0R9oMEDaHBYlj9MBEf0C9Gnz74cqUqwYwhYuz70PC3NVLFbGE2990eeVNaxjf8gMSFpe+AqLKHeHjN2EYQDlhPsrQQxSGqKbZFEMxDYiGQ1lqbsUd13H94rPWokgW6vhiGoAuk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ot1-x32e.google.com with SMTP id 46e09a7af769-6d9f7b3de20so2577056a34.2 for ; Tue, 12 Dec 2023 02:34:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1702377276; x=1702982076; darn=sourceware.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=PUbpiaSiRutnMXhFU5rP1PG4yUP/r01KNNm/h5BaPFs=; b=EQMXmrjzNWm4fCdvjuivyxX6N6BJGCefGK38/cYUugo/83nutwOu4XR7G1CMYD84wi 6XuZQ26t8FdNi1Mkv+St6A+lW+pNrp1Gs2dKTmhLTSPBvM3bP7+krwRwaPZroUhSqyxE 4uXQoKY1azTGFP7o1tllyWGh9Ox4ZP6J9D4ZWZlWAYFki1l40aDWDYR94FVAvTNql2gT Kr+wka6PzWUG1q7LWhATOu8gBVKZQ6w2n98aSYy5VIZeXSmsWfEKzsnfASQI4Ci970Kx xtwzch7q3qIlClBDKFFHGvgS8m3mwHMK4teW8Oie+l08C/dA4GzwyoyV/hVOJgfIZkGP w+pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702377276; x=1702982076; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PUbpiaSiRutnMXhFU5rP1PG4yUP/r01KNNm/h5BaPFs=; b=SxOcCN/dgB9ldAknUqgihYg+mG28nH5Wh9wx8Xh8nk1KihJfShHlDgoFOt7+Mpx/ru YMox7LnETF2ydl3DPEbCwaxQMndWY/k2q8Fl4FCMT/VUh9uucFrAWDUpkph5nmIwrXwB E+UM34A2bMHzmJmdvrEuNPjNi8tObjXmIb8XARG6MK0B3oxOVZwuic8iQ0CRv7lJJ4pA uCMHX7N2e+x3ffTu5kfjj+JEywEeOqS+BUlLnq5KOGxuy2q4MdCLHbUeNGWl18qWH61r LT0imwIERRvBcW0G0AD7IZXXxtdVSus7ko/VZh0wFi7ItAD8J0W7IWEcDgC/2OdNTXe6 PVUw== X-Gm-Message-State: AOJu0YzIc8/DhOS7drSKnIMTgD3hP+47od5NoWtk1IOmyFCvDEqWTBu8 XRp/xIB36K6i4aLACz5XfnX74lDHM6iybU/Xfr2nyS9v++mlAFOM X-Google-Smtp-Source: AGHT+IEAh3Y5jqofKmosKLd0pwzO5TexWlOpuFvuAipAB0Ms5xznSfuvO249RC5+OwMu/nDqGW0J0FrGlP9YI4dJ64A= X-Received: by 2002:a05:6870:b6a2:b0:1f9:fa57:f72a with SMTP id cy34-20020a056870b6a200b001f9fa57f72amr6584939oab.38.1702377276202; Tue, 12 Dec 2023 02:34:36 -0800 (PST) MIME-Version: 1.0 References: <87edfroi0w.fsf@redhat.com> In-Reply-To: <87edfroi0w.fsf@redhat.com> From: Nelson Chu Date: Tue, 12 Dec 2023 18:34:25 +0800 Message-ID: Subject: Re: Commit: Fix whitespace snafu in tc-riscv.c To: Nick Clifton Cc: binutils@sourceware.org Content-Type: multipart/alternative; boundary="000000000000d28255060c4d988d" X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000d28255060c4d988d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks, I didn't notice the indentation of the code here :-( Nelson On Tue, Dec 12, 2023 at 6:03=E2=80=AFPM Nick Clifton wro= te: > Hi Guys > > I am applying the patch below in order to fix this compile time > warning/error message: > > gas/config/tc-riscv.c: In function 'md_apply_fix': > gas/config/tc-riscv.c:4364:11: error: this 'if' clause does not > guard... [-Werror=3Dmisleading-indentation] > 4364 | if (!riscv_record_pcrel_fixup > (riscv_pcrel_hi_fixup_hash, > | ^~ > gas/config/tc-riscv.c:4370:13: note: ...this statement, but the latter > is misleadingly indented as if it were guarded by the 'if' > 4370 | bfd_putl32 (bfd_getl32 (buf) > | ^~~~~~~~~~ > > Cheers > Nick > > diff --git a/gas/config/tc-riscv.c b/gas/config/tc-riscv.c > index a46a6a4ec48..b902c6ba2c1 100644 > --- a/gas/config/tc-riscv.c > +++ b/gas/config/tc-riscv.c > @@ -4367,11 +4367,11 @@ md_apply_fix (fixS *fixP, valueT *valP, segT seg > ATTRIBUTE_UNUSED) > target)) > as_warn (_("too many pcrel_hi")); > > - bfd_putl32 (bfd_getl32 (buf) > - | ENCODE_UTYPE_IMM (RISCV_CONST_HIGH_PART (value)= ), > - buf); > - if (!riscv_opts.relax) > - fixP->fx_done =3D 1; > + bfd_putl32 (bfd_getl32 (buf) > + | ENCODE_UTYPE_IMM (RISCV_CONST_HIGH_PART (value)), > + buf); > + if (!riscv_opts.relax) > + fixP->fx_done =3D 1; > } > relaxable =3D true; > break; > > --000000000000d28255060c4d988d--