From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by sourceware.org (Postfix) with ESMTPS id 3926D3858D1E for ; Thu, 22 Dec 2022 02:12:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3926D3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-ej1-x633.google.com with SMTP id kw15so1702686ejc.10 for ; Wed, 21 Dec 2022 18:12:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=/dxKryk7tSzctrgNdLcnUgrknrJzPo2pKByHXgoaFZY=; b=jAAMTgAOanFyr01aNq4W7WotBvKM9Oel42EDUjfk4yTKeD0xWAPb9Ehv011AUd9OaO LZhDC0JHahXQqkm4JXIoPqsPUt4JOzWiOfrqtL07Da9fYfWLJ1u4TTrTcZhappE215bt GKn35yVaLb+fCEhQJ2gvSkIvmyz4qWw68NxAoJw6+OPANDuBGWzP+HxmCrzFmMSfM9fh EK/JL/20y4k73wnRecrt5XKkXHRkwq/Wyo0kOZoVOO07o9OQQT1nNOHWkprMMwn3rX/5 TP3kIY3NYOHFceQCEdrEURkjTE4nSDveAIwPL9P5rGPRHPOAiuabTJIAha3UHYBaR4Ou zqGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/dxKryk7tSzctrgNdLcnUgrknrJzPo2pKByHXgoaFZY=; b=tkE2J+ClIH6O4CyUxhmqbNV+H8EMhkI//IBiwBL7OyyN1fq6YPgfSAm6i9R54m51p8 msTK0bXllzrBiPqhPZ1gt+bU+G8T9ghu2rBRoU1lz9NsBEOBeJZeDCguyAKXOUJ+NJXt iAX3keraWMC49Kwubkosv5aZmMD8Svi3778EjzhiXzeiJzTOKIsdEqlhMhdDda0LTW7L Hrn0+htOmEPsLGS1/myn9Pg8z0LZZk0SCidCsO5SHh7elgbeGIppMy5rL/hUNm7JTzPK /rsliQBJlDWG4YEuNpkApJ2vjy5tP9SGcF7dQlAzCIeDGejSYdfwxPfRr+E4y12KJ2rg I+ng== X-Gm-Message-State: AFqh2kqAVI0uX7y07726hCOT0Rg1rDeM8TL2+R33sFVOYa+LvHgwc062 uMFUUjr5bxNaxFYsixD0Wev4UDrmojfb3Z/r+9Vb9Q== X-Google-Smtp-Source: AMrXdXv5dTXD0UPJINg4b7cICwLXtqa2sUggObUXoeXR++y5kl0on/RnSsVr4/51UM3i0s1dSD7yNisnKIwpbQrt6+E= X-Received: by 2002:a17:906:7fc3:b0:81d:3231:591f with SMTP id r3-20020a1709067fc300b0081d3231591fmr302184ejs.46.1671675150861; Wed, 21 Dec 2022 18:12:30 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Nelson Chu Date: Thu, 22 Dec 2022 10:12:19 +0800 Message-ID: Subject: Re: [RFC PATCH] ld/emulparams: elf32lriscv-defs: Add support tune the text segment start address To: "Lad, Prabhakar" Cc: Palmer Dabbelt , jeffreyalaw@gmail.com, i@maskray.me, prabhakar.mahadev-lad.rj@bp.renesas.com, Andrew Waterman , Jim Wilson , binutils@sourceware.org, Chris.Paterson2@renesas.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Dec 22, 2022 at 4:15 AM Lad, Prabhakar wrote: > >> I think it should be similar to what nds32 did in the >> ld/emulparams/nds32elf_linux.sh, but I'm not really sure how it works. >> When should the DEFAULT_TEXT_START_ADDR be defined? Maybe when >> configure or make, not sure about that. But at least I only see the >> changes in nds32, all of the other targets won't do that, so this must >> be a handy little trick, but there are always other ways to do the >> >DEFAULT_TEXT_START_ADDR needs to be exported in the shell before doing >configure && make.. For example for testing I bbappended the binutils >yocto recipe and exported the variable in do_configure() so that it >picks up the new offset. Thanks, that pretty clear to explain how this works. > > same things - for example, what maskray said should be the general way > > to do. I don't have any opinion on this change, if it won't break the > > general build, then probably acceptable. Just that it seems need to > > introduce the DEFAULT_TEXT_START_ADDR or whatever configure options, > > so this isn't only be the riscv gnu ld's issue, this will also be the > > issue of lld, so if the maintainers of lld already have some > > suggestions, then it will definitely worth to referring to. > > > Is there a mailing list for lld so that we could include them in this > mail thread (I couldn't find one)? Not really sure which mailing list is the right place to discuss this for llvm, I only know that they have a patch review system - Phabricator. But anyway, Maskray (Fangrui) is the lld maintainer, so he is already here ;) Thanks Nelson