From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nelson@rivosinc.com>
Received: from mail-oa1-x35.google.com (mail-oa1-x35.google.com [IPv6:2001:4860:4864:20::35])
	by sourceware.org (Postfix) with ESMTPS id C72BC3858D1E
	for <binutils@sourceware.org>; Fri, 30 Sep 2022 14:44:08 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C72BC3858D1E
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com
Received: by mail-oa1-x35.google.com with SMTP id 586e51a60fabf-11e9a7135easo5706658fac.6
        for <binutils@sourceware.org>; Fri, 30 Sep 2022 07:44:08 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=rivosinc-com.20210112.gappssmtp.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date;
        bh=Svi6DlA9jeCMUsYTF7U7JIEbedzGuITBt/RoVO+L4DQ=;
        b=dOg1eSS46+yH9nhH6HgEaoOY0NVXor3BA1GRmvBL6WjXcpk3w6crFMrcphq9gQeV6T
         h9tUl+9/cIXLjqMi8twgcUrmZrpcJFX0ctwbFS640JtYkH9Ic3BKBh2/6zEgM07KdRBV
         PRh29wGWZV5HYylH6PRV3Dxt7DjdN5qXVYxNX+PKh8j1y2OvnjjTegHYyE9tkKJ22D+4
         ttlcFx8NmLM4gK/zHgZR2Lwbq4a0gMyLSNNpjGxApPTsJ3iMqtMVZKC5Djv31hIW9D3q
         A6UoCyk+2y/JPGPFyKHhb+GTEJ/X1/o4bRwqWL6C+vQFCVSppN0ihnoICA1WP3DzpM6y
         kdRA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date;
        bh=Svi6DlA9jeCMUsYTF7U7JIEbedzGuITBt/RoVO+L4DQ=;
        b=mUgkcqS2rlI18FLMEXLkV+k0IaY+gPzp2jqDzdMJsQcr1mWPtU1kGLlrne3FwiHxAC
         kTK6+vGHtq1jRhGlwj+qRsbI/vMIpCuMO/Ci/VTTbWxM8vs5tbwLf5m4TP1vmU749j3/
         CaZYZXzn2gshxAkzuruy4aY5sWYQBjN76YeEbua3Ea2rCWF8Qnqlu7IoosfGoz5OogTs
         O8eHxedXyyf7ueuO6pbYz/3VEDnuAFnEMmsLZZ8+6LY1w40OLaO+LjkNmM55ujsXvJ42
         MESdhTTh4NGAdNa7P02BpzvCR0Vc9xd93/BjKF7MSF0xCaXV1vQcRyNGMLeR8TwIH521
         rqPQ==
X-Gm-Message-State: ACrzQf3V1+jBbO74m287BpRDrEaT0mc5M03OktjCS5yv9ZeYH5bsgdny
	i1/kVPymXyxOGq/YxZwJtmi/YwTvxf9R+ucuLGcvhA==
X-Google-Smtp-Source: AMsMyM41O5/QW2271N12xIHTwq7g/9wjQMaPEgHHHYB/E1c6kM3G6Lb/XBTg6VHXtxSj08Sk8YRKHwPUQBVRl1P/Ryk=
X-Received: by 2002:a05:6870:831f:b0:11c:dfe3:ef6d with SMTP id
 p31-20020a056870831f00b0011cdfe3ef6dmr4929704oae.107.1664549048217; Fri, 30
 Sep 2022 07:44:08 -0700 (PDT)
MIME-Version: 1.0
References: <7cb92a0b-d1ef-e3db-4773-0b6cd5183272@suse.com> <e76ef8f7-72b9-5103-cb43-9608af01d017@suse.com>
In-Reply-To: <e76ef8f7-72b9-5103-cb43-9608af01d017@suse.com>
From: Nelson Chu <nelson@rivosinc.com>
Date: Fri, 30 Sep 2022 22:43:57 +0800
Message-ID: <CAPpQWtCBtREcmeEGVG6ibPvJ=dpDSBC-bT0_6_2BAzbmD06_vw@mail.gmail.com>
Subject: Re: [PATCH] RISC-V: don't cast expressions' X_add_number to long in diagnostics
To: Jan Beulich <jbeulich@suse.com>
Cc: Binutils <binutils@sourceware.org>, Palmer Dabbelt <palmer@dabbelt.com>, 
	Andrew Waterman <andrew@sifive.com>, Jim Wilson <jim.wilson.gcc@gmail.com>, 
	=?UTF-8?Q?Christoph_M=C3=BCllner?= <christoph.muellner@vrull.eu>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <binutils.sourceware.org>

Thanks, please commit.

Nelson

On Fri, Sep 30, 2022 at 5:42 PM Jan Beulich <jbeulich@suse.com> wrote:
>
> There's no need for such workarounds anymore now that we use C99
> uniformly. This addresses several testsuite failures encountered when
> (cross-)building on a 32-bit host.
>
> --- a/gas/config/tc-riscv.c
> +++ b/gas/config/tc-riscv.c
> @@ -3338,14 +3338,14 @@ riscv_ip (char *str, struct riscv_cl_ins
>                       if (!sign)
>                         {
>                           if (!VALIDATE_U_IMM (imm_expr->X_add_number, n))
> -                           as_bad (_("improper immediate value (%lu)"),
> -                                   (unsigned long) imm_expr->X_add_number);
> +                           as_bad (_("improper immediate value (%"PRIu64")"),
> +                                   imm_expr->X_add_number);
>                         }
>                       else
>                         {
>                           if (!VALIDATE_S_IMM (imm_expr->X_add_number, n))
> -                           as_bad (_("improper immediate value (%li)"),
> -                                   (long) imm_expr->X_add_number);
> +                           as_bad (_("improper immediate value (%"PRIi64")"),
> +                                   imm_expr->X_add_number);
>                         }
>                       INSERT_IMM (n, s, *ip, imm_expr->X_add_number);
>                       imm_expr->X_op = O_absent;