From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oo1-xc30.google.com (mail-oo1-xc30.google.com [IPv6:2607:f8b0:4864:20::c30]) by sourceware.org (Postfix) with ESMTPS id 376BD385C426 for ; Fri, 18 Aug 2023 00:22:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 376BD385C426 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-oo1-xc30.google.com with SMTP id 006d021491bc7-5607cdb0959so285045eaf.2 for ; Thu, 17 Aug 2023 17:22:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20221208.gappssmtp.com; s=20221208; t=1692318174; x=1692922974; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ssm8ynh/n1o2WxJUb9aHXXD+977yHjAp9vIImbOdRqA=; b=TW013E5cDTar1X495UHpEoo3Y1svX/4ovkuviX6XhZy6Pmoda95f+mMhePpeS6DRjA f4Yl95j71I0lEVHIsyNuIgWvNoG2E8WNpaJxmTxpVZG5A8hsnyhh0Td0BAJziCq/PPup qM+3pZ7rEBeKByzjNGjvNsQEto9Beo1Sv6lU/6wD4SvRIquwpGP4mdh2HJ2LczXdSfMo wUMgDDscl09RO8PNSIzojm+zEOM2VMwRq0gpbCJtMvgGp4cNsYlg5rGbnIcsPWOi02mW TDwYx1Z/2UXICtS9J3yhidWzD8RXWQbbrZM4a2sNufubhMCmT6/42B2yVb1nBtA2p96y h1NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692318174; x=1692922974; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ssm8ynh/n1o2WxJUb9aHXXD+977yHjAp9vIImbOdRqA=; b=TDgWqLmjy3cu6Ki4QB6TFoPBo/ZmRaAEavA7cuNEQ2wOhftYzTUA54lCVad5gB9MsW aRG9kWtgZH7FwWfU4yoJpP9G/mL1ov0pq2IEh9p01lqj80nKh3kwAVj8uC5VL+jtUzLj Ncpc63NbUR3JdMQyw2HFumcoK9y0j4NKkp60RJumacVrzOsEpZHus9J8CO2sObfBQ5Os BWFK66t7CAj3Je/5a1UHnbJ/RDGtpTKN86aIm0H27smxvF0pRuImG6hwbo0M/ZegdYKk Sc9RV6pPQl8Lfy6b8MaQncewlxqiqDFf/fPEQBuqeQfxxjJGLxW1gRzL6LubBB9Vd1YR rYcg== X-Gm-Message-State: AOJu0YyZjGW/S+p/zH1XLhpigO1JrXjvRgXpFXhPwVv+rCu1cjzSLbQD dySgxfZPRB+C3S40CHLroqokDn/iJtYweKOHxrFA/A== X-Google-Smtp-Source: AGHT+IEhg3uiDGwOGcv91AWrmLf6RGCFo8lQMFRz3zzll28PtMm0NiHcDb8ezGzJJIAn8KtoSGDqCDM261QUlkGSK/g= X-Received: by 2002:a4a:908a:0:b0:56e:5a8e:654b with SMTP id j10-20020a4a908a000000b0056e5a8e654bmr1220579oog.3.1692318174358; Thu, 17 Aug 2023 17:22:54 -0700 (PDT) MIME-Version: 1.0 References: <20230817180852.121628-2-ishitatsuyuki@gmail.com> In-Reply-To: <20230817180852.121628-2-ishitatsuyuki@gmail.com> From: Nelson Chu Date: Fri, 18 Aug 2023 08:22:43 +0800 Message-ID: Subject: Re: [PATCH 0/4] RISC-V: Implement TLS Descriptors. To: Tatsuyuki Ishi Cc: binutils@sourceware.org, rui314@gmail.com, ruiu@bluewhale.systems Content-Type: multipart/alternative; boundary="000000000000a14a0806032787d7" X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000a14a0806032787d7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Before the reviewing, I think you still should have test cases for each patch to make sure everything is correct in the binutils, and helps people understand what the patches try to resolve what problem or support what features. In general, the regressions in binutils, gcc and glibc are seperate. Besides, each patch should at least have the ChangLogs in the commit message. Thanks Nelson On Fri, Aug 18, 2023 at 2:10=E2=80=AFAM Tatsuyuki Ishi via Binutils < binutils@sourceware.org> wrote: > This patchset implements TLS Descriptors (TLSDESC) for RISC-V targets, per > the specification draft at [1]. > > This patchset is based on top of [2]. > > No regression in binutils and gcc tests for rv64gc, tested alongside the > gcc and glibc implementation (will be posted shortly). > > This contribution is made on behalf of Blue Whale Systems, which has > copyright assignment on file with the FSF. > > [1]: https://github.com/riscv-non-isa/riscv-elf-psabi-doc/pull/373 > [2]: https://sourceware.org/pipermail/binutils/2023-August/129075.html > > Tatsuyuki Ishi (4): > RISC-V: Add TLSDESC reloc definitions. > RISC-V: Add assembly support for TLSDESC. > RISC-V: Define and use GOT entry size constants for TLS. > RISC-V: Initial ld.bfd support for TLSDESC. > > bfd/bfd-in2.h | 4 + > bfd/elfnn-riscv.c | 105 ++++++++++++++++++--- > bfd/elfxx-riscv.c | 75 ++++++++++++++- > bfd/libbfd.h | 4 + > bfd/reloc.c | 8 ++ > gas/config/tc-riscv.c | 18 +++- > include/elf/riscv.h | 5 + > > ld/testsuite/ld-riscv-elf/ld-riscv-elf.exp | 2 + > This doesn't work, seems still not adding any test cases. > opcodes/riscv-opc.c | 1 + > 9 files changed, 201 insertions(+), 21 deletions(-) > > -- > 2.41.0 > > --000000000000a14a0806032787d7--