From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x44.google.com (mail-oa1-x44.google.com [IPv6:2001:4860:4864:20::44]) by sourceware.org (Postfix) with ESMTPS id 8CD843858C74 for ; Fri, 26 Aug 2022 09:53:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8CD843858C74 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-oa1-x44.google.com with SMTP id 586e51a60fabf-11c59785966so1397621fac.11 for ; Fri, 26 Aug 2022 02:53:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc; bh=Ym/r10Vdu+b8qMv4qdatKbh7PrsN1Qckua1W3d6IZqI=; b=IT+9+3eTDTZ6ossf0c6Dv4MxuLGpJL9yFjbQGlu6rRntEI97kPqKgZRr4fVqBgTYkt 1CIxhvHq+l5+GSby+KdUVOOSALXGsSVkJb25XgOofV559L7AIGfb+i7D9R2Ja82Kk9Ob TxMc+C0ZYV3uCbLUJTTMQeK438VcPjN/zO/vzEzCwgtpQ6ygyOWVvErOYSpdnO6RQ20i nbiamFqcTaSJ4IelTua6X1alnn8NlzoWXUh9gfVVN528EMkl7XLFCDfLlGzAkUUn/uLn /YEsZP+vYfaYDdjM3HAdSBlvRgedzch+w8Pj2LhkUMtHdFQ650J/d5DTOvwuwkH2E0KL DRWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc; bh=Ym/r10Vdu+b8qMv4qdatKbh7PrsN1Qckua1W3d6IZqI=; b=ni4rjooTifnGtM3rq3dRk5CiKsct8hOVZ4URIK2hsMfWxFQli39tT4Ch1ekntbBULZ 4KVMJiYRANZ1mIcCzJ0PBZee1Dkd+eXd9hi0a28lbn/K9+NJaw3EXQhbMBWZ+ag2IKCE mesty/vZCEQNNisQHqr3wFQ8gSjjhxR4elhsCF6j5UfrFhBCpYz+kL+qsoRU9LBJcl3v 9Il+ijUW72czuaYNqDhpy30V4bsxCo+9KPUDcojBrkXP9pf5D9VZJa3RNLzJ2u7fwwev hdFRRShZIDaJgfBvciY45pRXXsMq3KezjFYVVFphhjBTrd08Z4udLarP0a/xqN0aR3Ip Hy1Q== X-Gm-Message-State: ACgBeo3E1sOKsjmd7q28cfSPZ32y1nwou9DAuPQqLovJnGdX1t3caUGE B/pcxlXk58RSCyUMMHBHvcoWIyGj+/1LxP7ONhMxnQ== X-Google-Smtp-Source: AA6agR4nwueS1p/l7SiIzVaa9k9V16rKnX+6meDkZg4NNY5ThKD2vekDqxBYNa2andTGi3jo7TrgEnOeST1O6yf40+s= X-Received: by 2002:a05:6870:831f:b0:11c:dfe3:ef6d with SMTP id p31-20020a056870831f00b0011cdfe3ef6dmr1356373oae.107.1661507619011; Fri, 26 Aug 2022 02:53:39 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Nelson Chu Date: Fri, 26 Aug 2022 17:53:28 +0800 Message-ID: Subject: Re: [PATCH] riscv: Add AIA extension support (Smaia, Ssaia) To: =?UTF-8?Q?Christoph_M=C3=BCllner?= Cc: Palmer Dabbelt , binutils@sourceware.org, kito.cheng@sifive.com, Jim Wilson , philipp.tomsich@vrull.eu, apatel@ventanamicro.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Aug 26, 2022 at 3:11 AM Christoph M=C3=BCllner wrote: > > This patch needs a v2 anyway because I missed the Hypervisor and VS CSRs. Yeah, reviewed in advance, except the missing Hypervisor AIA CSRs and the spec frozen issue which mentioned by Palmer, otherwise LGTM. Just curious that will we add something like "Shaia" or "Zhaia" for the Hypervisor and VS AIA CSRs? If no, then seems like they will belong to the single h extension directly? Anyway, this patch just support Ssaia and Smaia extensions, so missing the hypervisor and VS AIA CSRs seems reasonable... Anyway, all of us agree to wait for the AIA spec frozen before merging, so I think you can just merge this after that time, since the Ssaia and Smaia don't include the Hypervisor AIA in fact... > > >> @@ -947,7 +956,12 @@ riscv_csr_address (const char *csr_name, > > >> || csr_class =3D=3D CSR_CLASS_SMSTATEEN_AND_H_= 32); > > >> extension =3D "smstateen"; > > >> break; > > >> - case CSR_CLASS_SSCOFPMF_32: > > >> + case CSR_CLASS_SSAIA: > > >> + case CSR_CLASS_SSAIA_32: > > >> + is_rv32_only =3D (csr_class =3D=3D CSR_CLASS_SSAIA_32); > > >> + extension =3D "ssaia"; > > >> + break; > > >> + case CSR_CLASS_SSCOFPMF_32: Here should be a minor indent issue. Thanks Nelson