From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=05Ph=6Q=rivosinc.com=nelson@sourceware.org>
Received: from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com [IPv6:2607:f8b0:4864:20::22a])
	by sourceware.org (Postfix) with ESMTPS id D96433858CDB
	for <binutils@sourceware.org>; Mon, 20 Feb 2023 10:13:18 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D96433858CDB
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com
Received: by mail-oi1-x22a.google.com with SMTP id bb6so619813oib.11
        for <binutils@sourceware.org>; Mon, 20 Feb 2023 02:13:18 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=rivosinc-com.20210112.gappssmtp.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=yDnE6Qn/LgSQR0WCXU2Rk4WtwLYrEzYVP+7Ay6/vHQY=;
        b=fatKN0eyRQpMY710cHnge9EGCYpcTb7MM2pcVhXbkMAmxOe1jrkeP4LW74f5nXZ13v
         aq1tCe+k/e04Dm/23GAqB3mQBM/wUpvDWZ/G5pH93jPdtSjBbgNaVZTzqeveZtUrTEo5
         SC8aOFha5vYMGxRW1inC5NEgZ1X4dLO1BJC98iHZBbVf3PUpNw8Y7wxZJCrw61rdefKr
         tTCVJvpGCsAmC8Q5i1r0XDnGbBVH7pE05OeBXNOMu/9RhMHBLcVFZFrXDadTn+tzF/Dp
         rX1sUwYICq5Zb/FMUusf2eCD4CXJ/LTDyXwlSetIByeS7tNP9OxyoqgRrPUwcbIqeuLS
         kW1g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=yDnE6Qn/LgSQR0WCXU2Rk4WtwLYrEzYVP+7Ay6/vHQY=;
        b=Hd1R4ELJAyPU38zDeMq0T67yyaeGocv0I/5DzugYxokauha5CYqkKPUD19NigA3Ivr
         a7OahQJc7GIQII1pKj6fkGqJb0TczSJUJJK3JmEZaJV0tYG8bLb1xHtxlCwP7C7LySc6
         F58zAkCw1143ZFFDOvw3iZCp0q9r2GbWzxnyPyMnXQwOPnPttjYey+wNm088TAZx5Qk2
         9VqmjJjUFQq84huafCPy3Y/9pesLhTaEQ+RvcMAr7I5iWTvCriXOid2Pg8Dg/fbOMBQ+
         TCv10kvhcfpnAZKaLChQDZWgaPf8VQXeN7eEGg2RPgPDzm8TIqAVYqOT6BkSDei/R6Wb
         3bjQ==
X-Gm-Message-State: AO0yUKWgpTqDt5qLTHp6HIi5IIA4N+AbBBLzOdNaglkmmHWat4ZocsKt
	kqMsNd8RNm9pndZJctQZQFnAlKD+k0b1eCewsYFvT6UZPYhQj4f9
X-Google-Smtp-Source: AK7set/sIG6iOA8TEHrwrdyAvrOI6klOHntff+eYN0cppIoaSAR0PO1vGFB3sfVMhc0bMvS53rDjDbH3GLvVvGf5Q0s=
X-Received: by 2002:a05:6870:c44:b0:163:6aa8:615e with SMTP id
 lf4-20020a0568700c4400b001636aa8615emr343953oab.170.1676861181357; Sun, 19
 Feb 2023 18:46:21 -0800 (PST)
MIME-Version: 1.0
References: <f055cbdb-e706-3a74-ab63-725ed8a047fd@suse.com>
In-Reply-To: <f055cbdb-e706-3a74-ab63-725ed8a047fd@suse.com>
From: Nelson Chu <nelson@rivosinc.com>
Date: Mon, 20 Feb 2023 10:46:10 +0800
Message-ID: <CAPpQWtCn=Le5-s5PLBRaHVBcbbee4FELir5Wtzp4aFfSrv=_mg@mail.gmail.com>
Subject: Re: [PATCH] RISC-V: as_warn() already emits a newline
To: Jan Beulich <jbeulich@suse.com>
Cc: Binutils <binutils@sourceware.org>, Palmer Dabbelt <palmer@dabbelt.com>, 
	Andrew Waterman <andrew@sifive.com>, Jim Wilson <jim.wilson.gcc@gmail.com>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DATE_IN_PAST_06_12,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <binutils.sourceware.org>

OK, thanks for fixing this.

Nelson

On Thu, Feb 16, 2023 at 4:56 PM Jan Beulich <jbeulich@suse.com> wrote:
>
> Therefore there shouldn't be any at the end of the format string.
>
> --- a/gas/config/tc-riscv.c
> +++ b/gas/config/tc-riscv.c
> @@ -4179,7 +4179,7 @@ s_riscv_option (int x ATTRIBUTE_UNUSED)
>      }
>    else
>      {
> -      as_warn (_("unrecognized .option directive: %s\n"), name);
> +      as_warn (_("unrecognized .option directive: %s"), name);
>      }
>    *input_line_pointer = ch;
>    demand_empty_rest_of_line ();