public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Nelson Chu <nelson@rivosinc.com>
To: Branislav Brzak <Branislav.Brzak@syrmia.com>
Cc: Jan Beulich <jbeulich@suse.com>,
	Dragoslav Sicarov <Dragoslav.Sicarov@syrmia.com>,
	 Djordje Todorovic <Djordje.Todorovic@syrmia.com>,
	 "binutils@sourceware.org" <binutils@sourceware.org>
Subject: Re: [PATCH 0/2] riscv: Fix gas when encoding BE floats/doubles
Date: Fri, 16 Jun 2023 08:38:08 +0800	[thread overview]
Message-ID: <CAPpQWtCpOX9hevVTyxJWvKfE5Cg+MMrMOO8s8PH96qbKcQkKbQ@mail.gmail.com> (raw)
In-Reply-To: <AM6PR03MB4984EDF2131CE06BD878814B985BA@AM6PR03MB4984.eurprd03.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 820 bytes --]

On Thu, Jun 15, 2023 at 8:14 PM Branislav Brzak <Branislav.Brzak@syrmia.com>
wrote:

> Hi,
>
> I wasn't aware of that patch. The only difference between
> my patch and Andreas are that I have added tests to test
> encoding of doubles as well as float ones.
>

If you are willing to, then after Andreas committing his patch, you can
send and support the double-testcase with another patch.

Did you see
> https://sourceware.org/pipermail/binutils/2023-June/127845.html
> ? (Only the cover letter came through so far, so I can't tell yet
> whether you do anything different than Andreas does. Also, as an
> aside, it typically helps if you Cc arch maintainers for arch
> patches.)
>

Yeah, cc arch maintainers for arch patches really helps, thanks for
pointing this out, Jan :-)

Thanks
Nelson

  reply	other threads:[~2023-06-16  0:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-15 11:09 Branislav Brzak
2023-06-15 12:09 ` Jan Beulich
2023-06-15 12:14   ` Branislav Brzak
2023-06-16  0:38     ` Nelson Chu [this message]
2023-06-19  7:18     ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPpQWtCpOX9hevVTyxJWvKfE5Cg+MMrMOO8s8PH96qbKcQkKbQ@mail.gmail.com \
    --to=nelson@rivosinc.com \
    --cc=Branislav.Brzak@syrmia.com \
    --cc=Djordje.Todorovic@syrmia.com \
    --cc=Dragoslav.Sicarov@syrmia.com \
    --cc=binutils@sourceware.org \
    --cc=jbeulich@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).